Suhas Daftuar
b72c0bd4c9
[qa] Add a test for merkle proof malleation
...
Github-Pull: #13452
Rebased-From: d280617bf569f84457eaea546541dc74c67cd1e4
6 years ago
Gregory Sanders
6b9dc8ceae
have verifytxoutproof check the number of txns in proof structure
...
Github-Pull: #13452
Rebased-From: ed82f1700006830b6fe34572b66245c1487ccd29
6 years ago
MarcoFalke
ed82e7176d
wallet: Erase wtxOrderd wtx pointer on removeprunedfunds
...
Github-Pull: #13437
Rebased-From: faa18ca046e9043b2cf68cb1bd17cc8c60fe26d9
6 years ago
practicalswift
e15e3a9ddd
Remove boost dependency (boost/assign/std/vector.hpp)
...
Github-Pull: #13545
Rebased-From: 962d8eed5bdbe62b9926f01cb85bdce9d435d3d6
6 years ago
practicalswift
10621995ed
Fix incorrect tests
...
Github-Pull: #13545
Rebased-From: c6fd0df4efcd9f75c43ff527fd57fe43bc47a474
6 years ago
Bernhard M. Wiedemann
170b309981
Make tests pass after 2020
...
also test that 64 bit integers are properly handled
Github-Pull: #13061
Rebased-From: 3ee4be10500710fc8e9b03acf974fd81224c05c4
6 years ago
Suhas Daftuar
cfc6f7413b
[rpcwallet] Clamp walletpassphrase value at 100M seconds
...
Larger values seem to trigger a bug on macos+libevent (resulting in the
rpc server stopping).
Github-Pull: #12905
Rebased-From: 662d19ff7217d0e6c7975ca311933f640955a53e
6 years ago
joemphilips
bf1f150190
rpc: fix type mistmatch in listreceivedbyaddress
...
Github-Pull: #12837
Rebased-From: 05c03d1249c6fe30dbfcea9f3f3a3bd02106035b
6 years ago
John Newbery
2291774bd5
[trivial] Add newlines to end of log messages.
...
Log messages should terminate with a '\n', or the following log will be
written to the same line without a timestamp. Fix a couple of cases
where the message is not terminated with a \n.
Github-Pull: #12887
Rebased-From: 5b10ab0116245ee73b493e2248ad2f8bb8e34f21
6 years ago
MarcoFalke
cf6feb7837
qt: Avoid resetting on resetguisettigs=0
...
Github-Pull: #12793
Rebased-From: 342fb8034640d4393771899dc132c9e3b170b369
6 years ago
MarcoFalke
cbdabef35e
qa: Fix wallet_listreceivedby race
...
Github-Pull: #13304
Rebased-From: fa865efa4a21ae08be8b4c390b7661182e0b415b
6 years ago
lmanners
79c4fff9ed
[tests] Fixed intermittent failure in p2p_sendheaders.py.
...
Added handling for the case where headers are announced over more than one message.
refs #12453
Github-Pull: #13192
Rebased-From: 12d1b77f7eb2ca274890d9fb45d6c19a40ba8f74
6 years ago
Matt Corallo
c04a4a5ae9
Remove useless mapRequest tracking that just effects Qt display.
...
I thought we had removed this a long time ago, TBH, its really
confusing feedback to users that we display whether a tx was
broadcast to immediate neighbor nodes, given that has little
indication of whether the tx propagated very far.
Github-Pull: #13622
Rebased-From: beef7ec4be725beea870a2da510d2817487601ec
6 years ago
Wladimir J. van der Laan
dac5374cce
Merge #13455 : [0.16.2] Backports
...
9fd3e0001f
depends: Update Qt download url (fanquake)
f7401c86b9
Fix parameter count check for importpubkey. (Kristaps Kaupe)
cbd2f70b75
expose CBlockIndex::nTx in getblock(header) (Gregory Sanders)
ce8aa5491f
Add Windows shutdown handler (Chun Kuan Lee)
18b0c69e2f
Bugfix: Include <memory> for std::unique_ptr (Luke Dashjr)
Pull request description:
Backports:
* #12859 Bugfix: Include <memory> for std::unique_ptr
* #13131 Add Windows shutdown handler
* #13451 rpc: expose CBlockIndex::nTx in getblock(header)
* #13507 RPC: Fix parameter count check for importpubkey
* #13544 depends: Update Qt download url
to the 0.16 branch.
Tree-SHA512: eeaec52d001d5c81e67dda3a2d3fee7a9445e569366e597b18e81d802c1b7f89e545afd53d094740c37c1714050304979398b9860144454d3a5cb5abc9e9eaca
7 years ago
fanquake
9fd3e0001f
depends: Update Qt download url
...
GitHub-Pull: #13544
Rebased-From: 2fca656
7 years ago
Adrian Gallagher
47372d7a7e
Merge pull request #508 from thrasher-/0.16
...
Preparation for v0.16.1 release candidate
7 years ago
Kristaps Kaupe
f7401c86b9
Fix parameter count check for importpubkey.
...
Github-Pull: #13507
Rebased-From: 3f72d04
7 years ago
Adrian Gallagher
de26154265
Litecoin: Add v0.16.1 release notes
7 years ago
Adrian Gallagher
dee12239d2
Litecoin: Branding
7 years ago
Adrian Gallagher
67f7fbf9f5
Litecoin: Update default minimum chain work and default assume valid values
7 years ago
Adrian Gallagher
8ca2ccc96c
Litecoin: Bump blockchain size value
7 years ago
Adrian Gallagher
7b0905f640
Litecoin: Update Qt translations
7 years ago
Adrian Gallagher
70312a6635
Litecoin: Update man files
7 years ago
Adrian Gallagher
8203195e2e
Litecoin: GetPoWHash for validation block tests
7 years ago
jaykishan mutkawoa
2bce040c78
Fix CVE-2018-12356 by hardening the regex. ( #503 )
7 years ago
Adrian Gallagher
4c20019d30
Merge remote-tracking branch 'bitcoin/0.16'
7 years ago
Gregory Sanders
cbd2f70b75
expose CBlockIndex::nTx in getblock(header)
...
GitHub-Pull: #13451
Rebased-From: 86edf4a
7 years ago
Wladimir J. van der Laan
dac5d68fc6
doc: Last-minute edits to 0.16.1 release notes
...
Tree-SHA512: 951cdf2b27ddb702906303d1bc07bac204323baf0ac4513ccb5da44cb2cb29ce74a62c75fe6531cfddc9059130890fe11929ea4ac545a17190d57e5163c7cc06
7 years ago
Chun Kuan Lee
ce8aa5491f
Add Windows shutdown handler
...
GitHub-Pull: #13131
Rebased-From: ddebde7
7 years ago
Luke Dashjr
18b0c69e2f
Bugfix: Include <memory> for std::unique_ptr
...
GitHub-Pull: #12859
Rebased-From: a5bca13
7 years ago
Wladimir J. van der Laan
4ea3e8ef07
qt: Periodic translations update
...
Tree-SHA512: eb84c69adcf1547f6bfcfd2d54ef7201c7147c26aa95e07a67be9ac12eeb31b173c847bd5f27b973c911c287ef3654413bdb201d70e4b9414f784e2d58a0071a
7 years ago
Wladimir J. van der Laan
afc115d753
doc: Add commits and authors to release notes for rc1
...
Tree-SHA512: e6779d21616eec04168b5726d1fe8a1b8356c3de7f5bad30a94848a0db7c0f84fcc0d6f965424b4f7a2a9a8daba1a11fc53b148b918230b39d8095fa215be6f4
7 years ago
Wladimir J. van der Laan
224a41d1f6
Merge #13336 : [0.16.1] doc: Bump to Ubuntu Bionic 18.04 in build-windows.md
...
6de754306e
doc: Bump to Ubuntu Bionic 18.04 in build-windows.md (Chun Kuan Lee)
Pull request description:
Windows starts to provide Ubuntu 18.04 WSL, it can be downloaded from Microsoft Store.
GitHub-Pull: #13246
Rebased-From: 9d4f942
Tree-SHA512: f72b97637fcedee4b21316ecafd43c5889111fedbc6522f805df40241558fdfe7579ad4b6bce1940890b3bc352fd64d428f13fb40e97f913031e7eccdc0f7ddf
7 years ago
Chun Kuan Lee
6de754306e
doc: Bump to Ubuntu Bionic 18.04 in build-windows.md
...
Windows starts to provide Ubuntu 18.04 WSL, it can be downloaded from Microsoft Store.
GitHub-Pull: #13246
Rebased-From: 9d4f942
7 years ago
Wladimir J. van der Laan
81bc9829cd
build: Bump version to 0.16.1
...
Tree-SHA512: 3408031113febc1d9ac3734a355c832813046eb1f2eaa7f29ff0c7b330026ac1fc664ae9ea773370c9abeca0a50f0ec1bb50a6f5940f86df335f822c1f0b1a73
7 years ago
Wladimir J. van der Laan
b42c355085
qt: Pre-rc1 transifex pull
...
Tree-SHA512: 91372301f876e3813ebac68d466941ba488b8c74f7525ea9686945d50c2b2e29290c84722c96eebed40a246eca343981feaf2f51b836ba2b3923e4ddc15aef30
7 years ago
Wladimir J. van der Laan
07fb2a6e16
Merge #13319 : [0.16.1] gui: Backport bech32 checkbox
...
dcb13a0ab6
qt: Update translations pre-rc1 (MarcoFalke)
0eda98d01b
GUI: Allow generating Bech32 addresses with a legacy-address default (Luke Dashjr)
ea487f9f90
GUI: Rephrase Bech32 checkbox text/tooltip (Luke Dashjr)
Pull request description:
Tree-SHA512: 1298fa92579bcbdc80537a3a5b2f8aae460c7ebcb46fbade4305d45c883e1717587e24711792b5f65fd25b7a5999d7b9c82e63f5b4d18240f9ec4a0041efdb9a
7 years ago
Wladimir J. van der Laan
bfd1e92333
Merge #13317 : [0.16.1] Remaining backports
...
08334b73be
qa: Pad scriptPubKeys to get minimum sized txs (MarcoFalke)
0a000b9b73
Policy to reject extremely small transactions (Johnson Lau)
1fffc2b346
Add transaction tests for constant scriptCode (Johnson Lau)
d353dd121b
Add constant scriptCode policy in non-segwit scripts (Johnson Lau)
d6c3a08c48
Add unit tests for signals generated by ProcessNewBlock() (Jesse Cohen)
bb79aaf93a
Fix concurrency-related bugs in ActivateBestChain (Jesse Cohen)
0948153ea6
Do not unlock cs_main in ABC unless we've actually made progress. (Matt Corallo)
c71e535aec
Bugfix: ensure consistency of m_failed_blocks after reconsiderblock (Suhas Daftuar)
Pull request description:
Tree-SHA512: 7466b8fcc2a1d598102028019d82c581fe985a11679d002c430287851142598c9172249aa9de511a26bd4c92dc4891b5ab597c24af4f591f2158cc2a58ff7beb
7 years ago
MarcoFalke
dcb13a0ab6
qt: Update translations pre-rc1
7 years ago
Luke Dashjr
0eda98d01b
GUI: Allow generating Bech32 addresses with a legacy-address default
...
Github-Pull: #13251
Rebased-From: 82dda6bed971c5638962442b4927845fe5eb6600
7 years ago
Luke Dashjr
ea487f9f90
GUI: Rephrase Bech32 checkbox text/tooltip
...
- "Bech32" isn't very user-friendly
- You don't spend from addresses
Github-Pull: #13251
Rebased-From: 7ab1c6f6a736fc7762b8dd513d8634754319d227
7 years ago
MarcoFalke
08334b73be
qa: Pad scriptPubKeys to get minimum sized txs
...
Github-Pull: #11423
Rebased-From: 364bae5f7a6b16eef63990154e48f19e7e693039
7 years ago
Johnson Lau
0a000b9b73
Policy to reject extremely small transactions
...
A transaction with 1 segwit input and 1 P2WPHK output has non-witness size of 82 bytes. Anything smaller than this have unnecessary malloc overhead and are not relayed/mined.
Github-Pull: #11423
Rebased-From: 7485488e907e236133a016ba7064c89bf9ab6da3
7 years ago
Johnson Lau
1fffc2b346
Add transaction tests for constant scriptCode
...
Tests showing that CONST_SCRIPTCODE is applied only to non-segwit transactions
Github-Pull: #11423
Rebased-From: 0f8719bb035187076eeac025e2c786feb0f452d7
7 years ago
Johnson Lau
d353dd121b
Add constant scriptCode policy in non-segwit scripts
...
This disables OP_CODESEPARATOR in non-segwit scripts (even in an unexecuted branch), and makes a positive FindAndDelete result invalid. This ensures that the scriptCode serialized in SignatureHash() is always the same as the script passing to the EvalScript.
Github-Pull: #11423
Rebased-From: 9dabfe49c066301ef75bcfcb089fd308366127c4
7 years ago
Jesse Cohen
d6c3a08c48
Add unit tests for signals generated by ProcessNewBlock()
...
After a recent bug discovered in callback ordering in MainSignals,
this test checks invariants in ordering of
BlockConnected / BlockDisconnected / UpdatedChainTip signals
Github-Pull: #13023
Rebased-From: dd435ad40267f5c50ff17533c696f9302829a6a6
7 years ago
Jesse Cohen
bb79aaf93a
Fix concurrency-related bugs in ActivateBestChain
...
If multiple threads are invoking ActivateBestChain, it was possible to have
them working towards different tips, and we could arrive at a less work tip
than we should. Fix this by introducing a ChainState lock which must
be held for the entire duration of ActivateBestChain to enforce
exclusion in ABC.
Github-Pull: #13023
Rebased-From: a3ae8e68739023e5dba9e5cb190e707ed4603316
7 years ago
Matt Corallo
0948153ea6
Do not unlock cs_main in ABC unless we've actually made progress.
...
Technically, some internal datastructures may be in an inconsistent
state if we do this, though there are no known bugs there. Still,
for future safety, its much better to only unlock cs_main if we've
made progress (not just tried a reorg which may make progress).
Github-Pull: #13023
Rebased-From: ecc3c4a019e6db30e208b8554b1a3658dcb9a80a
7 years ago
Suhas Daftuar
c71e535aec
Bugfix: ensure consistency of m_failed_blocks after reconsiderblock
...
Github-Pull: #13199
Rebased-From: 11fa6bb66e8c1562305d034903a0dc6aee6eea20
7 years ago
Wladimir J. van der Laan
50b2c9e0df
Merge #13253 : [0.16] Further Backports
...
acdf433822
Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTip (Jesse Cohen)
5ff571e90c
[wallet] [tests] Test disallowed multiwallet params (John Newbery)
4c14e7b67c
[wallet] Fix zapwallettxes/multiwallet interaction. (John Newbery)
4087dd08e7
RPC Docs: gettxout*: clarify bestblock and unspent counts (David A. Harding)
b8aacd660e
[qa] Handle disconnect_node race (Suhas Daftuar)
Pull request description:
Backports:
- #13201 [qa] Handle disconnect_node race
- #13184 RPC Docs: gettxout*: clarify bestblock and unspent counts
- #13030 [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction.
- #12988 Hold cs_main while calling UpdatedBlockTip() signal
to the 0.16 branch.
Tree-SHA512: 8f65002bbafaf9c436f89051b2d79bf6a668fbd07bd317c64af238ed4a7c8efe776864b739a7f2869f1e3daa16f2f4366a85f41b188f9c454879d2c7b309be50
7 years ago