MarcoFalke
d9c563095d
qa: Initialize lockstack to prevent null pointer deref
...
Github-Pull: #13300
Rebased-From: fa9da85b7cc759d06bc24854be2bad0ea87b6006
2018-07-14 11:12:47 -04:00
Wladimir J. van der Laan
21dd5127a4
gui: Show messages as text not html
...
Currently, error messages (such as InitError) are displayed as-is, which
means Qt does auto detection on the format.
This means that it's possible to inject HTML from the command line
though e.g. specifying a wallet name with HTML in it. This isn't
a direct security risk because fetching content from internet is
disabled (and as far as I know we never report strings received
from the network this way). However, it can be confusing.
So explicitly force the format as text.
Github-Pull: #12617
Rebased-From: 6fbc0986fa2d49a1cb65b60eca71c25c84842a54
2018-07-13 13:33:58 -04:00
Sjors Provoost
f78e7f6589
[qt] send: Clear All also resets coin control options
...
Github-Pull: #12432
Rebased-From: f506c0a7f8ea6bae089177884e44e38cd2bfeb23
2018-07-13 13:33:58 -04:00
Pieter Wuille
657dfc5bca
Fix csBestBlock/cvBlockChange waiting in rpc/mining
...
Github-Pull: #12743
Rebased-From: 45dd13503918e75a45ce33eb5c934b998790fdc8
2018-07-13 12:23:39 -04:00
532479301
88d1a649a2
Consensus: Fix bug when compiler do not support __builtin_clz*
...
#ifdef is not correct since defination is defined to 0 or 1. Should change to #if
Github-Pull: #12573
Rebased-From: 18307849b405f9e2067eaa8091b105838f413707
2018-07-13 12:23:39 -04:00
Suhas Daftuar
b72c0bd4c9
[qa] Add a test for merkle proof malleation
...
Github-Pull: #13452
Rebased-From: d280617bf569f84457eaea546541dc74c67cd1e4
2018-07-13 12:23:39 -04:00
Gregory Sanders
6b9dc8ceae
have verifytxoutproof check the number of txns in proof structure
...
Github-Pull: #13452
Rebased-From: ed82f1700006830b6fe34572b66245c1487ccd29
2018-07-13 12:23:39 -04:00
MarcoFalke
ed82e7176d
wallet: Erase wtxOrderd wtx pointer on removeprunedfunds
...
Github-Pull: #13437
Rebased-From: faa18ca046e9043b2cf68cb1bd17cc8c60fe26d9
2018-07-13 11:50:25 -04:00
practicalswift
e15e3a9ddd
Remove boost dependency (boost/assign/std/vector.hpp)
...
Github-Pull: #13545
Rebased-From: 962d8eed5bdbe62b9926f01cb85bdce9d435d3d6
2018-07-13 11:50:25 -04:00
practicalswift
10621995ed
Fix incorrect tests
...
Github-Pull: #13545
Rebased-From: c6fd0df4efcd9f75c43ff527fd57fe43bc47a474
2018-07-13 11:50:25 -04:00
Bernhard M. Wiedemann
170b309981
Make tests pass after 2020
...
also test that 64 bit integers are properly handled
Github-Pull: #13061
Rebased-From: 3ee4be10500710fc8e9b03acf974fd81224c05c4
2018-07-12 10:27:29 -04:00
Suhas Daftuar
cfc6f7413b
[rpcwallet] Clamp walletpassphrase value at 100M seconds
...
Larger values seem to trigger a bug on macos+libevent (resulting in the
rpc server stopping).
Github-Pull: #12905
Rebased-From: 662d19ff7217d0e6c7975ca311933f640955a53e
2018-07-12 10:03:03 -04:00
joemphilips
bf1f150190
rpc: fix type mistmatch in listreceivedbyaddress
...
Github-Pull: #12837
Rebased-From: 05c03d1249c6fe30dbfcea9f3f3a3bd02106035b
2018-07-12 10:03:03 -04:00
John Newbery
2291774bd5
[trivial] Add newlines to end of log messages.
...
Log messages should terminate with a '\n', or the following log will be
written to the same line without a timestamp. Fix a couple of cases
where the message is not terminated with a \n.
Github-Pull: #12887
Rebased-From: 5b10ab0116245ee73b493e2248ad2f8bb8e34f21
2018-07-12 10:03:02 -04:00
MarcoFalke
cf6feb7837
qt: Avoid resetting on resetguisettigs=0
...
Github-Pull: #12793
Rebased-From: 342fb8034640d4393771899dc132c9e3b170b369
2018-07-12 10:03:02 -04:00
MarcoFalke
cbdabef35e
qa: Fix wallet_listreceivedby race
...
Github-Pull: #13304
Rebased-From: fa865efa4a21ae08be8b4c390b7661182e0b415b
2018-07-12 10:03:02 -04:00
lmanners
79c4fff9ed
[tests] Fixed intermittent failure in p2p_sendheaders.py.
...
Added handling for the case where headers are announced over more than one message.
refs #12453
Github-Pull: #13192
Rebased-From: 12d1b77f7eb2ca274890d9fb45d6c19a40ba8f74
2018-07-12 10:03:02 -04:00
Matt Corallo
c04a4a5ae9
Remove useless mapRequest tracking that just effects Qt display.
...
I thought we had removed this a long time ago, TBH, its really
confusing feedback to users that we display whether a tx was
broadcast to immediate neighbor nodes, given that has little
indication of whether the tx propagated very far.
Github-Pull: #13622
Rebased-From: beef7ec4be725beea870a2da510d2817487601ec
2018-07-12 09:49:41 -04:00
Wladimir J. van der Laan
dac5374cce
Merge #13455 : [0.16.2] Backports
...
9fd3e0001fc20eecbfa823e12f66da4054a072a7 depends: Update Qt download url (fanquake)
f7401c86b9c9c58cfe57c2a49d3b4e00f80ded4a Fix parameter count check for importpubkey. (Kristaps Kaupe)
cbd2f70b75016bbadeb212c823b5c1ece95d5241 expose CBlockIndex::nTx in getblock(header) (Gregory Sanders)
ce8aa5491f35c2cca03ba1877cd4c926b506a961 Add Windows shutdown handler (Chun Kuan Lee)
18b0c69e2fc9f9d5cd56659abab467c2c6826be2 Bugfix: Include <memory> for std::unique_ptr (Luke Dashjr)
Pull request description:
Backports:
* #12859 Bugfix: Include <memory> for std::unique_ptr
* #13131 Add Windows shutdown handler
* #13451 rpc: expose CBlockIndex::nTx in getblock(header)
* #13507 RPC: Fix parameter count check for importpubkey
* #13544 depends: Update Qt download url
to the 0.16 branch.
Tree-SHA512: eeaec52d001d5c81e67dda3a2d3fee7a9445e569366e597b18e81d802c1b7f89e545afd53d094740c37c1714050304979398b9860144454d3a5cb5abc9e9eaca
2018-07-09 21:07:13 +02:00
fanquake
9fd3e0001f
depends: Update Qt download url
...
GitHub-Pull: #13544
Rebased-From: 2fca656
2018-06-30 09:33:58 +08:00
Adrian Gallagher
47372d7a7e
Merge pull request #508 from thrasher-/0.16
...
Preparation for v0.16.1 release candidate
2018-06-27 17:27:01 +10:00
Kristaps Kaupe
f7401c86b9
Fix parameter count check for importpubkey.
...
Github-Pull: #13507
Rebased-From: 3f72d04
2018-06-26 07:58:01 +08:00
Adrian Gallagher
de26154265
Litecoin: Add v0.16.1 release notes
2018-06-17 19:14:25 -07:00
Adrian Gallagher
dee12239d2
Litecoin: Branding
2018-06-17 19:01:58 -07:00
Adrian Gallagher
67f7fbf9f5
Litecoin: Update default minimum chain work and default assume valid values
2018-06-17 18:57:43 -07:00
Adrian Gallagher
8ca2ccc96c
Litecoin: Bump blockchain size value
2018-06-17 18:57:33 -07:00
Adrian Gallagher
7b0905f640
Litecoin: Update Qt translations
2018-06-17 18:57:23 -07:00
Adrian Gallagher
70312a6635
Litecoin: Update man files
2018-06-17 18:57:11 -07:00
Adrian Gallagher
8203195e2e
Litecoin: GetPoWHash for validation block tests
2018-06-17 18:56:31 -07:00
jaykishan mutkawoa
2bce040c78
Fix CVE-2018-12356 by hardening the regex. ( #503 )
2018-06-17 18:56:01 -07:00
Adrian Gallagher
4c20019d30
Merge remote-tracking branch 'bitcoin/0.16'
2018-06-17 18:55:26 -07:00
Gregory Sanders
cbd2f70b75
expose CBlockIndex::nTx in getblock(header)
...
GitHub-Pull: #13451
Rebased-From: 86edf4a
2018-06-15 13:34:09 +08:00
Wladimir J. van der Laan
dac5d68fc6
doc: Last-minute edits to 0.16.1 release notes
...
Tree-SHA512: 951cdf2b27ddb702906303d1bc07bac204323baf0ac4513ccb5da44cb2cb29ce74a62c75fe6531cfddc9059130890fe11929ea4ac545a17190d57e5163c7cc06
2018-06-13 14:32:11 +02:00
Chun Kuan Lee
ce8aa5491f
Add Windows shutdown handler
...
GitHub-Pull: #13131
Rebased-From: ddebde7
2018-06-13 16:09:04 +08:00
Luke Dashjr
18b0c69e2f
Bugfix: Include <memory> for std::unique_ptr
...
GitHub-Pull: #12859
Rebased-From: a5bca13
2018-06-13 16:07:44 +08:00
Wladimir J. van der Laan
4ea3e8ef07
qt: Periodic translations update
...
Tree-SHA512: eb84c69adcf1547f6bfcfd2d54ef7201c7147c26aa95e07a67be9ac12eeb31b173c847bd5f27b973c911c287ef3654413bdb201d70e4b9414f784e2d58a0071a
2018-06-01 11:37:03 +02:00
Wladimir J. van der Laan
afc115d753
doc: Add commits and authors to release notes for rc1
...
Tree-SHA512: e6779d21616eec04168b5726d1fe8a1b8356c3de7f5bad30a94848a0db7c0f84fcc0d6f965424b4f7a2a9a8daba1a11fc53b148b918230b39d8095fa215be6f4
2018-05-30 14:01:27 +02:00
Wladimir J. van der Laan
224a41d1f6
Merge #13336 : [0.16.1] doc: Bump to Ubuntu Bionic 18.04 in build-windows.md
...
6de754306e81dd37a887c4940f2bce0e99c3fc62 doc: Bump to Ubuntu Bionic 18.04 in build-windows.md (Chun Kuan Lee)
Pull request description:
Windows starts to provide Ubuntu 18.04 WSL, it can be downloaded from Microsoft Store.
GitHub-Pull: #13246
Rebased-From: 9d4f942
Tree-SHA512: f72b97637fcedee4b21316ecafd43c5889111fedbc6522f805df40241558fdfe7579ad4b6bce1940890b3bc352fd64d428f13fb40e97f913031e7eccdc0f7ddf
2018-05-28 15:04:32 +02:00
Chun Kuan Lee
6de754306e
doc: Bump to Ubuntu Bionic 18.04 in build-windows.md
...
Windows starts to provide Ubuntu 18.04 WSL, it can be downloaded from Microsoft Store.
GitHub-Pull: #13246
Rebased-From: 9d4f942
2018-05-28 20:35:33 +08:00
Wladimir J. van der Laan
81bc9829cd
build: Bump version to 0.16.1
...
Tree-SHA512: 3408031113febc1d9ac3734a355c832813046eb1f2eaa7f29ff0c7b330026ac1fc664ae9ea773370c9abeca0a50f0ec1bb50a6f5940f86df335f822c1f0b1a73
2018-05-28 12:55:30 +02:00
Wladimir J. van der Laan
b42c355085
qt: Pre-rc1 transifex pull
...
Tree-SHA512: 91372301f876e3813ebac68d466941ba488b8c74f7525ea9686945d50c2b2e29290c84722c96eebed40a246eca343981feaf2f51b836ba2b3923e4ddc15aef30
2018-05-28 12:55:12 +02:00
Wladimir J. van der Laan
07fb2a6e16
Merge #13319 : [0.16.1] gui: Backport bech32 checkbox
...
dcb13a0ab687b23465a046e35ca75a432427b833 qt: Update translations pre-rc1 (MarcoFalke)
0eda98d01b6fef1309cdaf8365b752fed39d39a5 GUI: Allow generating Bech32 addresses with a legacy-address default (Luke Dashjr)
ea487f9f905b5971e686458b4687157c001b1119 GUI: Rephrase Bech32 checkbox text/tooltip (Luke Dashjr)
Pull request description:
Tree-SHA512: 1298fa92579bcbdc80537a3a5b2f8aae460c7ebcb46fbade4305d45c883e1717587e24711792b5f65fd25b7a5999d7b9c82e63f5b4d18240f9ec4a0041efdb9a
2018-05-28 12:07:14 +02:00
Wladimir J. van der Laan
bfd1e92333
Merge #13317 : [0.16.1] Remaining backports
...
08334b73be031485a41e2c0647c2df1aa13c6316 qa: Pad scriptPubKeys to get minimum sized txs (MarcoFalke)
0a000b9b73a7d7bb4086aeefc86841d0fc33e652 Policy to reject extremely small transactions (Johnson Lau)
1fffc2b346b2d2e129db5c9f5cad00e820c85c45 Add transaction tests for constant scriptCode (Johnson Lau)
d353dd121be0bf2a525e4bbea2b4ada2954d2b15 Add constant scriptCode policy in non-segwit scripts (Johnson Lau)
d6c3a08c482225b3742c9145a9cbfe60567f0c4f Add unit tests for signals generated by ProcessNewBlock() (Jesse Cohen)
bb79aaf93af93d5f9f5097cff4fbb2791af86875 Fix concurrency-related bugs in ActivateBestChain (Jesse Cohen)
0948153ea62ff4921daef326da0fddb8425cd866 Do not unlock cs_main in ABC unless we've actually made progress. (Matt Corallo)
c71e535aec5aaef04764238a94e456f2405adbb5 Bugfix: ensure consistency of m_failed_blocks after reconsiderblock (Suhas Daftuar)
Pull request description:
Tree-SHA512: 7466b8fcc2a1d598102028019d82c581fe985a11679d002c430287851142598c9172249aa9de511a26bd4c92dc4891b5ab597c24af4f591f2158cc2a58ff7beb
2018-05-28 10:08:51 +02:00
MarcoFalke
dcb13a0ab6
qt: Update translations pre-rc1
2018-05-24 16:46:20 -04:00
Luke Dashjr
0eda98d01b
GUI: Allow generating Bech32 addresses with a legacy-address default
...
Github-Pull: #13251
Rebased-From: 82dda6bed971c5638962442b4927845fe5eb6600
2018-05-24 16:32:03 -04:00
Luke Dashjr
ea487f9f90
GUI: Rephrase Bech32 checkbox text/tooltip
...
- "Bech32" isn't very user-friendly
- You don't spend from addresses
Github-Pull: #13251
Rebased-From: 7ab1c6f6a736fc7762b8dd513d8634754319d227
2018-05-24 16:28:16 -04:00
MarcoFalke
08334b73be
qa: Pad scriptPubKeys to get minimum sized txs
...
Github-Pull: #11423
Rebased-From: 364bae5f7a6b16eef63990154e48f19e7e693039
2018-05-24 14:17:50 -04:00
Johnson Lau
0a000b9b73
Policy to reject extremely small transactions
...
A transaction with 1 segwit input and 1 P2WPHK output has non-witness size of 82 bytes. Anything smaller than this have unnecessary malloc overhead and are not relayed/mined.
Github-Pull: #11423
Rebased-From: 7485488e907e236133a016ba7064c89bf9ab6da3
2018-05-24 14:03:05 -04:00
Johnson Lau
1fffc2b346
Add transaction tests for constant scriptCode
...
Tests showing that CONST_SCRIPTCODE is applied only to non-segwit transactions
Github-Pull: #11423
Rebased-From: 0f8719bb035187076eeac025e2c786feb0f452d7
2018-05-24 14:03:01 -04:00
Johnson Lau
d353dd121b
Add constant scriptCode policy in non-segwit scripts
...
This disables OP_CODESEPARATOR in non-segwit scripts (even in an unexecuted branch), and makes a positive FindAndDelete result invalid. This ensures that the scriptCode serialized in SignatureHash() is always the same as the script passing to the EvalScript.
Github-Pull: #11423
Rebased-From: 9dabfe49c066301ef75bcfcb089fd308366127c4
2018-05-24 14:03:01 -04:00