Philip Kaufmann
1c94f88d5e
fix compiler warning "suggest parentheses around assignment used as truth
...
value [-Wparentheses]" in util.cpp
13 years ago
Philip Kaufmann
f8e4d43be7
fix compiler warning "suggest explicit braces to avoid ambiguous "else"
...
[-Wparentheses]" in net.cpp
13 years ago
Gavin Andresen
be8651dde7
Check earlier for blocks with duplicate transactions. Fixes #1167
13 years ago
Wladimir J. van der Laan
ec4997d48f
Merge pull request #1139 from Diapolo/messagepage
...
change button tooltip on sign message page for copy to clipboard...
13 years ago
Wladimir J. van der Laan
0acb1e715c
Merge pull request #1163 from laanwj/2012_04_uiperformanceissue
...
Fix critical UI performance issue (#1154 )
13 years ago
Wladimir J. van der Laan
6974aff668
Fix critical UI performance issue ( #1154 )
13 years ago
Gavin Andresen
0acbe31cfc
Update openssl version
13 years ago
Gavin Andresen
cedcec2dec
Bump win32.deps version number for new openssl
13 years ago
Gavin Andresen
2b4d7735b6
Windows build: compile against openssl 1.0.1b
13 years ago
Gavin Andresen
2c31cfc271
Bump version numbers for 0.6.1rc1
13 years ago
Gavin Andresen
dfead66eac
Merge pull request #1151 from freewil/listsinceblock-blockhash
...
listsinceblock: rpc param blockid -> blockhash
13 years ago
Gavin Andresen
27d4b53a5c
Merge pull request #1150 from gavinandresen/NOPCH
...
Remove unused -DNOPCH
13 years ago
Gavin Andresen
b2997dc043
Merge pull request #1152 from freewil/remove-strange-debug
...
remove strange debug message from listsinceblock
13 years ago
Pieter Wuille
287ce61dc2
Merge pull request #1146 from drizztbsd/posix-include
...
We should include netinet/in.h to use sockaddr_in (POSIX.1-2001)
13 years ago
freewil
42ce57687a
remove strange debug message from listsinceblock
13 years ago
freewil
fdb204abb1
listsinceblock: rpc param blockid -> blockhash
...
This is more consistent with the rest of the labeling seen
by the user when accessing the rpc commands.
13 years ago
Gavin Andresen
9e71a5cd23
Define TEST_DATA_DIR so unit tests can be run from any current working directory
13 years ago
Gavin Andresen
08e663d7e2
Undo part of c2e8c8ac
to fix issue#1148
13 years ago
Pieter Wuille
e1ea3ce7aa
Merge pull request #1119 from sipa/fastshutdown
...
Make lsn_reset ("detach databases") optional and off by default.
13 years ago
Gavin Andresen
cfc45319fe
Remove unused -DNOPCH
13 years ago
Pieter Wuille
83743ed681
Make lsn_reset ("detach databases") optional and off by default.
...
Add an option -detachdb (and entry in OptionDialog), without which no
lsn_reset is called on addr.dat and blkindex.dat. That means these
files cannot be moved to a new environment, but shutdown can be
significantly faster. The wallet file is always lsn_reset'ed.
-detachdb corresponds to the old behaviour, though it is off by
default now to speed up shutdowns.
13 years ago
Timothy Redaelli
5e9dc15360
We should include netinet/in.h to use sockaddr_in (POSIX.1-2001)
13 years ago
Jeff Garzik
c2e8c8acd8
Merge pull request #1140 from jgarzik/sign-compare
...
Address many more sign comparison warnings
13 years ago
Jeff Garzik
735a60698c
Change signed->unsigned at 3 code sites
...
This resolves signed/unsigned comparison warnings.
13 years ago
Jeff Garzik
5aa0b23825
CBlock::WriteToDisk() properly checks ftell(3) for error return
...
Rather than storing ftell(3)'s return value -- a long -- in an
unsigned int, we store and check a properly typed temp. Then, assured a
non-negative value, we store in nBlockPosRet.
13 years ago
Jeff Garzik
1d8c7a9557
Add casts for unavoidable signed/unsigned comparisons
...
At these code sites, it is preferable to cast rather than change
a variable's type.
13 years ago
Jeff Garzik
c0a0a93d02
Test ScriptSigArgsExpected() for error, before accumulating return value
13 years ago
Jeff Garzik
7bd9c3a3cf
SigOp and orphan-tx constants and counts are always unsigned.
...
Fixes several sign-comparison warnings.
13 years ago
Pieter Wuille
ef758662c5
Merge pull request #1133 from sipa/abspath
...
Make GetDataDir return absolute paths
13 years ago
Jeff Garzik
faf705a42a
Prefer 'unsigned int' for loop index variables tested against ::size()
...
C++ STL ::size() generally returns unsigned, which implies that "int idx"
style of loop variable will generate a signed-vs-unsigned comparison warning
when testing the loop exit condition "idx < blah.size()"
Update areas of the bitcoin code where loop variables may be more properly and
correctly defined as unsigned.
13 years ago
Philip Kaufmann
a2d0fcbe38
change button tooltip on sign message page for copy to clipboard as it was missleading
13 years ago
Pieter Wuille
f4203de302
Make GetDataDir return absolute paths
13 years ago
Pieter Wuille
457661f640
Merge pull request #1124 from sipa/rpcobj3
...
extension of #1103 : encapsulate mapCommands in CRPCTable
13 years ago
Pieter Wuille
7dbe393629
Merge pull request #1131 from laanwj/2012_04_hexstr
...
Integrate @JoelKatz's optimized ToHex (#562 ) into current HexStr function
13 years ago
Pieter Wuille
d5eb41fa08
Merge pull request #1129 from laanwj/2012_04_opcodes
...
Add explicit numeric constant value for all opcodes
13 years ago
Gavin Andresen
febe76e316
Merge pull request #1121 from gavinandresen/scripttest
...
Data-driven script evaluation unit tests (rebased to fix compiler warning).
13 years ago
Gavin Andresen
8449a8788a
Data-drive script evaluation unit tests.
13 years ago
Pieter Wuille
6a7a42be16
Merge pull request #1126 from drizztbsd/master
...
Fix build with gcc 4.7
13 years ago
Wladimir J. van der Laan
88dc2d6c6a
Integrate @JoelKatz's optimized ToHex ( #562 ) into current HexStr function
13 years ago
Wladimir J. van der Laan
b6c837cbe1
Remove no-longer used UI hints in bitcoin core
...
The Qt UI has its own associated structures for temporary transaction state / cache.
13 years ago
Wladimir J. van der Laan
cdcc319c2d
change type of various bare chars to bool that are only used as bool (and never serialized)
13 years ago
Wladimir J. van der Laan
7be8b2ff9c
Add explicit numeric constant value for all opcodes
...
- Easier for debugging (what opcode was 0x... again?)
- Clarifies that the opcodes are set in stone in the protocol, and signals that it is impossible to insert opcodes in between.
13 years ago
Pieter Wuille
e46704dd90
Expose CRPCTable via bitcoinrpc.h for testing
13 years ago
Pieter Wuille
9862229d4d
Encapsulate mapCommands in class CRPCTable
13 years ago
Jeff Garzik
dc42bf52c1
Encapsulate RPC command dispatch in an array of CRPCCommand's
13 years ago
Wladimir J. van der Laan
00b9c0f4b2
Merge pull request #1122 from dlitz/unsigned-char-fix
...
Unsigned char fix & fix undefined phexdigits[255]
13 years ago
Timothy Redaelli
9553c35d89
Add missing includes. (Fix bulding under GCC 4.7)
13 years ago
Pieter Wuille
3b9e6b7820
Merge pull request #959 from rebroad/LoadBlockIndexKillable
...
Added ability to respond to signals during Block Loading stage.
13 years ago
R E Broadley
871c3557bf
Added ability to respond to signals during Block Loading stage.
13 years ago
Dwayne C. Litzenberger
8c8e8c2e93
Fix bugs on 'unsigned char' platforms.
...
In ISO C++, the signedness of 'char' is undefined. On some platforms (e.g.
ARM), 'char' is an unsigned type, but some of the code relies on 'char' being
signed (as it is on x86). This is indicated by compiler warnings like this:
bignum.h: In constructor 'CBigNum::CBigNum(char)':
bignum.h:81:59: warning: comparison is always true due to limited range of data type [-Wtype-limits]
util.cpp: In function 'bool IsHex(const string&)':
util.cpp:427:28: warning: comparison is always false due to limited range of data type [-Wtype-limits]
In particular, IsHex erroneously returned true regardless of the input
characters, as long as the length of the string was a positive multiple of 2.
Note: For testing, it's possible using GCC to force char to be unsigned by
adding the -funsigned-char parameter to xCXXFLAGS.
13 years ago