Merge pull request #2246 from gavinandresen/changefix

Correctly randomize change output position
12 years ago · a078121373
1 changed files with 1 additions and 1 deletions
--- a/src/wallet.cpp
+++ b/src/wallet.cpp
@ -1190,7 +1190,7 @@ bool CWallet::CreateTransaction(const vector<pair<CScript, int64> >& vecSend, CW
				@@ -1190,7 +1190,7 @@ bool CWallet::CreateTransaction(const vector<pair<CScript, int64> >& vecSend, CW
                    scriptChange.SetDestination(vchPubKey.GetID());

                    // Insert change txn at random position:
-                    vector<CTxOut>::iterator position = wtxNew.vout.begin()+GetRandInt(wtxNew.vout.size());
+                    vector<CTxOut>::iterator position = wtxNew.vout.begin()+GetRandInt(wtxNew.vout.size()+1);
                    wtxNew.vout.insert(position, CTxOut(nChange, scriptChange));
                }
                else