Browse Source

fix compilation error (m_sent_bitfield) without libtorrent debug

miguelfreitas
Miguel Freitas 11 years ago
parent
commit
52a3ecda88
  1. 6
      TODO
  2. 2
      libtorrent/include/libtorrent/bt_peer_connection.hpp
  3. 12
      libtorrent/src/bt_peer_connection.cpp

6
TODO

@ -42,5 +42,11 @@ and can also be sure to receive all mentions.
- Implement hashtag "storage-less" torrents for post distribution. - Implement hashtag "storage-less" torrents for post distribution.
- Define expiration policies to dht stored values. Currently all keys are refreshed every hour which,
according to previous bittorrent research, would be enough to keep data available forever (with high
probability). twister also persists keys to disk. As userbase increases, old post storage and
unreliable multivalued keys should better expire. Since those posts include the height and time, a
policy may me defined.
-

2
libtorrent/include/libtorrent/bt_peer_connection.hpp

@ -434,10 +434,10 @@ private:
boost::scoped_ptr<sha1_hash> m_sync_hash; boost::scoped_ptr<sha1_hash> m_sync_hash;
#endif // #ifndef TORRENT_DISABLE_ENCRYPTION #endif // #ifndef TORRENT_DISABLE_ENCRYPTION
#if defined TORRENT_DEBUG || TORRENT_RELEASE_ASSERTS
// this is set to true when the client's // this is set to true when the client's
// bitfield is sent to this peer // bitfield is sent to this peer
bool m_sent_bitfield; bool m_sent_bitfield;
#if defined TORRENT_DEBUG || TORRENT_RELEASE_ASSERTS
bool m_in_constructor; bool m_in_constructor;

12
libtorrent/src/bt_peer_connection.cpp

@ -118,8 +118,8 @@ namespace libtorrent
, m_rc4_encrypted(false) , m_rc4_encrypted(false)
, m_sync_bytes_read(0) , m_sync_bytes_read(0)
#endif #endif
#if defined TORRENT_DEBUG || TORRENT_RELEASE_ASSERTS
, m_sent_bitfield(false) , m_sent_bitfield(false)
#if defined TORRENT_DEBUG || TORRENT_RELEASE_ASSERTS
, m_in_constructor(true) , m_in_constructor(true)
, m_sent_handshake(false) , m_sent_handshake(false)
#endif #endif
@ -254,9 +254,7 @@ namespace libtorrent
{ {
INVARIANT_CHECK; INVARIANT_CHECK;
TORRENT_ASSERT(m_sent_handshake && !m_sent_bitfield); TORRENT_ASSERT(m_sent_handshake && !m_sent_bitfield);
#if defined TORRENT_DEBUG || TORRENT_RELEASE_ASSERTS
m_sent_bitfield = true; m_sent_bitfield = true;
#endif
#ifdef TORRENT_VERBOSE_LOGGING #ifdef TORRENT_VERBOSE_LOGGING
peer_log("==> HAVE_ALL"); peer_log("==> HAVE_ALL");
#endif #endif
@ -268,9 +266,7 @@ namespace libtorrent
{ {
INVARIANT_CHECK; INVARIANT_CHECK;
TORRENT_ASSERT(m_sent_handshake && !m_sent_bitfield); TORRENT_ASSERT(m_sent_handshake && !m_sent_bitfield);
#if defined TORRENT_DEBUG || TORRENT_RELEASE_ASSERTS
m_sent_bitfield = true; m_sent_bitfield = true;
#endif
#ifdef TORRENT_VERBOSE_LOGGING #ifdef TORRENT_VERBOSE_LOGGING
peer_log("==> HAVE_NONE"); peer_log("==> HAVE_NONE");
#endif #endif
@ -1958,9 +1954,7 @@ namespace libtorrent
// if we are super seeding, pretend to not have any piece // if we are super seeding, pretend to not have any piece
// and don't send a bitfield // and don't send a bitfield
#if defined TORRENT_DEBUG || TORRENT_RELEASE_ASSERTS
m_sent_bitfield = true; m_sent_bitfield = true;
#endif
// bootstrap superseeding by sending two have message // bootstrap superseeding by sending two have message
superseed_piece(-1, t->get_piece_to_super_seed(get_bitfield())); superseed_piece(-1, t->get_piece_to_super_seed(get_bitfield()));
@ -1985,9 +1979,7 @@ namespace libtorrent
#ifdef TORRENT_VERBOSE_LOGGING #ifdef TORRENT_VERBOSE_LOGGING
peer_log(" *** NOT SENDING BITFIELD"); peer_log(" *** NOT SENDING BITFIELD");
#endif #endif
#if defined TORRENT_DEBUG || TORRENT_RELEASE_ASSERTS
m_sent_bitfield = true; m_sent_bitfield = true;
#endif
return; return;
} }
@ -2060,9 +2052,7 @@ namespace libtorrent
} }
peer_log("==> BITFIELD [ %s ]", bitfield_string.c_str()); peer_log("==> BITFIELD [ %s ]", bitfield_string.c_str());
#endif #endif
#if defined TORRENT_DEBUG || TORRENT_RELEASE_ASSERTS
m_sent_bitfield = true; m_sent_bitfield = true;
#endif
send_buffer(msg, packet_size); send_buffer(msg, packet_size);

Loading…
Cancel
Save