Browse Source

Revert change to leak canary version, add todo for bug

master
Anthony Restaino 9 years ago
parent
commit
35855a1c02
  1. 4
      app/build.gradle
  2. 2
      app/src/main/java/acr/browser/lightning/view/LightningView.java

4
app/build.gradle

@ -86,8 +86,8 @@ dependencies {
compile(project(':libnetcipher')) compile(project(':libnetcipher'))
// memory leak analysis // memory leak analysis
debugCompile 'com.squareup.leakcanary:leakcanary-android:1.3.1' debugCompile 'com.squareup.leakcanary:leakcanary-android:1.4-beta1'
releaseCompile 'com.squareup.leakcanary:leakcanary-android-no-op:1.3.1' releaseCompile 'com.squareup.leakcanary:leakcanary-android-no-op:1.4-beta1'
provided 'javax.annotation:jsr250-api:1.0' provided 'javax.annotation:jsr250-api:1.0'

2
app/src/main/java/acr/browser/lightning/view/LightningView.java

@ -762,6 +762,8 @@ public class LightningView {
* the WebView cannot be recreated using the public * the WebView cannot be recreated using the public
* api. * api.
*/ */
// TODO fix bug where WebView.destroy is being called before the tab
// is removed
public synchronized void onDestroy() { public synchronized void onDestroy() {
if (mWebView != null) { if (mWebView != null) {
mWebView.stopLoading(); mWebView.stopLoading();

Loading…
Cancel
Save