From 35855a1c027cfdf92baa4cbe7fb6e9affa60901a Mon Sep 17 00:00:00 2001 From: Anthony Restaino Date: Sat, 16 Jan 2016 22:49:31 -0500 Subject: [PATCH] Revert change to leak canary version, add todo for bug --- app/build.gradle | 4 ++-- .../main/java/acr/browser/lightning/view/LightningView.java | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index abea845..cc94151 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -86,8 +86,8 @@ dependencies { compile(project(':libnetcipher')) // memory leak analysis - debugCompile 'com.squareup.leakcanary:leakcanary-android:1.3.1' - releaseCompile 'com.squareup.leakcanary:leakcanary-android-no-op:1.3.1' + debugCompile 'com.squareup.leakcanary:leakcanary-android:1.4-beta1' + releaseCompile 'com.squareup.leakcanary:leakcanary-android-no-op:1.4-beta1' provided 'javax.annotation:jsr250-api:1.0' diff --git a/app/src/main/java/acr/browser/lightning/view/LightningView.java b/app/src/main/java/acr/browser/lightning/view/LightningView.java index 444c242..0cd29da 100644 --- a/app/src/main/java/acr/browser/lightning/view/LightningView.java +++ b/app/src/main/java/acr/browser/lightning/view/LightningView.java @@ -762,6 +762,8 @@ public class LightningView { * the WebView cannot be recreated using the public * api. */ + // TODO fix bug where WebView.destroy is being called before the tab + // is removed public synchronized void onDestroy() { if (mWebView != null) { mWebView.stopLoading();