Browse Source

Danger: remove "add screenshots" warning (#691)

We have screenshot tests that basically negate the need for this,
and when we're doing more complicated things we tend to use
videos anyway which aren't caught by this check.
feature/julioromano/geocoding_api
Chris Smith 1 year ago committed by GitHub
parent
commit
ca1df5829f
  1. 8
      tools/danger/dangerfile.js

8
tools/danger/dangerfile.js

@ -155,14 +155,6 @@ if (buildFilesWithMissingProcessor.length > 0) { @@ -155,14 +155,6 @@ if (buildFilesWithMissingProcessor.length > 0) {
warn("You have made changes to a file containing a `@Preview` annotated function but its module doesn't include the showkase processor. Missing processor in: " + buildFilesWithMissingProcessor.join(", "))
}
// Check for screenshots on view changes
const hasChangedViews = filesWithPreviews.length > 0
if (hasChangedViews) {
if (!pr.body.includes("user-images")) {
warn("You seem to have made changes to views. Please consider adding screenshots.")
}
}
// Check for pngs on resources
const hasPngs = editedFiles.filter(file => {
file.toLowerCase().endsWith(".png") && !file.includes("snapshots/images/") // Exclude screenshots

Loading…
Cancel
Save