From ca1df5829fc0c0084ffb04147a0a3eedcde83cc0 Mon Sep 17 00:00:00 2001 From: Chris Smith Date: Tue, 27 Jun 2023 14:37:44 +0100 Subject: [PATCH] Danger: remove "add screenshots" warning (#691) We have screenshot tests that basically negate the need for this, and when we're doing more complicated things we tend to use videos anyway which aren't caught by this check. --- tools/danger/dangerfile.js | 8 -------- 1 file changed, 8 deletions(-) diff --git a/tools/danger/dangerfile.js b/tools/danger/dangerfile.js index 263c394e25..16fbf4d31b 100644 --- a/tools/danger/dangerfile.js +++ b/tools/danger/dangerfile.js @@ -155,14 +155,6 @@ if (buildFilesWithMissingProcessor.length > 0) { warn("You have made changes to a file containing a `@Preview` annotated function but its module doesn't include the showkase processor. Missing processor in: " + buildFilesWithMissingProcessor.join(", ")) } -// Check for screenshots on view changes -const hasChangedViews = filesWithPreviews.length > 0 -if (hasChangedViews) { - if (!pr.body.includes("user-images")) { - warn("You seem to have made changes to views. Please consider adding screenshots.") - } -} - // Check for pngs on resources const hasPngs = editedFiles.filter(file => { file.toLowerCase().endsWith(".png") && !file.includes("snapshots/images/") // Exclude screenshots