Browse Source

Remove default onClick from MatrixUserRow

test/jme/compound-poc
Florian Renaud 2 years ago
parent
commit
ac8a6f90fd
  1. 4
      features/selectusers/api/src/main/kotlin/io/element/android/features/selectusers/api/SelectUsersView.kt
  2. 5
      libraries/matrixui/src/main/kotlin/io/element/android/libraries/matrix/ui/components/CheckableMatrixUserRow.kt
  3. 3
      libraries/matrixui/src/main/kotlin/io/element/android/libraries/matrix/ui/components/MatrixUserRow.kt

4
features/selectusers/api/src/main/kotlin/io/element/android/features/selectusers/api/SelectUsersView.kt

@ -17,6 +17,7 @@
package io.element.android.features.selectusers.api package io.element.android.features.selectusers.api
import androidx.compose.foundation.background import androidx.compose.foundation.background
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Column
@ -232,10 +233,9 @@ fun SearchSingleUserResultItem(
onClick: () -> Unit = {}, onClick: () -> Unit = {},
) { ) {
MatrixUserRow( MatrixUserRow(
modifier = modifier, modifier = modifier.clickable(onClick = onClick),
matrixUser = matrixUser, matrixUser = matrixUser,
avatarSize = AvatarSize.Custom(36.dp), avatarSize = AvatarSize.Custom(36.dp),
onClick = onClick,
) )
} }

5
libraries/matrixui/src/main/kotlin/io/element/android/libraries/matrix/ui/components/CheckableMatrixUserRow.kt

@ -23,6 +23,7 @@ import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.semantics.Role
import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.tooling.preview.PreviewParameter import androidx.compose.ui.tooling.preview.PreviewParameter
import io.element.android.libraries.designsystem.components.avatar.AvatarSize import io.element.android.libraries.designsystem.components.avatar.AvatarSize
@ -44,9 +45,7 @@ fun CheckableMatrixUserRow(
Row( Row(
modifier = modifier modifier = modifier
.fillMaxWidth() .fillMaxWidth()
.clickable { .clickable(role = Role.Checkbox) { onCheckedChange(!checked) },
onCheckedChange(!checked)
},
verticalAlignment = Alignment.CenterVertically, verticalAlignment = Alignment.CenterVertically,
) { ) {
MatrixUserRow( MatrixUserRow(

3
libraries/matrixui/src/main/kotlin/io/element/android/libraries/matrix/ui/components/MatrixUserRow.kt

@ -16,7 +16,6 @@
package io.element.android.libraries.matrix.ui.components package io.element.android.libraries.matrix.ui.components
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.IntrinsicSize import androidx.compose.foundation.layout.IntrinsicSize
import androidx.compose.foundation.layout.Row import androidx.compose.foundation.layout.Row
@ -46,11 +45,9 @@ fun MatrixUserRow(
matrixUser: MatrixUser, matrixUser: MatrixUser,
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
avatarSize: AvatarSize = matrixUser.avatarData.size, avatarSize: AvatarSize = matrixUser.avatarData.size,
onClick: (() -> Unit)? = null,
) { ) {
Row( Row(
modifier = modifier modifier = modifier
.let { if (onClick != null) it.clickable(onClick = onClick) else it }
.fillMaxWidth() .fillMaxWidth()
.padding(start = 16.dp, top = 8.dp, end = 16.dp, bottom = 8.dp) .padding(start = 16.dp, top = 8.dp, end = 16.dp, bottom = 8.dp)
.height(IntrinsicSize.Min), .height(IntrinsicSize.Min),

Loading…
Cancel
Save