Browse Source

Test | Fix missing updateSuperProperties impl

pull/2953/head
Valere 4 months ago
parent
commit
920293ea83
  1. 2
      services/analytics/noop/src/main/kotlin/io/element/android/services/analytics/noop/NoopAnalyticsService.kt
  2. 5
      services/analytics/test/src/main/kotlin/io/element/android/services/analytics/test/FakeAnalyticsService.kt

2
services/analytics/noop/src/main/kotlin/io/element/android/services/analytics/noop/NoopAnalyticsService.kt

@ -19,6 +19,7 @@ package io.element.android.services.analytics.noop @@ -19,6 +19,7 @@ package io.element.android.services.analytics.noop
import com.squareup.anvil.annotations.ContributesBinding
import im.vector.app.features.analytics.itf.VectorAnalyticsEvent
import im.vector.app.features.analytics.itf.VectorAnalyticsScreen
import im.vector.app.features.analytics.plan.SuperProperties
import im.vector.app.features.analytics.plan.UserProperties
import io.element.android.libraries.di.AppScope
import io.element.android.libraries.di.SingleIn
@ -43,4 +44,5 @@ class NoopAnalyticsService @Inject constructor() : AnalyticsService { @@ -43,4 +44,5 @@ class NoopAnalyticsService @Inject constructor() : AnalyticsService {
override fun screen(screen: VectorAnalyticsScreen) = Unit
override fun updateUserProperties(userProperties: UserProperties) = Unit
override fun trackError(throwable: Throwable) = Unit
override fun updateSuperProperties(updatedProperties: SuperProperties) = Unit
}

5
services/analytics/test/src/main/kotlin/io/element/android/services/analytics/test/FakeAnalyticsService.kt

@ -18,6 +18,7 @@ package io.element.android.services.analytics.test @@ -18,6 +18,7 @@ package io.element.android.services.analytics.test
import im.vector.app.features.analytics.itf.VectorAnalyticsEvent
import im.vector.app.features.analytics.itf.VectorAnalyticsScreen
import im.vector.app.features.analytics.plan.SuperProperties
import im.vector.app.features.analytics.plan.UserProperties
import io.element.android.services.analytics.api.AnalyticsService
import io.element.android.services.analyticsproviders.api.AnalyticsProvider
@ -70,6 +71,10 @@ class FakeAnalyticsService( @@ -70,6 +71,10 @@ class FakeAnalyticsService(
trackedErrors += throwable
}
override fun updateSuperProperties(updatedProperties: SuperProperties) {
// No op
}
override suspend fun reset() {
didAskUserConsentFlow.value = false
}

Loading…
Cancel
Save