Browse Source

Danger: don't complain about reviewers (#509)

Now we have a CODEOWNERS file a reviewer is assigned automatically,
so there's no need for this.

It also misfires a bunch (maybe if there are no _pending_ reviewers
because they've already reviewed?), so removing it fixes that noise.
feature/fga/small_timeline_improvements
Chris Smith 1 year ago committed by GitHub
parent
commit
5de90c3871
  1. 5
      tools/danger/dangerfile.js

5
tools/danger/dangerfile.js

@ -171,11 +171,6 @@ if (hasPngs) { @@ -171,11 +171,6 @@ if (hasPngs) {
warn("You seem to have made changes to some images. Please consider using an vector drawable.")
}
// Check for reviewers
if (github.requested_reviewers.users.length == 0 && !pr.draft) {
warn("Please add a reviewer to your PR.")
}
// Check that translations have not been modified by developers
const translationAllowList = [
"RiotTranslateBot",

Loading…
Cancel
Save