Browse Source

Bug reporter crashes when 'send logs' is disabled. (#1184)

* Bug reporter crashes when 'send logs' is disabled.

* Make sure generated files are cleaned up when uploading the logs fails.
pull/1186/head
Jorge Martin Espinosa 1 year ago committed by GitHub
parent
commit
4a88e3fab6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 1
      changelog.d/1168.bugfix
  2. 9
      features/rageshake/impl/src/main/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporter.kt

1
changelog.d/1168.bugfix

@ -0,0 +1 @@
Bug reporter crashes when 'send logs' is disabled.

9
features/rageshake/impl/src/main/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporter.kt

@ -268,12 +268,13 @@ class DefaultBugReporter @Inject constructor(
} }
} }
if (!uploadedSomeLogs) {
error("Couldn't upload any logs")
}
mBugReportFiles.addAll(gzippedFiles) mBugReportFiles.addAll(gzippedFiles)
if (gzippedFiles.isNotEmpty() && !uploadedSomeLogs) {
serverError = "Couldn't upload any logs, please retry."
return@withContext
}
if (withScreenshot) { if (withScreenshot) {
screenshotHolder.getFileUri() screenshotHolder.getFileUri()
?.toUri() ?.toUri()

Loading…
Cancel
Save