Browse Source

Rename some class from `Impl` to Default

pull/2957/head
Benoit Marty 4 months ago
parent
commit
45598a885e
  1. 2
      app/src/main/kotlin/io/element/android/x/intent/DefaultIntentProvider.kt
  2. 12
      app/src/test/kotlin/io/element/android/x/intent/DefaultIntentProviderTest.kt
  3. 2
      features/leaveroom/impl/src/main/kotlin/io/element/android/features/leaveroom/impl/DefaultLeaveRoomPresenter.kt
  4. 2
      features/leaveroom/impl/src/main/kotlin/io/element/android/features/leaveroom/impl/LeaveRoomPresenterImplModule.kt
  5. 25
      features/leaveroom/impl/src/test/kotlin/io/element/android/features/leaveroom/impl/DefaultLeaveRoomPresenterTest.kt
  6. 5
      features/location/impl/src/main/kotlin/io/element/android/features/location/impl/common/permissions/DefaultPermissionsPresenter.kt
  7. 2
      features/location/impl/src/main/kotlin/io/element/android/features/location/impl/send/DefaultSendLocationEntryPoint.kt
  8. 2
      features/location/impl/src/main/kotlin/io/element/android/features/location/impl/show/DefaultShowLocationEntryPoint.kt
  9. 4
      features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListView.kt
  10. 2
      features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/DefaultMessageComposerContext.kt
  11. 2
      features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerPresenter.kt
  12. 2
      features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/utils/messagesummary/DefaultMessageSummaryFormatter.kt
  13. 4
      features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt
  14. 4
      features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/textcomposer/MessageComposerPresenterTest.kt
  15. 2
      features/networkmonitor/impl/src/main/kotlin/io/element/android/features/networkmonitor/impl/DefaultNetworkMonitor.kt
  16. 2
      libraries/mediapickers/impl/src/main/kotlin/io/element/android/libraries/mediapickers/impl/DefaultPickerProvider.kt
  17. 2
      libraries/mediaplayer/impl/src/main/kotlin/io/element/android/libraries/mediaplayer/impl/DefaultMediaPlayer.kt
  18. 4
      libraries/mediaplayer/impl/src/main/kotlin/io/element/android/libraries/mediaplayer/impl/SimplePlayer.kt
  19. 2
      libraries/mediaplayer/impl/src/test/kotlin/io/element/android/libraries/mediaplayer/impl/DefaultMediaPlayerTest.kt
  20. 2
      libraries/pushstore/impl/src/main/kotlin/io/element/android/libraries/pushstore/impl/clientsecret/DefaultPushClientSecret.kt
  21. 2
      libraries/pushstore/impl/src/main/kotlin/io/element/android/libraries/pushstore/impl/clientsecret/DefaultPushClientSecretFactory.kt
  22. 4
      libraries/pushstore/impl/src/test/kotlin/io/element/android/libraries/pushstore/impl/clientsecret/DefaultPushClientSecretTest.kt
  23. 2
      libraries/voicerecorder/impl/src/main/kotlin/io/element/android/libraries/voicerecorder/impl/DefaultVoiceRecorder.kt
  24. 16
      libraries/voicerecorder/impl/src/test/kotlin/io/element/android/libraries/voicerecorder/impl/DefaultVoiceRecorderTest.kt
  25. 8
      samples/minimal/src/main/kotlin/io/element/android/samples/minimal/RoomListScreen.kt
  26. 1
      tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistClassNameTest.kt

2
app/src/main/kotlin/io/element/android/x/intent/IntentProviderImpl.kt → app/src/main/kotlin/io/element/android/x/intent/DefaultIntentProvider.kt

@ -31,7 +31,7 @@ import io.element.android.x.MainActivity
import javax.inject.Inject import javax.inject.Inject
@ContributesBinding(AppScope::class) @ContributesBinding(AppScope::class)
class IntentProviderImpl @Inject constructor( class DefaultIntentProvider @Inject constructor(
@ApplicationContext private val context: Context, @ApplicationContext private val context: Context,
private val deepLinkCreator: DeepLinkCreator, private val deepLinkCreator: DeepLinkCreator,
) : IntentProvider { ) : IntentProvider {

12
app/src/test/kotlin/io/element/android/x/intent/IntentProviderImplTest.kt → app/src/test/kotlin/io/element/android/x/intent/DefaultIntentProviderTest.kt

@ -30,10 +30,10 @@ import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment import org.robolectric.RuntimeEnvironment
@RunWith(RobolectricTestRunner::class) @RunWith(RobolectricTestRunner::class)
class IntentProviderImplTest { class DefaultIntentProviderTest {
@Test @Test
fun `test getViewRoomIntent with Session`() { fun `test getViewRoomIntent with Session`() {
val sut = createIntentProviderImpl() val sut = createDefaultIntentProvider()
val result = sut.getViewRoomIntent( val result = sut.getViewRoomIntent(
sessionId = A_SESSION_ID, sessionId = A_SESSION_ID,
roomId = null, roomId = null,
@ -45,7 +45,7 @@ class IntentProviderImplTest {
@Test @Test
fun `test getViewRoomIntent with Session and Room`() { fun `test getViewRoomIntent with Session and Room`() {
val sut = createIntentProviderImpl() val sut = createDefaultIntentProvider()
val result = sut.getViewRoomIntent( val result = sut.getViewRoomIntent(
sessionId = A_SESSION_ID, sessionId = A_SESSION_ID,
roomId = A_ROOM_ID, roomId = A_ROOM_ID,
@ -57,7 +57,7 @@ class IntentProviderImplTest {
@Test @Test
fun `test getViewRoomIntent with Session, Room and Thread`() { fun `test getViewRoomIntent with Session, Room and Thread`() {
val sut = createIntentProviderImpl() val sut = createDefaultIntentProvider()
val result = sut.getViewRoomIntent( val result = sut.getViewRoomIntent(
sessionId = A_SESSION_ID, sessionId = A_SESSION_ID,
roomId = A_ROOM_ID, roomId = A_ROOM_ID,
@ -67,8 +67,8 @@ class IntentProviderImplTest {
assertThat(result.data.toString()).isEqualTo("elementx://open/@alice:server.org/!aRoomId:domain/\$aThreadId") assertThat(result.data.toString()).isEqualTo("elementx://open/@alice:server.org/!aRoomId:domain/\$aThreadId")
} }
private fun createIntentProviderImpl(): IntentProviderImpl { private fun createDefaultIntentProvider(): DefaultIntentProvider {
return IntentProviderImpl( return DefaultIntentProvider(
context = RuntimeEnvironment.getApplication() as Context, context = RuntimeEnvironment.getApplication() as Context,
deepLinkCreator = DeepLinkCreator(), deepLinkCreator = DeepLinkCreator(),
) )

2
features/leaveroom/impl/src/main/kotlin/io/element/android/features/leaveroom/impl/LeaveRoomPresenterImpl.kt → features/leaveroom/impl/src/main/kotlin/io/element/android/features/leaveroom/impl/DefaultLeaveRoomPresenter.kt

@ -36,7 +36,7 @@ import kotlinx.coroutines.launch
import timber.log.Timber import timber.log.Timber
import javax.inject.Inject import javax.inject.Inject
class LeaveRoomPresenterImpl @Inject constructor( class DefaultLeaveRoomPresenter @Inject constructor(
private val client: MatrixClient, private val client: MatrixClient,
private val roomMembershipObserver: RoomMembershipObserver, private val roomMembershipObserver: RoomMembershipObserver,
private val dispatchers: CoroutineDispatchers, private val dispatchers: CoroutineDispatchers,

2
features/leaveroom/impl/src/main/kotlin/io/element/android/features/leaveroom/impl/LeaveRoomPresenterImplModule.kt

@ -26,5 +26,5 @@ import io.element.android.libraries.di.SessionScope
@ContributesTo(SessionScope::class) @ContributesTo(SessionScope::class)
interface LeaveRoomPresenterImplModule { interface LeaveRoomPresenterImplModule {
@Binds @Binds
fun leaveRoomPresenter(leaveRoomPresenter: LeaveRoomPresenterImpl): LeaveRoomPresenter fun leaveRoomPresenter(leaveRoomPresenter: DefaultLeaveRoomPresenter): LeaveRoomPresenter
} }

25
features/leaveroom/impl/src/test/kotlin/io/element/android/features/leaveroom/impl/LeaveRoomPresenterImplTest.kt → features/leaveroom/impl/src/test/kotlin/io/element/android/features/leaveroom/impl/DefaultLeaveRoomPresenterTest.kt

@ -21,7 +21,6 @@ import app.cash.molecule.moleculeFlow
import app.cash.turbine.test import app.cash.turbine.test
import com.google.common.truth.Truth.assertThat import com.google.common.truth.Truth.assertThat
import io.element.android.features.leaveroom.api.LeaveRoomEvent import io.element.android.features.leaveroom.api.LeaveRoomEvent
import io.element.android.features.leaveroom.api.LeaveRoomPresenter
import io.element.android.features.leaveroom.api.LeaveRoomState import io.element.android.features.leaveroom.api.LeaveRoomState
import io.element.android.libraries.matrix.api.MatrixClient import io.element.android.libraries.matrix.api.MatrixClient
import io.element.android.libraries.matrix.api.room.RoomMembershipObserver import io.element.android.libraries.matrix.api.room.RoomMembershipObserver
@ -37,13 +36,13 @@ import kotlinx.coroutines.test.runTest
import org.junit.Rule import org.junit.Rule
import org.junit.Test import org.junit.Test
class LeaveRoomPresenterImplTest { class DefaultLeaveRoomPresenterTest {
@get:Rule @get:Rule
val warmUpRule = WarmUpRule() val warmUpRule = WarmUpRule()
@Test @Test
fun `present - initial state hides all dialogs`() = runTest { fun `present - initial state hides all dialogs`() = runTest {
val presenter = createLeaveRoomPresenter() val presenter = createDefaultLeaveRoomPresenter()
moleculeFlow(RecompositionMode.Immediate) { moleculeFlow(RecompositionMode.Immediate) {
presenter.present() presenter.present()
}.test { }.test {
@ -56,7 +55,7 @@ class LeaveRoomPresenterImplTest {
@Test @Test
fun `present - show generic confirmation`() = runTest { fun `present - show generic confirmation`() = runTest {
val presenter = createLeaveRoomPresenter( val presenter = createDefaultLeaveRoomPresenter(
client = FakeMatrixClient().apply { client = FakeMatrixClient().apply {
givenGetRoomResult( givenGetRoomResult(
roomId = A_ROOM_ID, roomId = A_ROOM_ID,
@ -76,7 +75,7 @@ class LeaveRoomPresenterImplTest {
@Test @Test
fun `present - show private room confirmation`() = runTest { fun `present - show private room confirmation`() = runTest {
val presenter = createLeaveRoomPresenter( val presenter = createDefaultLeaveRoomPresenter(
client = FakeMatrixClient().apply { client = FakeMatrixClient().apply {
givenGetRoomResult( givenGetRoomResult(
roomId = A_ROOM_ID, roomId = A_ROOM_ID,
@ -96,7 +95,7 @@ class LeaveRoomPresenterImplTest {
@Test @Test
fun `present - show last user in room confirmation`() = runTest { fun `present - show last user in room confirmation`() = runTest {
val presenter = createLeaveRoomPresenter( val presenter = createDefaultLeaveRoomPresenter(
client = FakeMatrixClient().apply { client = FakeMatrixClient().apply {
givenGetRoomResult( givenGetRoomResult(
roomId = A_ROOM_ID, roomId = A_ROOM_ID,
@ -116,7 +115,7 @@ class LeaveRoomPresenterImplTest {
@Test @Test
fun `present - show DM confirmation`() = runTest { fun `present - show DM confirmation`() = runTest {
val presenter = createLeaveRoomPresenter( val presenter = createDefaultLeaveRoomPresenter(
client = FakeMatrixClient().apply { client = FakeMatrixClient().apply {
givenGetRoomResult( givenGetRoomResult(
roomId = A_ROOM_ID, roomId = A_ROOM_ID,
@ -137,7 +136,7 @@ class LeaveRoomPresenterImplTest {
@Test @Test
fun `present - leaving a room leaves the room`() = runTest { fun `present - leaving a room leaves the room`() = runTest {
val roomMembershipObserver = RoomMembershipObserver() val roomMembershipObserver = RoomMembershipObserver()
val presenter = createLeaveRoomPresenter( val presenter = createDefaultLeaveRoomPresenter(
client = FakeMatrixClient().apply { client = FakeMatrixClient().apply {
givenGetRoomResult( givenGetRoomResult(
roomId = A_ROOM_ID, roomId = A_ROOM_ID,
@ -159,7 +158,7 @@ class LeaveRoomPresenterImplTest {
@Test @Test
fun `present - show error if leave room fails`() = runTest { fun `present - show error if leave room fails`() = runTest {
val presenter = createLeaveRoomPresenter( val presenter = createDefaultLeaveRoomPresenter(
client = FakeMatrixClient().apply { client = FakeMatrixClient().apply {
givenGetRoomResult( givenGetRoomResult(
roomId = A_ROOM_ID, roomId = A_ROOM_ID,
@ -183,7 +182,7 @@ class LeaveRoomPresenterImplTest {
@Test @Test
fun `present - show progress indicator while leaving a room`() = runTest { fun `present - show progress indicator while leaving a room`() = runTest {
val presenter = createLeaveRoomPresenter( val presenter = createDefaultLeaveRoomPresenter(
client = FakeMatrixClient().apply { client = FakeMatrixClient().apply {
givenGetRoomResult( givenGetRoomResult(
roomId = A_ROOM_ID, roomId = A_ROOM_ID,
@ -205,7 +204,7 @@ class LeaveRoomPresenterImplTest {
@Test @Test
fun `present - hide error hides the error`() = runTest { fun `present - hide error hides the error`() = runTest {
val presenter = createLeaveRoomPresenter( val presenter = createDefaultLeaveRoomPresenter(
client = FakeMatrixClient().apply { client = FakeMatrixClient().apply {
givenGetRoomResult( givenGetRoomResult(
roomId = A_ROOM_ID, roomId = A_ROOM_ID,
@ -231,10 +230,10 @@ class LeaveRoomPresenterImplTest {
} }
} }
private fun TestScope.createLeaveRoomPresenter( private fun TestScope.createDefaultLeaveRoomPresenter(
client: MatrixClient = FakeMatrixClient(), client: MatrixClient = FakeMatrixClient(),
roomMembershipObserver: RoomMembershipObserver = RoomMembershipObserver(), roomMembershipObserver: RoomMembershipObserver = RoomMembershipObserver(),
): LeaveRoomPresenter = LeaveRoomPresenterImpl( ): DefaultLeaveRoomPresenter = DefaultLeaveRoomPresenter(
client = client, client = client,
roomMembershipObserver = roomMembershipObserver, roomMembershipObserver = roomMembershipObserver,
dispatchers = testCoroutineDispatchers(false), dispatchers = testCoroutineDispatchers(false),

5
features/location/impl/src/main/kotlin/io/element/android/features/location/impl/common/permissions/PermissionsPresenterImpl.kt → features/location/impl/src/main/kotlin/io/element/android/features/location/impl/common/permissions/DefaultPermissionsPresenter.kt

@ -26,13 +26,14 @@ import dagger.assisted.AssistedFactory
import dagger.assisted.AssistedInject import dagger.assisted.AssistedInject
import io.element.android.libraries.di.AppScope import io.element.android.libraries.di.AppScope
class PermissionsPresenterImpl @AssistedInject constructor( @Suppress("unused")
class DefaultPermissionsPresenter @AssistedInject constructor(
@Assisted private val permissions: List<String> @Assisted private val permissions: List<String>
) : PermissionsPresenter { ) : PermissionsPresenter {
@AssistedFactory @AssistedFactory
@ContributesBinding(AppScope::class) @ContributesBinding(AppScope::class)
interface Factory : PermissionsPresenter.Factory { interface Factory : PermissionsPresenter.Factory {
override fun create(permissions: List<String>): PermissionsPresenterImpl override fun create(permissions: List<String>): DefaultPermissionsPresenter
} }
@OptIn(ExperimentalPermissionsApi::class) @OptIn(ExperimentalPermissionsApi::class)

2
features/location/impl/src/main/kotlin/io/element/android/features/location/impl/send/SendLocationEntryPointImpl.kt → features/location/impl/src/main/kotlin/io/element/android/features/location/impl/send/DefaultSendLocationEntryPoint.kt

@ -25,7 +25,7 @@ import io.element.android.libraries.di.AppScope
import javax.inject.Inject import javax.inject.Inject
@ContributesBinding(AppScope::class) @ContributesBinding(AppScope::class)
class SendLocationEntryPointImpl @Inject constructor() : SendLocationEntryPoint { class DefaultSendLocationEntryPoint @Inject constructor() : SendLocationEntryPoint {
override fun createNode( override fun createNode(
parentNode: Node, parentNode: Node,
buildContext: BuildContext buildContext: BuildContext

2
features/location/impl/src/main/kotlin/io/element/android/features/location/impl/show/ShowLocationEntryPointImpl.kt → features/location/impl/src/main/kotlin/io/element/android/features/location/impl/show/DefaultShowLocationEntryPoint.kt

@ -25,7 +25,7 @@ import io.element.android.libraries.di.AppScope
import javax.inject.Inject import javax.inject.Inject
@ContributesBinding(AppScope::class) @ContributesBinding(AppScope::class)
class ShowLocationEntryPointImpl @Inject constructor() : ShowLocationEntryPoint { class DefaultShowLocationEntryPoint @Inject constructor() : ShowLocationEntryPoint {
override fun createNode(parentNode: Node, buildContext: BuildContext, inputs: ShowLocationEntryPoint.Inputs): Node { override fun createNode(parentNode: Node, buildContext: BuildContext, inputs: ShowLocationEntryPoint.Inputs): Node {
return parentNode.createNode<ShowLocationNode>(buildContext, listOf(inputs)) return parentNode.createNode<ShowLocationNode>(buildContext, listOf(inputs))
} }

4
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListView.kt

@ -72,7 +72,7 @@ import io.element.android.features.messages.impl.timeline.model.event.TimelineIt
import io.element.android.features.messages.impl.timeline.model.event.TimelineItemUnknownContent import io.element.android.features.messages.impl.timeline.model.event.TimelineItemUnknownContent
import io.element.android.features.messages.impl.timeline.model.event.TimelineItemVideoContent import io.element.android.features.messages.impl.timeline.model.event.TimelineItemVideoContent
import io.element.android.features.messages.impl.timeline.model.event.TimelineItemVoiceContent import io.element.android.features.messages.impl.timeline.model.event.TimelineItemVoiceContent
import io.element.android.features.messages.impl.utils.messagesummary.MessageSummaryFormatterImpl import io.element.android.features.messages.impl.utils.messagesummary.DefaultMessageSummaryFormatter
import io.element.android.libraries.designsystem.components.avatar.Avatar import io.element.android.libraries.designsystem.components.avatar.Avatar
import io.element.android.libraries.designsystem.components.avatar.AvatarSize import io.element.android.libraries.designsystem.components.avatar.AvatarSize
import io.element.android.libraries.designsystem.components.list.ListItemContent import io.element.android.libraries.designsystem.components.list.ListItemContent
@ -229,7 +229,7 @@ private fun MessageSummary(event: TimelineItem.Event, modifier: Modifier = Modif
} }
val context = LocalContext.current val context = LocalContext.current
val formatter = remember(context) { MessageSummaryFormatterImpl(context) } val formatter = remember(context) { DefaultMessageSummaryFormatter(context) }
val textContent = remember(event.content) { formatter.format(event) } val textContent = remember(event.content) { formatter.format(event) }
when (event.content) { when (event.content) {

2
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerContextImpl.kt → features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/DefaultMessageComposerContext.kt

@ -28,7 +28,7 @@ import javax.inject.Inject
@SingleIn(RoomScope::class) @SingleIn(RoomScope::class)
@ContributesBinding(RoomScope::class) @ContributesBinding(RoomScope::class)
class MessageComposerContextImpl @Inject constructor() : MessageComposerContext { class DefaultMessageComposerContext @Inject constructor() : MessageComposerContext {
override var composerMode: MessageComposerMode by mutableStateOf(MessageComposerMode.Normal) override var composerMode: MessageComposerMode by mutableStateOf(MessageComposerMode.Normal)
internal set internal set
} }

2
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerPresenter.kt

@ -100,7 +100,7 @@ class MessageComposerPresenter @Inject constructor(
private val mediaSender: MediaSender, private val mediaSender: MediaSender,
private val snackbarDispatcher: SnackbarDispatcher, private val snackbarDispatcher: SnackbarDispatcher,
private val analyticsService: AnalyticsService, private val analyticsService: AnalyticsService,
private val messageComposerContext: MessageComposerContextImpl, private val messageComposerContext: DefaultMessageComposerContext,
private val richTextEditorStateFactory: RichTextEditorStateFactory, private val richTextEditorStateFactory: RichTextEditorStateFactory,
private val currentSessionIdHolder: CurrentSessionIdHolder, private val currentSessionIdHolder: CurrentSessionIdHolder,
private val permalinkParser: PermalinkParser, private val permalinkParser: PermalinkParser,

2
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/utils/messagesummary/MessageSummaryFormatterImpl.kt → features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/utils/messagesummary/DefaultMessageSummaryFormatter.kt

@ -40,7 +40,7 @@ import io.element.android.libraries.ui.strings.CommonStrings
import javax.inject.Inject import javax.inject.Inject
@ContributesBinding(RoomScope::class) @ContributesBinding(RoomScope::class)
class MessageSummaryFormatterImpl @Inject constructor( class DefaultMessageSummaryFormatter @Inject constructor(
@ApplicationContext private val context: Context, @ApplicationContext private val context: Context,
) : MessageSummaryFormatter { ) : MessageSummaryFormatter {
companion object { companion object {

4
features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt

@ -27,7 +27,7 @@ import io.element.android.features.messages.impl.actionlist.ActionListState
import io.element.android.features.messages.impl.actionlist.model.TimelineItemAction import io.element.android.features.messages.impl.actionlist.model.TimelineItemAction
import io.element.android.features.messages.impl.fixtures.aMessageEvent import io.element.android.features.messages.impl.fixtures.aMessageEvent
import io.element.android.features.messages.impl.fixtures.aTimelineItemsFactory import io.element.android.features.messages.impl.fixtures.aTimelineItemsFactory
import io.element.android.features.messages.impl.messagecomposer.MessageComposerContextImpl import io.element.android.features.messages.impl.messagecomposer.DefaultMessageComposerContext
import io.element.android.features.messages.impl.messagecomposer.MessageComposerPresenter import io.element.android.features.messages.impl.messagecomposer.MessageComposerPresenter
import io.element.android.features.messages.impl.messagesummary.FakeMessageSummaryFormatter import io.element.android.features.messages.impl.messagesummary.FakeMessageSummaryFormatter
import io.element.android.features.messages.impl.textcomposer.TestRichTextEditorStateFactory import io.element.android.features.messages.impl.textcomposer.TestRichTextEditorStateFactory
@ -793,7 +793,7 @@ class MessagesPresenterTest {
mediaSender = mediaSender, mediaSender = mediaSender,
snackbarDispatcher = SnackbarDispatcher(), snackbarDispatcher = SnackbarDispatcher(),
analyticsService = analyticsService, analyticsService = analyticsService,
messageComposerContext = MessageComposerContextImpl(), messageComposerContext = DefaultMessageComposerContext(),
richTextEditorStateFactory = TestRichTextEditorStateFactory(), richTextEditorStateFactory = TestRichTextEditorStateFactory(),
permissionsPresenterFactory = permissionsPresenterFactory, permissionsPresenterFactory = permissionsPresenterFactory,
currentSessionIdHolder = CurrentSessionIdHolder(FakeMatrixClient(A_SESSION_ID)), currentSessionIdHolder = CurrentSessionIdHolder(FakeMatrixClient(A_SESSION_ID)),

4
features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/textcomposer/MessageComposerPresenterTest.kt

@ -27,7 +27,7 @@ import app.cash.turbine.test
import com.google.common.truth.Truth.assertThat import com.google.common.truth.Truth.assertThat
import im.vector.app.features.analytics.plan.Composer import im.vector.app.features.analytics.plan.Composer
import io.element.android.features.messages.impl.messagecomposer.AttachmentsState import io.element.android.features.messages.impl.messagecomposer.AttachmentsState
import io.element.android.features.messages.impl.messagecomposer.MessageComposerContextImpl import io.element.android.features.messages.impl.messagecomposer.DefaultMessageComposerContext
import io.element.android.features.messages.impl.messagecomposer.MessageComposerEvents import io.element.android.features.messages.impl.messagecomposer.MessageComposerEvents
import io.element.android.features.messages.impl.messagecomposer.MessageComposerPresenter import io.element.android.features.messages.impl.messagecomposer.MessageComposerPresenter
import io.element.android.features.messages.impl.messagecomposer.MessageComposerState import io.element.android.features.messages.impl.messagecomposer.MessageComposerState
@ -1049,7 +1049,7 @@ class MessageComposerPresenterTest {
MediaSender(mediaPreProcessor, room), MediaSender(mediaPreProcessor, room),
snackbarDispatcher, snackbarDispatcher,
analyticsService, analyticsService,
MessageComposerContextImpl(), DefaultMessageComposerContext(),
TestRichTextEditorStateFactory(), TestRichTextEditorStateFactory(),
currentSessionIdHolder = CurrentSessionIdHolder(FakeMatrixClient(A_SESSION_ID)), currentSessionIdHolder = CurrentSessionIdHolder(FakeMatrixClient(A_SESSION_ID)),
permissionsPresenterFactory = FakePermissionsPresenterFactory(permissionPresenter), permissionsPresenterFactory = FakePermissionsPresenterFactory(permissionPresenter),

2
features/networkmonitor/impl/src/main/kotlin/io/element/android/features/networkmonitor/impl/NetworkMonitorImpl.kt → features/networkmonitor/impl/src/main/kotlin/io/element/android/features/networkmonitor/impl/DefaultNetworkMonitor.kt

@ -46,7 +46,7 @@ import javax.inject.Inject
@ContributesBinding(scope = AppScope::class) @ContributesBinding(scope = AppScope::class)
@SingleIn(AppScope::class) @SingleIn(AppScope::class)
class NetworkMonitorImpl @Inject constructor( class DefaultNetworkMonitor @Inject constructor(
@ApplicationContext context: Context, @ApplicationContext context: Context,
appCoroutineScope: CoroutineScope, appCoroutineScope: CoroutineScope,
) : NetworkMonitor { ) : NetworkMonitor {

2
libraries/mediapickers/impl/src/main/kotlin/io/element/android/libraries/mediapickers/impl/PickerProviderImpl.kt → libraries/mediapickers/impl/src/main/kotlin/io/element/android/libraries/mediapickers/impl/DefaultPickerProvider.kt

@ -37,7 +37,7 @@ import java.util.UUID
import javax.inject.Inject import javax.inject.Inject
@ContributesBinding(AppScope::class) @ContributesBinding(AppScope::class)
class PickerProviderImpl(private val isInTest: Boolean) : PickerProvider { class DefaultPickerProvider(private val isInTest: Boolean) : PickerProvider {
@Inject @Inject
constructor() : this(false) constructor() : this(false)

2
libraries/mediaplayer/impl/src/main/kotlin/io/element/android/libraries/mediaplayer/impl/MediaPlayerImpl.kt → libraries/mediaplayer/impl/src/main/kotlin/io/element/android/libraries/mediaplayer/impl/DefaultMediaPlayer.kt

@ -43,7 +43,7 @@ import kotlin.time.Duration.Companion.seconds
*/ */
@ContributesBinding(RoomScope::class) @ContributesBinding(RoomScope::class)
@SingleIn(RoomScope::class) @SingleIn(RoomScope::class)
class MediaPlayerImpl @Inject constructor( class DefaultMediaPlayer @Inject constructor(
private val player: SimplePlayer, private val player: SimplePlayer,
) : MediaPlayer { ) : MediaPlayer {
private val listener = object : SimplePlayer.Listener { private val listener = object : SimplePlayer.Listener {

4
libraries/mediaplayer/impl/src/main/kotlin/io/element/android/libraries/mediaplayer/impl/SimplePlayer.kt

@ -55,13 +55,13 @@ object SimplePlayerModule {
@Provides @Provides
fun simplePlayerProvider( fun simplePlayerProvider(
@ApplicationContext context: Context, @ApplicationContext context: Context,
): SimplePlayer = SimplePlayerImpl(ExoPlayer.Builder(context).build()) ): SimplePlayer = DefaultSimplePlayer(ExoPlayer.Builder(context).build())
} }
/** /**
* Default implementation of [SimplePlayer] backed by a media3 [Player]. * Default implementation of [SimplePlayer] backed by a media3 [Player].
*/ */
class SimplePlayerImpl( class DefaultSimplePlayer(
private val p: Player private val p: Player
) : SimplePlayer { ) : SimplePlayer {
override fun addListener(listener: SimplePlayer.Listener) { override fun addListener(listener: SimplePlayer.Listener) {

2
libraries/mediaplayer/impl/src/test/kotlin/io/element/android/libraries/mediaplayer/impl/MediaPlayerImplTest.kt → libraries/mediaplayer/impl/src/test/kotlin/io/element/android/libraries/mediaplayer/impl/DefaultMediaPlayerTest.kt

@ -19,7 +19,7 @@ package io.element.android.libraries.mediaplayer.impl
import kotlinx.coroutines.test.runTest import kotlinx.coroutines.test.runTest
import org.junit.Test import org.junit.Test
class MediaPlayerImplTest { class DefaultMediaPlayerTest {
@Test @Test
fun `default test`() = runTest { fun `default test`() = runTest {
// TODO // TODO

2
libraries/pushstore/impl/src/main/kotlin/io/element/android/libraries/pushstore/impl/clientsecret/PushClientSecretImpl.kt → libraries/pushstore/impl/src/main/kotlin/io/element/android/libraries/pushstore/impl/clientsecret/DefaultPushClientSecret.kt

@ -29,7 +29,7 @@ import javax.inject.Inject
@SingleIn(AppScope::class) @SingleIn(AppScope::class)
@ContributesBinding(AppScope::class, boundType = PushClientSecret::class) @ContributesBinding(AppScope::class, boundType = PushClientSecret::class)
class PushClientSecretImpl @Inject constructor( class DefaultPushClientSecret @Inject constructor(
private val pushClientSecretFactory: PushClientSecretFactory, private val pushClientSecretFactory: PushClientSecretFactory,
private val pushClientSecretStore: PushClientSecretStore, private val pushClientSecretStore: PushClientSecretStore,
private val sessionObserver: SessionObserver, private val sessionObserver: SessionObserver,

2
libraries/pushstore/impl/src/main/kotlin/io/element/android/libraries/pushstore/impl/clientsecret/PushClientSecretFactoryImpl.kt → libraries/pushstore/impl/src/main/kotlin/io/element/android/libraries/pushstore/impl/clientsecret/DefaultPushClientSecretFactory.kt

@ -23,7 +23,7 @@ import java.util.UUID
import javax.inject.Inject import javax.inject.Inject
@ContributesBinding(AppScope::class) @ContributesBinding(AppScope::class)
class PushClientSecretFactoryImpl @Inject constructor() : PushClientSecretFactory { class DefaultPushClientSecretFactory @Inject constructor() : PushClientSecretFactory {
override fun create(): String { override fun create(): String {
return UUID.randomUUID().toString() return UUID.randomUUID().toString()
} }

4
libraries/pushstore/impl/src/test/kotlin/io/element/android/libraries/pushstore/impl/clientsecret/PushClientSecretImplTest.kt → libraries/pushstore/impl/src/test/kotlin/io/element/android/libraries/pushstore/impl/clientsecret/DefaultPushClientSecretTest.kt

@ -28,12 +28,12 @@ private val A_USER_ID_1 = SessionId("@A_USER_ID_1:domain")
private const val A_UNKNOWN_SECRET = "A_UNKNOWN_SECRET" private const val A_UNKNOWN_SECRET = "A_UNKNOWN_SECRET"
internal class PushClientSecretImplTest { internal class DefaultPushClientSecretTest {
@Test @Test
fun test() = runTest { fun test() = runTest {
val factory = FakePushClientSecretFactory() val factory = FakePushClientSecretFactory()
val store = InMemoryPushClientSecretStore() val store = InMemoryPushClientSecretStore()
val sut = PushClientSecretImpl(factory, store, NoOpSessionObserver()) val sut = DefaultPushClientSecret(factory, store, NoOpSessionObserver())
val secret0 = factory.getSecretForUser(0) val secret0 = factory.getSecretForUser(0)
val secret1 = factory.getSecretForUser(1) val secret1 = factory.getSecretForUser(1)

2
libraries/voicerecorder/impl/src/main/kotlin/io/element/android/libraries/voicerecorder/impl/VoiceRecorderImpl.kt → libraries/voicerecorder/impl/src/main/kotlin/io/element/android/libraries/voicerecorder/impl/DefaultVoiceRecorder.kt

@ -51,7 +51,7 @@ import kotlin.time.TimeSource
@SingleIn(RoomScope::class) @SingleIn(RoomScope::class)
@ContributesBinding(RoomScope::class) @ContributesBinding(RoomScope::class)
class VoiceRecorderImpl @Inject constructor( class DefaultVoiceRecorder @Inject constructor(
private val dispatchers: CoroutineDispatchers, private val dispatchers: CoroutineDispatchers,
private val timeSource: TimeSource, private val timeSource: TimeSource,
private val audioReaderFactory: AudioReader.Factory, private val audioReaderFactory: AudioReader.Factory,

16
libraries/voicerecorder/impl/src/test/kotlin/io/element/android/libraries/voicerecorder/impl/VoiceRecorderImplTest.kt → libraries/voicerecorder/impl/src/test/kotlin/io/element/android/libraries/voicerecorder/impl/DefaultVoiceRecorderTest.kt

@ -44,13 +44,13 @@ import kotlin.time.Duration.Companion.minutes
import kotlin.time.Duration.Companion.seconds import kotlin.time.Duration.Companion.seconds
import kotlin.time.TestTimeSource import kotlin.time.TestTimeSource
class VoiceRecorderImplTest { class DefaultVoiceRecorderTest {
private val fakeFileSystem = FakeFileSystem() private val fakeFileSystem = FakeFileSystem()
private val timeSource = TestTimeSource() private val timeSource = TestTimeSource()
@Test @Test
fun `it emits the initial state`() = runTest { fun `it emits the initial state`() = runTest {
val voiceRecorder = createVoiceRecorder() val voiceRecorder = createDefaultVoiceRecorder()
voiceRecorder.state.test { voiceRecorder.state.test {
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Idle) assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Idle)
} }
@ -58,7 +58,7 @@ class VoiceRecorderImplTest {
@Test @Test
fun `when recording, it emits the recording state`() = runTest { fun `when recording, it emits the recording state`() = runTest {
val voiceRecorder = createVoiceRecorder() val voiceRecorder = createDefaultVoiceRecorder()
voiceRecorder.state.test { voiceRecorder.state.test {
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Idle) assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Idle)
@ -73,7 +73,7 @@ class VoiceRecorderImplTest {
@Test @Test
fun `when elapsed time reaches 30 minutes, it stops recording`() = runTest { fun `when elapsed time reaches 30 minutes, it stops recording`() = runTest {
val voiceRecorder = createVoiceRecorder() val voiceRecorder = createDefaultVoiceRecorder()
voiceRecorder.state.test { voiceRecorder.state.test {
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Idle) assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Idle)
@ -96,7 +96,7 @@ class VoiceRecorderImplTest {
@Test @Test
fun `when stopped, it provides a file and duration`() = runTest { fun `when stopped, it provides a file and duration`() = runTest {
val voiceRecorder = createVoiceRecorder() val voiceRecorder = createDefaultVoiceRecorder()
voiceRecorder.state.test { voiceRecorder.state.test {
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Idle) assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Idle)
@ -119,7 +119,7 @@ class VoiceRecorderImplTest {
@Test @Test
fun `when cancelled, it deletes the file`() = runTest { fun `when cancelled, it deletes the file`() = runTest {
val voiceRecorder = createVoiceRecorder() val voiceRecorder = createDefaultVoiceRecorder()
voiceRecorder.state.test { voiceRecorder.state.test {
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Idle) assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Idle)
@ -131,9 +131,9 @@ class VoiceRecorderImplTest {
} }
} }
private fun TestScope.createVoiceRecorder(): VoiceRecorderImpl { private fun TestScope.createDefaultVoiceRecorder(): DefaultVoiceRecorder {
val fileConfig = VoiceRecorderModule.provideVoiceFileConfig() val fileConfig = VoiceRecorderModule.provideVoiceFileConfig()
return VoiceRecorderImpl( return DefaultVoiceRecorder(
dispatchers = testCoroutineDispatchers(), dispatchers = testCoroutineDispatchers(),
timeSource = timeSource, timeSource = timeSource,
audioReaderFactory = FakeAudioReaderFactory( audioReaderFactory = FakeAudioReaderFactory(

8
samples/minimal/src/main/kotlin/io/element/android/samples/minimal/RoomListScreen.kt

@ -22,8 +22,8 @@ import androidx.compose.runtime.DisposableEffect
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import io.element.android.features.invite.impl.response.AcceptDeclineInvitePresenter import io.element.android.features.invite.impl.response.AcceptDeclineInvitePresenter
import io.element.android.features.invite.impl.response.AcceptDeclineInviteView import io.element.android.features.invite.impl.response.AcceptDeclineInviteView
import io.element.android.features.leaveroom.impl.LeaveRoomPresenterImpl import io.element.android.features.leaveroom.impl.DefaultLeaveRoomPresenter
import io.element.android.features.networkmonitor.impl.NetworkMonitorImpl import io.element.android.features.networkmonitor.impl.DefaultNetworkMonitor
import io.element.android.features.roomlist.impl.RoomListPresenter import io.element.android.features.roomlist.impl.RoomListPresenter
import io.element.android.features.roomlist.impl.RoomListView import io.element.android.features.roomlist.impl.RoomListView
import io.element.android.features.roomlist.impl.datasource.RoomListDataSource import io.element.android.features.roomlist.impl.datasource.RoomListDataSource
@ -97,9 +97,9 @@ class RoomListScreen(
) )
private val presenter = RoomListPresenter( private val presenter = RoomListPresenter(
client = matrixClient, client = matrixClient,
networkMonitor = NetworkMonitorImpl(context, Singleton.appScope), networkMonitor = DefaultNetworkMonitor(context, Singleton.appScope),
snackbarDispatcher = SnackbarDispatcher(), snackbarDispatcher = SnackbarDispatcher(),
leaveRoomPresenter = LeaveRoomPresenterImpl(matrixClient, RoomMembershipObserver(), coroutineDispatchers), leaveRoomPresenter = DefaultLeaveRoomPresenter(matrixClient, RoomMembershipObserver(), coroutineDispatchers),
roomListDataSource = RoomListDataSource( roomListDataSource = RoomListDataSource(
roomListService = matrixClient.roomListService, roomListService = matrixClient.roomListService,
roomListRoomSummaryFactory = roomListRoomSummaryFactory, roomListRoomSummaryFactory = roomListRoomSummaryFactory,

1
tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistClassNameTest.kt

@ -89,6 +89,7 @@ class KonsistClassNameTest {
Konsist.scopeFromProject() Konsist.scopeFromProject()
.classes() .classes()
.withNameEndingWith("Impl") .withNameEndingWith("Impl")
.withoutName("MediaUploadHandlerImpl")
.assertEmpty(additionalMessage = "Class implementing interface should have name not end with 'Impl' but start with 'Default'") .assertEmpty(additionalMessage = "Class implementing interface should have name not end with 'Impl' but start with 'Default'")
} }
} }

Loading…
Cancel
Save