Fix quality and test compilation.

features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/members/RoomMemberListPresenter.kt

@@ -83,10 +83,10 @@ class RoomMemberListPresenter @AssistedInject constructor(
             if (membersState is MatrixRoomMembersState.Unknown) {
                 return@LaunchedEffect
             }
-            val _membersState = membersState
+            val finalMembersState = membersState
-            if (_membersState is MatrixRoomMembersState.Error && _membersState.roomMembers().orEmpty().isEmpty()) {
+            if (finalMembersState is MatrixRoomMembersState.Error && finalMembersState.roomMembers().orEmpty().isEmpty()) {
                 // Cannot fetch members and no cached members, display the error
-                roomMembers = AsyncData.Failure(_membersState.failure)
+                roomMembers = AsyncData.Failure(finalMembersState.failure)
                 return@LaunchedEffect
             }
             withContext(coroutineDispatchers.io) {

features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/members/RoomMemberListPresenterTest.kt

@@ -62,7 +62,7 @@ class RoomMemberListPresenterTest {
         }.test {
             skipItems(1)
             val initialState = awaitItem()
-            assertThat(initialState.roomMembers.isLoading).isTrue()
+            assertThat(initialState.roomMembers.isLoading()).isTrue()
             assertThat(initialState.searchQuery).isEmpty()
             assertThat(initialState.searchResults).isInstanceOf(SearchBarResultState.Initial::class.java)
             assertThat(initialState.isSearchActive).isFalse()
@@ -70,9 +70,9 @@ class RoomMemberListPresenterTest {
             // Skip item while the new members state is processed
             skipItems(1)
             val loadedMembersState = awaitItem()
-            assertThat(loadedMembersState.roomMembers.isLoading).isFalse()
+            assertThat(loadedMembersState.roomMembers.isLoading()).isFalse()
-            assertThat(loadedMembersState.roomMembers.invited).isEqualTo(listOf(aVictor(), aWalter()))
+            assertThat(loadedMembersState.roomMembers.dataOrNull()?.invited).isEqualTo(listOf(aVictor(), aWalter()))
-            assertThat(loadedMembersState.roomMembers.joined).isNotEmpty()
+            assertThat(loadedMembersState.roomMembers.dataOrNull()?.joined).isNotEmpty()
         }
     }
 
@@ -126,7 +126,7 @@ class RoomMemberListPresenterTest {
             assertThat(searchQueryUpdatedState.searchQuery).isEqualTo("Alice")
             val searchSearchResultDelivered = awaitItem()
             assertThat(searchSearchResultDelivered.searchResults).isInstanceOf(SearchBarResultState.Results::class.java)
-            assertThat((searchSearchResultDelivered.searchResults as SearchBarResultState.Results).results.joined.first().displayName)
+            assertThat((searchSearchResultDelivered.searchResults as SearchBarResultState.Results).results.dataOrNull()!!.joined.first().displayName)
                 .isEqualTo("Alice")
         }
     }