e78bc45810
[Wallet] Decouple CInputCoin from CWalletTx
8 years ago
1c897fc3da
Missing includes
8 years ago
d0cd0bd6d9
Make CWallet::SyncTransactions() interface friendlier
8 years ago
714e4ad13d
AddToWalletIfInvolvingMe should test pIndex, not posInBlock
8 years ago
66082e0119
[trivial] Fix typos (tempoarily → temporarily, inadvertantly → inadvertently)
8 years ago
14e10aa842
Call estimate(Smart)Fee directly from CBlockPolicyEstimator
8 years ago
fd44ac1e8b
[Wallet] Rename std::pair<const CWalletTx*, unsigned int> to CInputCoin
8 years ago
bcca57eff0
[trivial] Fix typo ("improssible" → "impossible")
8 years ago
b1a6d4cd56
Take a CTransactionRef in AddToWalletIfInvolvingMe to avoid a copy
8 years ago
1c95e2f9c9
Use std::shared_ptr instead of boost::shared_ptr in ScriptForMining
8 years ago
91f1e6ce5e
Remove dead-code tracking of requests for blocks we generated
8 years ago
e6d5e6cbbe
Hold cs_wallet for whole block [dis]connection processing
...
This simplifies fixing the wallet-returns-stale-info issue as we
now hold cs_wallet across an entire block instead of only per-tx.
8 years ago
461e49fee2
SyncTransaction->TxAddedToMempool/BlockConnected/Disconnected
...
This simplifies fixing the wallet-returns-stale-info issue as we
can now hold cs_wallet across an entire block instead of only
per-tx (though we only actually do so in the next commit).
This change also removes the NOT_IN_BLOCK constant in favor of only
passing the CBlockIndex* parameter to SyncTransactions when a new
block is being connected, instead of also when a block is being
disconnected.
This change adds a parameter to BlockConnectedDisconnected which
lists the transactions which were removed from mempool due to
confliction as a result of this operation. While its somewhat of a
shame to make block-validation-logic generate a list of mempool
changes to be included in its generated callbacks, fixing this isnt
too hard.
Further in this change-set, CValidationInterface starts listening
to mempool directly, placing it in the middle and giving it a bit
of logic to know how to route notifications from block-validation,
mempool, etc (though not listening for conflicted-removals yet).
8 years ago
3491476b6f
Wallet: reduce excess logic InMemPool()
...
removed the excess logic, return directly instead of using if-statement.
8 years ago
618d07faa2
MOVEONLY: tx functions to consensus/tx_verify.o
...
Functions related to transaction verification.
8 years ago
2a5f574762
Use fsbridge for fopen and freopen
...
Abstracts away how a path is opened to a `FILE*`.
Reduces the number of places where path is converted to a string
for anything else but printing.
8 years ago
bac5c9cf64
Replace uses of boost::filesystem with fs
...
Step two in abstracting away boost::filesystem.
To repeat this, simply run:
```
git ls-files \*.cpp \*.h | xargs sed -i 's/boost::filesystem/fs/g'
```
8 years ago
7d5172d354
Replace includes of boost/filesystem.h with fs.h
...
This is step one in abstracting the use of boost::filesystem.
8 years ago
5f59d3ecb7
Improve CFeeBumper interface, add comments, make use of std::move
8 years ago
0df22ed6fd
Cancel feebump is vErrors is not empty
8 years ago
44cabe6380
Use static calls for GetRequiredFee and GetMinimumFee, remove make_pair from emplace_back
8 years ago
bb78c1599e
Restore CalculateMaximumSignedTxSize function signature
8 years ago
51ea44f01c
Use "return false" instead assert() in CWallet::SignTransaction
8 years ago
bcc72cccc7
Directly abort execution in FeeBumper::commit if wallet or tx is not available
8 years ago
2718db0705
Restore invalid fee check (must be > 0)
8 years ago
0337a39d31
Refactor Bumpfee core functionality
8 years ago
d1a95e8d3d
Bumpfee move request parameter interaction to the top
8 years ago
6b3bb3d9ba
Change LogAcceptCategory to use uint32_t rather than sets of strings.
...
This changes the logging categories to boolean flags instead of strings.
This simplifies the acceptance testing by avoiding accessing a scoped
static thread local pointer to a thread local set of strings. It
eliminates the only use of boost::thread_specific_ptr outside of
lockorder debugging.
This change allows log entries to be directed to multiple categories
and makes it easy to change the logging flags at runtime (e.g. via
an RPC, though that isn't done by this commit.)
It also eliminates the fDebug global.
Configuration of unknown logging categories now produces a warning.
8 years ago
c21cbe61c6
Introduce FastRandomContext::randbool()
8 years ago
53351321c4
ApproximateBestSubset should take inputs by reference, not value
8 years ago
4115af7ac7
Fix rebase issue where pwalletMain was used instead of pwallet
...
Ser./Deser. nInternalChainCounter as last element
8 years ago
9382f0425e
Do not break backward compatibility during wallet encryption
8 years ago
1df08d1580
Add assertion for CanSupportFeature(FEATURE_HD_SPLIT)
8 years ago
cd468d07d5
Define CWallet::DeriveNewChildKey() as private
8 years ago
ed79e4f497
Optimize GetOldestKeyPoolTime(), return as soon as we have both oldest keys
8 years ago
771a304ffe
Make sure we set the wallets min version to FEATURE_HD_SPLIT at the very first point
8 years ago
003e197498
Remove FEATURE_HD_SPLIT bump TODO
8 years ago
d9638e5aa4
Overhaul the internal/external key derive switch
8 years ago
1090502c3e
Fix superfluous cast and code style nits in RPC wallet-hd.py test
8 years ago
58e148333e
CKeyPool avoid "catch (...)" in SerializationOp
8 years ago
e138876f0a
Only show keypoolsize_hd_internal if HD split is enabled
8 years ago
add38d9b83
GetOldestKeyPoolTime: if HD & HD Chain Split is enabled, response max(oldest-internal-key, oldest-external-key)
8 years ago
dd526c2a2d
Don't switch to HD-chain-split during wallet encryption of non HD-chain-split wallets
8 years ago
79df9df348
Switch to 100% for the HD internal keypool size
8 years ago
bcafca1077
Make sure we always generate one keypool key at minimum
8 years ago
d0a627a53a
Fix issue where CDataStream->nVersion was taken a CKeyPool record version
8 years ago
9af8f00a75
Make sure we hand out keypool keys if HD_SPLIT is not enabled
8 years ago
469a47b760
Make sure ReserveKeyFromKeyPool only hands out internal keys if HD_SPLIT is supported
8 years ago
05a9b493eb
Fix wrong keypool internal size in RPC getwalletinfo help
8 years ago
01de822c8d
Removed redundant IsLocked() check in NewKeyPool()
8 years ago
NicolasDorier