Wladimir J. van der Laan
c122f5528c
qt: Register CAmount metatype
...
This allows sending the type over queued connections.
Also normalize signal/slot names.
10 years ago
Cory Fields
63c17613ab
tests: fix false-positive under win64
...
BN_ULONG isn't necessarily an unsigned long, as is the case on win64.
10 years ago
Cory Fields
41d67c78bf
tests: fix python test-runner for windows
...
Windows needed a few fixups to get the tests running:
1. bitcoin-tx needs a file extension in Windows. Take this opportunity to
add an env file, which pulls variables out of our build config. This can
be extended as needed, for now it's very simple.
2. After #1 , split the args out of the exec key in the test data.
3. Correct the line-endings from windows stdout
10 years ago
Pieter Wuille
68af7d02cf
Fix vector out of bounds in script tests
10 years ago
Philip Kaufmann
7bec6dd230
cleanup license and header end comment in chain.cpp/.h
10 years ago
Philip Kaufmann
0db65d8798
update license of compat and crypto
...
- change license to be just MIT for all files in compat and crypto
- also add missing header end comments
- ensure default header include style
10 years ago
sinetek
775b7b8d70
LLu is standard, but not portable. use ULL
10 years ago
Mark Friedenbach
a372168e77
Use a typedef for monetary values
10 years ago
Pieter Wuille
8138cbea3c
Add automatic script test generation, and actual checksig tests
10 years ago
Cory Fields
6eb67b0ed2
autofile: Disallow by-value copies of CAutoFile
...
One might assume that CAutoFile would be ref-counted so that a copied object
would delay closing the underlying file until all copies have gone out of
scope. Since that's not the case with CAutoFile, explicitly disable copying.
10 years ago
Cory Fields
eee030f6bc
autofile: don't copy CAutoFile by value
10 years ago
Cory Fields
be6d87aa60
script: don't read past the end
10 years ago
Cory Fields
a94496fbb6
tests: don't split an empty string
10 years ago
ENikS
1e73504865
Fixing C4146 warning
...
Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
10 years ago
Wladimir J. van der Laan
d14d7deff0
SanitizeString: allow '(' and ')'
...
'(' and ')' are valid in user agent strings, so should be reported
as such in RPC `getpeerinfo`.
Fixes #4537 .
10 years ago
ENikS
219372f1dd
script: Fix reference into empty vector run time exception
...
Edit by laanwj: `begin_ptr(sourcedata) + sourcedata.size()` -> `end_ptr(sourcedata)`
10 years ago
Jeff Garzik
ff36cbe8d0
RPC getnetworkinfo: export local node's client sub-version string
10 years ago
Philip Kaufmann
e6beedc496
[Qt] add more NULL pointer checks in bitcoingui
...
- add missing checks for clientModel and optionsModel
- small cleanups for an #ifdef on Mac
- remove an unneeded else
10 years ago
Pieter Wuille
cf42c36e99
Apply clang-format on crypto/* and compat/*
10 years ago
ENikS
cda45b5131
Reinitializing list's begin iterator after few elements were erased from the head
10 years ago
ENikS
459a2d25e0
Avoiding referencing elements of an empty vector
10 years ago
ENikS
c8063b5712
Fixing out of bounds asses error
10 years ago
ENikS
6f3ae9b5df
Fixing out of bounds error in GetKey()
10 years ago
Philip Kaufmann
bb26e2c896
[Qt] minor changes in splashscreen.cpp
...
- guard an unused variable with Q_UNUSED() macro
- remove a commented out line of code
10 years ago
Pieter Wuille
c8589bf99e
Add actual signature tests
10 years ago
Pieter Wuille
76ec867796
Use actually valid transactions for script tests
10 years ago
Wladimir J. van der Laan
cfc5cfb0f0
qt: Make splash and shutdown window ignore close events
...
It's strange to be able to close these windows while there is work
in progress.
Also set Qt::WA_DeleteOnClose on both windows to make sure that they
are deleted eventually, no matter what happens.
10 years ago
Philip Kaufmann
2e5361b9c2
remove code below asserts in limitedmap.h (fixes a ToDo)
10 years ago
ENikS
87314c1c5e
Fixing improper input syntax and failing bounds check
10 years ago
Peter Todd
01c28073ba
Add warning about the merkle-tree algorithm duplicate txid flaw
...
Lots of people read the Bitcoin Core codebase to learn more about
crypto; better to warn about flaws explicitly so they don't blindly copy
the code for other uses and create broken systems.
10 years ago
Wladimir J. van der Laan
d6712db354
Also create pid file in non-daemon mode
...
Always make a pid file, not only when `-daemon` specified.
This is useful for troubleshooting, for attaching debuggers and loggers
and such.
- Write the pid file only after the datadir lock was acquired
- Don't create or remove a pid file on WIN32, and also don't show the option
10 years ago
Wladimir J. van der Laan
33a27716fc
test: Fix DoS tests after c74332c
...
Fix data structure mismatch ... The mind boggles that they were still passing at all.
10 years ago
ENikS
6134b43ba9
Fixing condition 'sabotaging' MSVC build
10 years ago
Pieter Wuille
20e01b1a03
Apply clang-format on some infrequently-updated files
10 years ago
ENikS
018cec7c41
Fixing 'vector out of bounds' issue in base 32 and 64
10 years ago
Philip Kaufmann
5e83bc404c
[Qt] include and file header cleanup
...
- alphabetical ordering
- correct ordering own headers before normal headers etc.
10 years ago
Wladimir J. van der Laan
a49f11d9ed
qt: Change splash screen to normal window
...
Makes it possible to move, minimize, unminimize the window while
Bitcoin Core is initializing.
10 years ago
Philip Kaufmann
93f84d0417
cleanup class private and public areas in walletdb
...
- only code movement
10 years ago
Philip Kaufmann
22d7e7014f
prefer const string& over char* in CDB and CWalletDB constructor
...
- also make parameter of CDBEnv::CheckpointLSN a constant reference
10 years ago
imharrywu
c15e483f23
typo fix of booleamn to boolean
10 years ago
Pieter Wuille
ab15b2ec71
Avoid copying undo data
10 years ago
Pieter Wuille
0be990ba34
Move CTxDestination from script/script to script/standard
10 years ago
Philip Kaufmann
f4fe205034
add nModSize init to default constructor of CTxMemPoolEntry
10 years ago
Benedict Chan
1a613963e1
fix missing gettransaction entries in rpcclient
10 years ago
Benedict Chan
57e1716de6
update rpc help message for gettransaction to add includeWatchonly param
10 years ago
randy-waterhouse
52a5f90360
Create the common location for all m4 autotool build scripts, build-aux/m4.
...
Update .gitignore.
10 years ago
imharrywu
e9992fb645
remove include of chainparams.h
...
chainparams.h has not been used in this cpp file already, consider to remove it for clean.
10 years ago
Philip Kaufmann
ee304b6e35
minor changes for help message of getpeerinfo
10 years ago
Suhas Daftuar
f7e36370f3
Eliminate extra assignment
10 years ago
ENikS
ec91092df8
Fixing compiler warning C4101
...
Github-Pull: #4856
10 years ago