Jeff Garzik
3ce7e669e3
bitcoin-cli, rpcrawtransaction: harmonize "{" styling
11 years ago
Cory Fields
2a5840096f
core_read's ParseScript(): minor cleanups
...
- use .empty() rather than .size() == 0
- use a const_iterator rather than BOOST_FOREACH
- validate iterators before creating a string from them
11 years ago
Jeff Garzik
b2aeaa7939
Move ParseScript() helper, becoming accessible outside src/test/
11 years ago
Jeff Garzik
ae775b5b31
Consolidate CTransaction hex encode/decode into core_io.h, core_{read,write}.cpp
11 years ago
Jeff Garzik
2e7009d67b
Avoid querying DNS seeds, if we have open connections.
...
The goal is to increase independence and privacy.
11 years ago
Pieter Wuille
2887bffcfd
Update coding style and add .clang-format
11 years ago
Wladimir J. van der Laan
f9de17ec2f
Add warning comment to getinfo
...
Warn that people should not add new information, or change current
information returned by getinfo.
11 years ago
Alex Morcos
961ae93c85
Fix minor bug which only affected log messages.
11 years ago
Philip Kaufmann
d817187bdb
[Qt] remove ProxySocksVersion from OptionID
...
- we only support SOCKS5, so remove it
11 years ago
Alex Morcos
17f15678d3
Fixed a bug with index bounds checking
11 years ago
Pieter Wuille
d70bc52ee3
Rework block processing benchmark code
...
* Replace -benchmark (and the related fBenchmark) with a regular debug option, -debug=bench.
* Increase coverage and granularity of individual block processing steps.
* Add cummulative times.
11 years ago
Philip Kaufmann
f65352a7d0
[Qt] small Qt-only include cleanup
11 years ago
Wladimir J. van der Laan
93659379bd
Add comment about never updating nTimeOffset past 199 samples
...
Refer to issue #4521 for details.
11 years ago
Wladimir J. van der Laan
0430c30af1
Add missing FindNode prototype to net.h
...
Also make the argument a const std::string & instead of pass-by-value.
11 years ago
paveljanik
ab651b2d62
Fix typos in comments (missing i's).
11 years ago
Wladimir J. van der Laan
29eaa31694
ui: Make sure sendcoinsentry signals only connected once
...
Move signal connections to constructor where possible.
11 years ago
Wladimir J. van der Laan
2a05101efd
qt: Remove unused functions from BitcoinUnits
...
Remove two functions that are now unused.
11 years ago
Wladimir J. van der Laan
91cce1732b
qt: Use fixed-point arithmetic in amount spinbox
...
Fixes various issues and cleans up code
- Fixes issue #4500 : Amount widget +/- has floating point rounding artifacts
- Amount box can now be emptied again, without clearing to 0
Also aligns the amount to the right, as in other places.
11 years ago
Pieter Wuille
ad08d0b95b
Bugfix: make CCoinsViewMemPool support pruned entries in underlying cache
11 years ago
Wladimir J. van der Laan
afa71fb3e3
Harmonize importprivkey and importaddress documentation
11 years ago
Tom Harding
9c347313f7
CBloomFilter::clear() method
11 years ago
Philip Kaufmann
f469f79ff8
remove an unneded .c_str() in OpenNetworkConnection()
11 years ago
Wladimir J. van der Laan
8f3f94a470
Revert "CBloomFilter::clear() method"
...
This reverts commit 8fbf03995d
.
11 years ago
Wladimir J. van der Laan
98e84aae7a
Revert "Relay double-spends, subject to anti-DOS"
...
This reverts commit d640a3ceab
.
11 years ago
Wladimir J. van der Laan
3015e0bca6
Revert "UI to alert of respend attempt affecting wallet."
...
This reverts commit ada5a067c7
.
Conflicts:
src/qt/guiconstants.h
src/wallet.h
11 years ago
Wladimir J. van der Laan
39d3f2cb40
Revert "Add -respendnotify option and new RPC data"
...
This reverts commit 9004798e62
.
11 years ago
Wladimir J. van der Laan
ad26dc9c31
Revert "Formatting, spelling, comment fixes."
...
This reverts commit 7a19efe040
.
11 years ago
Wladimir J. van der Laan
cd057bfd41
Revert "Check signatures before respend relay"
...
This reverts commit 88dd3598d2
.
11 years ago
Wladimir J. van der Laan
67cc8f25c2
Revert "Remove signal DoubleSpendDetected, use function"
...
This reverts commit 0da6b3fd18
.
11 years ago
Wladimir J. van der Laan
0de61e7585
qt: Move SplashFinished to after ClientModel/WalletModel creation
...
With a large wallet there was a noticable gap between hiding of the
splash and showing the main window.
11 years ago
Cozz Lovan
027dcdc792
[Qt] Fix thin space in URI
11 years ago
Whit J
b9345f7d1c
qt: Make error message for failed export a little friendlier
...
Closes #4528 .
11 years ago
Otto Allmendinger
d2d9dc063f
script tests: add tests for CHECKMULTISIG limits
11 years ago
Jeff Garzik
3da434a2ef
Introduce option to disable relay/mining of bare multisig scripts in TX outputs
...
First and foremost, this defaults to OFF.
This option lets a node consider such transactions non-standard,
meaning they will not be relayed or mined by default, but other miners
are free to mine these as usual.
11 years ago
Otto Allmendinger
89101c6e78
script test: test case for 5-byte bools
11 years ago
Wladimir J. van der Laan
5bb765507b
Fix a signed/unsigned warning introduced in 1b4568c
...
vout counter must be unsigned.
11 years ago
Otto Allmendinger
4cac5dbf83
script tests: value with trailing 0x00 is true
11 years ago
Otto Allmendinger
833ff161bc
script tests: values that overflow to 0 are true
11 years ago
Otto Allmendinger
0072d98849
script tests: BOOLAND, BOOLOR decode to integer
...
unlike other boolean checks, arguments >5 bytes invalidate the script
11 years ago
Otto Allmendinger
ed02282bba
additional test for OP_SIZE in script_valid.json
11 years ago
Cory Fields
2d89ea9781
build: fix whitespace in pkg-config variable
...
Useful for PKG_CONFIG="pkg-config --static"
11 years ago
Cory Fields
ab123ad4d6
build: allow linux and osx to build against static qt5
...
This is the first part of a huge effort to rework the handling of dependencies.
To start, this change allows all supported platforms to build against a static
Qt. 5.2.1 and 5.3 have been successfully tested against osx64, win32, win64,
linux32, and linux64.
It also makes a small change to the windows config, to allow linking against
qt builds with or without built-in libjpeg/libpng/libpcre/libz.
The actual build processes to take advantage of these changes (for gitian and
pull-tester) are coming soon. Until then, this should be a no-op.
11 years ago
Cory Fields
1e72d5c033
build: silence false errors during make clean
11 years ago
Cozz Lovan
acd432b5b3
[Qt] Prevent balloon-spam after rescan
11 years ago
Philip Kaufmann
c994d2e769
prevent SOCKET leak in BindListenPort()
...
- the call to CloseSocket() is placed after the WSAGetLastError(), because
a CloseSocket() can trigger an error also, which we don't want for the
logging in this two cases
11 years ago
Philip Kaufmann
eaedb59e05
net: add SetSocketNonBlocking() as OS independent wrapper
11 years ago
Wladimir J. van der Laan
43f510d37d
Convert closesocket 'compat wrapper' to function in netbase
...
Simpler alternative to #4348 .
The current setup with closesocket() is strange. It poses
as a compatibility wrapper but adds functionality.
Rename it and make it a documented utility function in netbase.
Code movement only, zero effect on the functionality.
11 years ago
Philip Kaufmann
7de3f1cfd6
fix help message for RPC getpeerinfo
11 years ago
Pieter Wuille
09c744c2a8
Make sure CAutoFile for fees estimate goes out of scope
11 years ago
Pieter Wuille
b069750d3f
Break up CAddrMan's IMPLEMENT_SERIALIZE
11 years ago