Jeff Garzik
ff36cbe8d0
RPC getnetworkinfo: export local node's client sub-version string
10 years ago
Wladimir J. van der Laan
c4998661e4
Merge pull request #4958
...
e6beedc
[Qt] add more NULL pointer checks in bitcoingui (Philip Kaufmann)
10 years ago
Philip Kaufmann
e6beedc496
[Qt] add more NULL pointer checks in bitcoingui
...
- add missing checks for clientModel and optionsModel
- small cleanups for an #ifdef on Mac
- remove an unneeded else
10 years ago
Pieter Wuille
cf42c36e99
Apply clang-format on crypto/* and compat/*
10 years ago
Pieter Wuille
ea69592a2f
Merge pull request #4974
...
b498a94
Fixed typo in README.md file. "-regest" "-regtest" (Eric Shaw)
10 years ago
Eric Shaw
b498a9493c
Fixed typo in README.md file. "-regest" "-regtest"
...
There was a typo in the README.md file. It previously read "-regest" instead of the proper "-regtest" and it has been updated to the proper reading.
10 years ago
Pieter Wuille
584a358997
Do merkle root and txid duplicates check simultaneously
...
Move the txid duplicates check into BuildMerkleTree, where it can be done
much more efficiently (without needing to build a full txid set to detect
duplicates).
The previous version (using the std::set<uint256> to detect duplicates) was
also slightly too weak. A block mined with actual duplicate transactions
(which is invalid, due to the inputs of the duplicated transactions being
seen as double spends) would trigger the duplicates logic, resulting in the
block not being stored on disk, and rerequested. This change fixes that by
only triggering in the case of duplicated transactions that can actually
result in an identical merkle root.
10 years ago
ENikS
cda45b5131
Reinitializing list's begin iterator after few elements were erased from the head
10 years ago
Pieter Wuille
7a04f3d708
Merge pull request #4955
...
87314c1
Fixing improper input syntax and failing bounds check (ENikS)
10 years ago
ENikS
459a2d25e0
Avoiding referencing elements of an empty vector
10 years ago
ENikS
c8063b5712
Fixing out of bounds asses error
10 years ago
Wladimir J. van der Laan
35ee2dac67
Merge pull request #4949
...
c8589bf
Add actual signature tests (Pieter Wuille)
76ec867
Use actually valid transactions for script tests (Pieter Wuille)
10 years ago
Wladimir J. van der Laan
bfe527ea86
Merge pull request #4962
...
6f3ae9b
Fixing out of bounds error in GetKey() (ENikS)
10 years ago
ENikS
6f3ae9b5df
Fixing out of bounds error in GetKey()
10 years ago
Alexander Jeng
2027450d42
Grammar fixes in README
...
Github-Pull: #4956
10 years ago
Philip Kaufmann
bb26e2c896
[Qt] minor changes in splashscreen.cpp
...
- guard an unused variable with Q_UNUSED() macro
- remove a commented out line of code
10 years ago
Pieter Wuille
c8589bf99e
Add actual signature tests
10 years ago
Pieter Wuille
76ec867796
Use actually valid transactions for script tests
10 years ago
Wladimir J. van der Laan
cb9871194a
Merge pull request #4765
...
e2a98d2
Update obsolete AC macros. (randy-waterhouse)
e543811
Add warnings for autogen.sh. Fix AC_CONFIG_SRCDIR. (randy-waterhouse)
10 years ago
Wladimir J. van der Laan
27fc5277f7
build: change cdrkit location in build-process.md
...
The cdrkit.org domain expired.
Thanks to gdm85 on IRC for reporting this.
10 years ago
Wladimir J. van der Laan
3cdae61aa2
Merge pull request #4787
...
4b0deb3
Clean up CMerkleTx::SetMerkleBranch. (Daniel Kraft)
10 years ago
Wladimir J. van der Laan
565da68ed0
Merge pull request #4852
...
5e83bc4
[Qt] include and file header cleanup (Philip Kaufmann)
10 years ago
Wladimir J. van der Laan
321fd7dbee
Merge pull request #4947
...
6134b43
Fixing condition 'sabotaging' MSVC build (ENikS)
10 years ago
Wladimir J. van der Laan
aa340a8f07
Merge pull request #4951
...
d6712db
Also create pid file in non-daemon mode (Wladimir J. van der Laan)
10 years ago
Wladimir J. van der Laan
cfc5cfb0f0
qt: Make splash and shutdown window ignore close events
...
It's strange to be able to close these windows while there is work
in progress.
Also set Qt::WA_DeleteOnClose on both windows to make sure that they
are deleted eventually, no matter what happens.
10 years ago
Philip Kaufmann
2e5361b9c2
remove code below asserts in limitedmap.h (fixes a ToDo)
10 years ago
Wladimir J. van der Laan
6b09bc45b1
Merge pull request #4941
...
a49f11d
qt: Change splash screen to normal window (Wladimir J. van der Laan)
10 years ago
Wladimir J. van der Laan
5547f08ec7
Merge pull request #4952
...
01c2807
Add warning about the merkle-tree algorithm duplicate txid flaw (Peter Todd)
10 years ago
ENikS
87314c1c5e
Fixing improper input syntax and failing bounds check
10 years ago
Wladimir J. van der Laan
ae9966ed85
Merge pull request #4950
...
33a2771
test: Fix DoS tests after c74332c
(Wladimir J. van der Laan)
10 years ago
Pieter Wuille
934b153a2c
Merge pull request #4933
...
20e01b1
Apply clang-format on some infrequently-updated files (Pieter Wuille)
10 years ago
Peter Todd
01c28073ba
Add warning about the merkle-tree algorithm duplicate txid flaw
...
Lots of people read the Bitcoin Core codebase to learn more about
crypto; better to warn about flaws explicitly so they don't blindly copy
the code for other uses and create broken systems.
10 years ago
Wladimir J. van der Laan
d6712db354
Also create pid file in non-daemon mode
...
Always make a pid file, not only when `-daemon` specified.
This is useful for troubleshooting, for attaching debuggers and loggers
and such.
- Write the pid file only after the datadir lock was acquired
- Don't create or remove a pid file on WIN32, and also don't show the option
10 years ago
Wladimir J. van der Laan
33a27716fc
test: Fix DoS tests after c74332c
...
Fix data structure mismatch ... The mind boggles that they were still passing at all.
10 years ago
Pieter Wuille
25308337d6
Merge pull request #4835
...
ab15b2e
Avoid copying undo data (Pieter Wuille)
10 years ago
ENikS
6134b43ba9
Fixing condition 'sabotaging' MSVC build
10 years ago
Cory Fields
c65cc8cde3
build: fix release name strings for gitian builds
...
When building from a distdir as gitian does, checking for the .git dir
is not reliable. Instead, ask git if we're in a repo.
10 years ago
Pieter Wuille
20e01b1a03
Apply clang-format on some infrequently-updated files
10 years ago
Pieter Wuille
2fc6c67400
Merge pull request #4944
...
018cec7
Fixing 'vector out of bounds' issue in base 32 and 64 (ENikS)
10 years ago
ENikS
018cec7c41
Fixing 'vector out of bounds' issue in base 32 and 64
10 years ago
Philip Kaufmann
5e83bc404c
[Qt] include and file header cleanup
...
- alphabetical ordering
- correct ordering own headers before normal headers etc.
10 years ago
Wladimir J. van der Laan
a49f11d9ed
qt: Change splash screen to normal window
...
Makes it possible to move, minimize, unminimize the window while
Bitcoin Core is initializing.
10 years ago
Wladimir J. van der Laan
7fd8813675
Merge pull request #4667
...
bbad683
[Qt] simplify return code and return values in txtablemodel (Philip Kaufmann)
21f1516
[Qt] add all used colors in txtablemodel to guiconstants (Philip Kaufmann)
10 years ago
Wladimir J. van der Laan
0db24bf5c3
Merge pull request #4939
...
d547ebf
Remove mention of MacPorts from OSX build docs (Wladimir J. van der Laan)
10 years ago
Wladimir J. van der Laan
62e5f8f961
CMessageHeader sanity changes
...
- Remove spurious `pchCommand[1] = 1` in CMessageHeader()
- Make sure that pchCommand is zero-padded if length is shorter than
COMMAND_SIZE
- Use strnlen to determine length of pcmCommand in GetCommand
10 years ago
Wladimir J. van der Laan
d547ebf56e
Remove mention of MacPorts from OSX build docs
10 years ago
Wladimir J. van der Laan
c14bfea8ee
Merge pull request #4936
...
c15e483
typo fix of booleamn to boolean (imharrywu)
10 years ago
Wladimir J. van der Laan
e9870c5ed4
Merge pull request #4931
...
93f84d0
cleanup class private and public areas in walletdb (Philip Kaufmann)
22d7e70
prefer const string& over char* in CDB and CWalletDB constructor (Philip Kaufmann)
10 years ago
Philip Kaufmann
93f84d0417
cleanup class private and public areas in walletdb
...
- only code movement
10 years ago
Philip Kaufmann
22d7e7014f
prefer const string& over char* in CDB and CWalletDB constructor
...
- also make parameter of CDBEnv::CheckpointLSN a constant reference
10 years ago