Matt Corallo
f404334910
Handle SyncTransaction in ActivateBestChain instead of ConnectTrace
...
This makes a later change to move it all into one per-block callback
simpler.
8 years ago
Matt Corallo
a1476877ce
Keep conflictedTxs in ConnectTrace per-block
8 years ago
Matt Corallo
d3167ba9bb
Handle conflicted transactions directly in ConnectTrace
8 years ago
Matt Corallo
29e6e231c8
Make ConnectTrace::blocksConnected private, hide behind accessors
8 years ago
Matt Corallo
822000cf82
Add pblock to connectTrace at the end of ConnectTip, not start
...
This makes ConnectTip responsible for the ConnectTrace instead
of splitting the logic between ActivateBestChainStep and ConnectTip
8 years ago
Matt Corallo
f5e9a019a4
Include missing #include in zmqnotificationinterface.h
8 years ago
Kewde
3491476b6f
Wallet: reduce excess logic InMemPool()
...
removed the excess logic, return directly instead of using if-statement.
8 years ago
John Newbery
1352092dbd
Log calls to getblocktemplate
8 years ago
Wladimir J. van der Laan
08d9aee3eb
build: Remove duplicate version information from src/clientversion.h
...
Fail when the version information is not defined otherwise when
HAVE_CONFIG_H is not set.
8 years ago
MarcoFalke
faafa801e8
init: Remove redundant logging code
8 years ago
MarcoFalke
faab6241d0
logging: Fix off-by-one for shrinkdebugfile
8 years ago
John Newbery
cd7f39467a
initialize flag variable to 0 (and continue if GetLogCategory() fails)
8 years ago
Suhas Daftuar
9bef02e365
Bugfix: ancestor modifed fees were incorrect for descendants
...
If prioritisetransaction was called for a tx with in-mempool
descendants, the modified ancestor fee values for those descendants was
incorrect.
8 years ago
Russell Yanofsky
bf1026412d
Run bitcoin_test-qt under minimal QPA platform
...
Fixes broken "make check" reported by Matt Corallo <git@bluematt.me> in
https://github.com/bitcoin/bitcoin/issues/10110
Fix was suggested and initially implemented by
Cory Fields <cory-nospam-@coryfields.com> in
https://github.com/bitcoin/bitcoin/pull/10117#issuecomment-290275236
8 years ago
John Newbery
3bde556429
Add -debugexclude option to switch off logging for specified components
8 years ago
Wladimir J. van der Laan
f110272dc9
Remove `namespace fs=fs`
...
Having these inside functions is silly and redundant now.
8 years ago
Wladimir J. van der Laan
75594bd7f2
torcontrol: Use fs::path instead of std::string for private key path
8 years ago
Wladimir J. van der Laan
2a5f574762
Use fsbridge for fopen and freopen
...
Abstracts away how a path is opened to a `FILE*`.
Reduces the number of places where path is converted to a string
for anything else but printing.
8 years ago
Wladimir J. van der Laan
bac5c9cf64
Replace uses of boost::filesystem with fs
...
Step two in abstracting away boost::filesystem.
To repeat this, simply run:
```
git ls-files \*.cpp \*.h | xargs sed -i 's/boost::filesystem/fs/g'
```
8 years ago
Wladimir J. van der Laan
7d5172d354
Replace includes of boost/filesystem.h with fs.h
...
This is step one in abstracting the use of boost::filesystem.
8 years ago
Wladimir J. van der Laan
19e36bbef6
Add fs.cpp/h
8 years ago
Gregory Maxwell
30f30c0f99
Add braces to submitblock per current style.
8 years ago
Gregory Maxwell
4f15ea102d
Check transaction count early in submitblock.
...
There is no point in even hashing a submitted block which doesn't have
a coinbase transaction.
This also results in more useful error reporting on corrupted input.
Thanks to rawodb for the bug report.
8 years ago
Gregory Maxwell
ada0caa165
Make GetWitnessCommitmentIndex callable on blocks without a coinbase txn.
...
This isn't actually needed anywhere, but it's less brittle.
8 years ago
practicalswift
4b87973c32
[rpc] Remove auth cookie on shutdown
...
Accidentally removed in 40b556d374
8 years ago
Matthias Grundmann
31a14d4909
Correct indentation and remove unnecessary braces
8 years ago
Jonas Schnelli
5f59d3ecb7
Improve CFeeBumper interface, add comments, make use of std::move
8 years ago
Jonas Schnelli
0df22ed6fd
Cancel feebump is vErrors is not empty
8 years ago
Jonas Schnelli
44cabe6380
Use static calls for GetRequiredFee and GetMinimumFee, remove make_pair from emplace_back
8 years ago
Jonas Schnelli
bb78c1599e
Restore CalculateMaximumSignedTxSize function signature
8 years ago
Jonas Schnelli
51ea44f01c
Use "return false" instead assert() in CWallet::SignTransaction
8 years ago
Jonas Schnelli
bcc72cccc7
Directly abort execution in FeeBumper::commit if wallet or tx is not available
8 years ago
Jonas Schnelli
2718db0705
Restore invalid fee check (must be > 0)
8 years ago
Jonas Schnelli
0337a39d31
Refactor Bumpfee core functionality
8 years ago
Jonas Schnelli
d1a95e8d3d
Bumpfee move request parameter interaction to the top
8 years ago
Gregory Maxwell
6b3bb3d9ba
Change LogAcceptCategory to use uint32_t rather than sets of strings.
...
This changes the logging categories to boolean flags instead of strings.
This simplifies the acceptance testing by avoiding accessing a scoped
static thread local pointer to a thread local set of strings. It
eliminates the only use of boost::thread_specific_ptr outside of
lockorder debugging.
This change allows log entries to be directed to multiple categories
and makes it easy to change the logging flags at runtime (e.g. via
an RPC, though that isn't done by this commit.)
It also eliminates the fDebug global.
Configuration of unknown logging categories now produces a warning.
8 years ago
Alex Morcos
1b55e07b7a
Make threshold for flushing more conservative.
...
Always leave a reasonable buffer of 50MB for usage from newly connected block (once over 50%) and increase the high water mark buffer to 200MB.
8 years ago
John Newbery
5d08c9c579
Send the correct error code in reject messages
8 years ago
Alex Morcos
f33afd3b2b
Lower default memory footprint slightly
8 years ago
Alex Morcos
5b95a190e8
Make pcoinsTip memory calculations consistent
...
Since we are more accurately measuring pcoinsTip peak usage at twice the current in dynamic usage, it makes sense to double the default (this will lead to the same effective usage and peak usage as previously).
We should also double the buffer used to avoid flushing if above 90% but still sufficient space remaining.
8 years ago
Cory Fields
e025246fe2
scheduler: fix sub-second precision with boost < 1.50
8 years ago
Awemany
eb66bf9bdd
bitcoin-tx: Fix missing range check
...
The number of arguments is not checked MutateTxAddOutAddr(..), meaning
that
> ./bitcoin-tx -create outaddr=
accessed the vStrInputParts vector beyond its bounds.
This also includes work by jnewbery to check the inputs for
MutateTxAddPubKey()
8 years ago
Jeremy Rubin
3f098cccf6
Decrease testcase sizes in cuckoocache tests
8 years ago
Pieter Wuille
7228ce853d
Compensate for memory peak at flush time
8 years ago
Wladimir J. van der Laan
625488ace5
util: Work around (virtual) memory exhaustion on 32-bit w/ glibc
...
glibc-specific: On 32-bit systems set the number of arenas to 1. By
default, since glibc 2.10, the C library will create up to two heap
arenas per core. This is known to cause excessive virtual address space
usage in our usage. Work around it by setting the maximum number of
arenas to 1.
8 years ago
Pieter Wuille
4fd2d2fc97
Add a FastRandomContext::randrange and use it
8 years ago
Pieter Wuille
16329224e7
Switch FastRandomContext to ChaCha20
8 years ago
Suhas Daftuar
011124a2b2
Update benchmarking with package statistics
8 years ago
Suhas Daftuar
42cd8c890f
Add benchmarking for CreateNewBlock
8 years ago
Suhas Daftuar
eed816af6c
Mining: return early when block is almost full
8 years ago