a80f295666
[tests] Clean up addrman_tests.cpp
...
Cleanup request from #10287 .
Change "Test #:" comments to "Test:"
Change BOOST_CHECK(... = ...) to BOOST_CHECK_EQUAL(..., ...)
Remove three unnecessary if statements
8 years ago
c707ca872d
removed unused code in INV message
...
vToFetch is never used after declaration. When checked if not empty,
evaluation is always false. Best case scenario this is optimized by the
compiler, worst case it wastes cpu cycles. It should be removed either
way.
8 years ago
3a0a5bc234
[doc] Add hint about getmempoolentry to getrawmempool help.
8 years ago
2c0a6f157d
Use sanity check timestamps as entropy
8 years ago
33f853d8d8
Test that GetPerformanceCounter() increments
8 years ago
f544094d5e
Use hardware timestamps in RNG seeding
8 years ago
97477c537e
Maintain state across GetStrongRandBytes calls
8 years ago
0f3471f3ad
net: make CNode's id private
8 years ago
9ff0a51164
scripted-diff: net: Use accessor rather than node's id directly
...
-BEGIN VERIFY SCRIPT-
sed -i "s/\(node\|to\|from\)->id/\1->GetId()/" src/net.cpp src/net_processing.cpp
-END VERIFY SCRIPT-
8 years ago
c1082a7d35
Chainparams: Use the factory for pow tests
8 years ago
2351a064a6
Chainparams: Get rid of CChainParams& Params(std::string)
8 years ago
f87f3626e3
Chainparams: Use a regular factory for creating chainparams
8 years ago
381a46e38f
Consensus: Policy: MOVEONLY: Move CFeeRate out of the consensus module
...
...from amount.o to policy/feerate.o
Policy, because it moves policy code to the policy directory (common module)
8 years ago
330bb5a456
Consensus: Minimal way to move dust out of consensus
8 years ago
bd1f138e73
Add getchaintxstats RPC
8 years ago
ed36de59e4
[tests] Update Unit Test for addrman.h/addrman.cpp
...
Add test for adding multiple addresses to address manager
Clean up unnecessary modulo operations
Add test for GetNewBucket's alternate method signature
8 years ago
3fe8a83969
Remove unused forward declaration for non-existent ScriptPubKeyToJSON(...)
8 years ago
1ff2bb4e3e
Remove unused args from GetFetchhFlags()
8 years ago
3503716f1e
Trivial: remove extra character from comment
8 years ago
70d39454ee
Fix potential NPD introduced in b297426c
...
See https://github.com/bitcoin/bitcoin/pull/10290#discussion_r113954232
for more info.
8 years ago
7c588637d4
[Wallet] unset change position when there is no change on exact match
8 years ago
56f09df9d8
[Makefile] Alphabetically Reorder addrdb.cpp
...
To keep conformity.
8 years ago
db994b2de9
Simplify DisconnectBlock arguments/return value
...
DisconnectBlock currently has a complicated interface:
Situation Return value
pfClean != nullptr pfClean == nullptr
All good: true true
Failure: false false
Unclean rewind: true false
with *pfClean=false
Change this to return a tristate enum instead. As an added bonus,
remove the ValidationState& argument which was unused.
8 years ago
77c54b270d
[net] listbanned RPC and QT should show correct banned subnets
8 years ago
0ff9320bf5
refactor TxToJSON() and ScriptPubKeyToJSON()
8 years ago
4fbae77929
Improved efficiency in COutPoint constructors
8 years ago
b297426c96
Add -stopatheight for benchmarking
8 years ago
3edbd79a65
cleanup: reduce to one GetMinimumFee call signature
8 years ago
b51aaf1c42
Remove unused C++ code not covered by unit tests
8 years ago
dcb69fde5a
[test] Unit test amount.h/amount.cpp
...
Add tests for MoneyRange, binary operators, ToString and a constructor
8 years ago
02d9f50d5f
[wallet] Remove unneeded legacy getbalance code
8 years ago
82b7dc373a
[wallet] Add GetLegacyBalance method to simplify getbalance RPC
...
This adds a simpler new implementation of getbalance logic along with asserts
to confirm it behaves identically to the old logic. The old logic is removed in
the next commit.
8 years ago
1b144495d0
[test] Add Unit Test for GetListenPort
...
Add very basic unit test for GetListenPort in net_tests.cpp
8 years ago
c36ea693ee
[wallet] Make sure pindex is non-null before possibly referencing in LogPrintf call.
8 years ago
5ec883667f
Prevent warning: variable 'x' is uninitialized
8 years ago
93dbb15954
Remove Clang workaround for Boost 1.46
8 years ago
94807be8c6
Trivial: fix fee estimate write error log message
8 years ago
dd07068d6b
Fixed typo in documentation for merkleblock.h
8 years ago
911a4808fb
wallet: Add comment describing the various classes in walletdb.h
8 years ago
f478d98fe4
Fix some empty vector references
...
streams.h has some methods that can be tricked into dereferencing
null pointers or end() iterators. Fix this.
8 years ago
e6756ad335
Switch CCoinsMap from boost to std unordered_map
8 years ago
344a2c4122
Add support for std::unordered_{map,set} to memusage.h
8 years ago
fb463d1717
[qt] Don't call method on null WalletModel object
...
This doesn't crash currently because the method doesn't access any object
members, but this behavior is fragile and incompatible with #10102 .
8 years ago
69d2e9ba67
wallet: Make IsDummy private in CWalletDBWrapper
...
This is only for use in the low-level functions, and CDB is already
a friend class.
8 years ago
33232810dc
wallet: CWalletDB CDB composition not inheritance
...
CWalletDB now contains a CDB instead of inheriting from it.
This makes it easier to replace the internal transaction with a different
database, without leaking through internals.
8 years ago
be9e1a968d
wallet: Reduce references to global bitdb environment
8 years ago
071c95570b
wallet: Get rid of fFileBacked
...
Instead, CWalletDB() with a dummy handle will just give you a no-op
database in which writes always succeeds and reads always fail. CDB
already had functionality for this, so just use that.
8 years ago
71afe3c099
wallet: Introduce database handle wrapper
...
Abstract database handle from explicit strFilename into
CWalletDBWrapper.
Also move CWallet::Backup to db.cpp - as it deals with representation
details this is a database specific operation.
8 years ago
1d31093d4d
fix tsan: utiltime race on nMockTime
8 years ago
321bbc2079
fix ubsan: bitcoin-tx: not initialize context before IsFullyValid
8 years ago
Jimmy Song