6eb67b0ed2
autofile: Disallow by-value copies of CAutoFile
...
One might assume that CAutoFile would be ref-counted so that a copied object
would delay closing the underlying file until all copies have gone out of
scope. Since that's not the case with CAutoFile, explicitly disable copying.
10 years ago
eee030f6bc
autofile: don't copy CAutoFile by value
10 years ago
1e73504865
Fixing C4146 warning
...
Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
10 years ago
d14d7deff0
SanitizeString: allow '(' and ')'
...
'(' and ')' are valid in user agent strings, so should be reported
as such in RPC `getpeerinfo`.
Fixes #4537 .
10 years ago
219372f1dd
script: Fix reference into empty vector run time exception
...
Edit by laanwj: `begin_ptr(sourcedata) + sourcedata.size()` -> `end_ptr(sourcedata)`
10 years ago
ff36cbe8d0
RPC getnetworkinfo: export local node's client sub-version string
10 years ago
e6beedc496
[Qt] add more NULL pointer checks in bitcoingui
...
- add missing checks for clientModel and optionsModel
- small cleanups for an #ifdef on Mac
- remove an unneeded else
10 years ago
cf42c36e99
Apply clang-format on crypto/* and compat/*
10 years ago
cda45b5131
Reinitializing list's begin iterator after few elements were erased from the head
10 years ago
459a2d25e0
Avoiding referencing elements of an empty vector
10 years ago
c8063b5712
Fixing out of bounds asses error
10 years ago
6f3ae9b5df
Fixing out of bounds error in GetKey()
10 years ago
bb26e2c896
[Qt] minor changes in splashscreen.cpp
...
- guard an unused variable with Q_UNUSED() macro
- remove a commented out line of code
10 years ago
c8589bf99e
Add actual signature tests
10 years ago
76ec867796
Use actually valid transactions for script tests
10 years ago
cfc5cfb0f0
qt: Make splash and shutdown window ignore close events
...
It's strange to be able to close these windows while there is work
in progress.
Also set Qt::WA_DeleteOnClose on both windows to make sure that they
are deleted eventually, no matter what happens.
10 years ago
2e5361b9c2
remove code below asserts in limitedmap.h (fixes a ToDo)
10 years ago
87314c1c5e
Fixing improper input syntax and failing bounds check
10 years ago
01c28073ba
Add warning about the merkle-tree algorithm duplicate txid flaw
...
Lots of people read the Bitcoin Core codebase to learn more about
crypto; better to warn about flaws explicitly so they don't blindly copy
the code for other uses and create broken systems.
10 years ago
d6712db354
Also create pid file in non-daemon mode
...
Always make a pid file, not only when `-daemon` specified.
This is useful for troubleshooting, for attaching debuggers and loggers
and such.
- Write the pid file only after the datadir lock was acquired
- Don't create or remove a pid file on WIN32, and also don't show the option
10 years ago
33a27716fc
test: Fix DoS tests after c74332c
...
Fix data structure mismatch ... The mind boggles that they were still passing at all.
10 years ago
6134b43ba9
Fixing condition 'sabotaging' MSVC build
10 years ago
20e01b1a03
Apply clang-format on some infrequently-updated files
10 years ago
018cec7c41
Fixing 'vector out of bounds' issue in base 32 and 64
10 years ago
5e83bc404c
[Qt] include and file header cleanup
...
- alphabetical ordering
- correct ordering own headers before normal headers etc.
10 years ago
a49f11d9ed
qt: Change splash screen to normal window
...
Makes it possible to move, minimize, unminimize the window while
Bitcoin Core is initializing.
10 years ago
93f84d0417
cleanup class private and public areas in walletdb
...
- only code movement
10 years ago
22d7e7014f
prefer const string& over char* in CDB and CWalletDB constructor
...
- also make parameter of CDBEnv::CheckpointLSN a constant reference
10 years ago
c15e483f23
typo fix of booleamn to boolean
10 years ago
ab15b2ec71
Avoid copying undo data
10 years ago
0be990ba34
Move CTxDestination from script/script to script/standard
10 years ago
f4fe205034
add nModSize init to default constructor of CTxMemPoolEntry
10 years ago
1a613963e1
fix missing gettransaction entries in rpcclient
10 years ago
57e1716de6
update rpc help message for gettransaction to add includeWatchonly param
10 years ago
52a5f90360
Create the common location for all m4 autotool build scripts, build-aux/m4.
...
Update .gitignore.
10 years ago
e9992fb645
remove include of chainparams.h
...
chainparams.h has not been used in this cpp file already, consider to remove it for clean.
10 years ago
ee304b6e35
minor changes for help message of getpeerinfo
10 years ago
f7e36370f3
Eliminate extra assignment
10 years ago
ec91092df8
Fixing compiler warning C4101
...
Github-Pull: #4856
10 years ago
611116d4e3
header include cleanup
...
- ensures alphabetical ordering for includes etc. in source file headers
10 years ago
2d79bba36b
cleanup new script files (no code changes)
...
- add missing header end comments
- ensure alphabetical ordering
- update copyright year and license
10 years ago
a65e320747
bitcoin-util-test: Test bitcoin-tx with null scriptPubKey
10 years ago
15ef1b905b
Bugfix: bitcoin-tx: scriptPubKey may be null, so accept outscript=<n>:
10 years ago
6dcfda2dc4
Don't pass nHashType to EvalScript nor CheckSig
10 years ago
2b23a87599
Don't pass nHashType to VerifyScript
10 years ago
ce3649fb61
Remove CScriptCheck::nHashType (was always 0)
10 years ago
358562b651
Remove unused function main:VerifySignature
10 years ago
efad808aae
Avoid reject message feedback loops
10 years ago
aa3c697e90
Store fewer orphan tx by default, add -maxorphantx option
...
There is no reason to store thousands of orphan transactions;
normally an orphan's parents will either be broadcast or
mined reasonably quickly.
This pull drops the maximum number of orphans from 10,000 down
to 100, and adds a command-line option (-maxorphantx) that is
just like -maxorphanblocks to override the default.
10 years ago
c74332c678
Stricter handling of orphan transactions
...
Prevent denial-of-service attacks by banning
peers that send us invalid orphan transactions
and only storing orphan transactions given to
us by a peer while the peer is connected.
10 years ago
Cory Fields