dexX7
506bae3ac9
Return all available information via validateaddress
...
`"validateaddress"` omits some information, even in cases where is it available.
The primary motivation is to be able to retrieve redeemScripts, after using `"addmultisigaddress"`, when not all keys are available in the keystore, but the redeemScript actually is.
The output of `"validateaddress"` with this commit:
Keys not available:
```js
validateaddress "n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3"
{
"isvalid": true,
"address": "n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3",
"scriptPubKey": "76a914fa20d564550b105787f7ce3a9ad7fd9a45cd407088ac",
"ismine": false,
"iswatchonly": false,
"isscript": false
}
```
```js
validateaddress "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK"
{
"isvalid": true,
"address": "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK",
"scriptPubKey": "a9146769c19a16c9400b908756e19a4d2afb9e9760e187",
"ismine": false,
"iswatchonly": false,
"isscript": true
}
```
After adding the redeemScript:
```js
addmultisigaddress 2 '["02537357B156A33306A7A014A3748631C59DF405B56F11BA4AA4A3CE81501AF095","02F1FB200390E7864EF4450C07B15988179A57C3CF3A878F668E1070CB615749FE"]'
2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK
validateaddress "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK"
{
"isvalid": true,
"address": "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK",
"scriptPubKey": "a9146769c19a16c9400b908756e19a4d2afb9e9760e187",
"ismine": false,
"iswatchonly": false,
"isscript": true,
"script": "multisig",
"hex": "522102537357b156a33306a7a014a3748631c59df405b56f11ba4aa4a3ce81501af0952102f1fb200390e7864ef4450c07b15988179a57c3cf3a878f668e1070cb615749fe52ae",
"addresses": [
"n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3",
"mmSKNtbYYHRrhTLKiok5TuYrGEs4Y2A4k6"
],
"sigsrequired": 2,
"account": ""
}
```
All keys available:
```js
validateaddress "n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3"
{
"isvalid": true,
"address": "n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3",
"scriptPubKey": "76a914fa20d564550b105787f7ce3a9ad7fd9a45cd407088ac",
"ismine": true,
"iswatchonly": false,
"isscript": false,
"pubkey": "02537357b156a33306a7a014a3748631c59df405b56f11ba4aa4a3ce81501af095",
"iscompressed": true,
"account": ""
}
```
```js
validateaddress "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK"
{
"isvalid": true,
"address": "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK",
"scriptPubKey": "a9146769c19a16c9400b908756e19a4d2afb9e9760e187",
"ismine": true,
"iswatchonly": false,
"isscript": true,
"script": "multisig",
"hex": "522102537357b156a33306a7a014a3748631c59df405b56f11ba4aa4a3ce81501af0952102f1fb200390e7864ef4450c07b15988179a57c3cf3a878f668e1070cb615749fe52ae",
"addresses": [
"n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3",
"mmSKNtbYYHRrhTLKiok5TuYrGEs4Y2A4k6"
],
"sigsrequired": 2,
"account": ""
}
```
10 years ago
Wladimir J. van der Laan
defa4fc25c
Merge pull request #6249
...
cab580d
gitian: Add petertodd to gitian download scripts (Peter Todd)
10 years ago
Wladimir J. van der Laan
40cfa57279
Merge pull request #6250
...
789b7c3
gitian-downloader: Add prab's key (Paul Rabahy)
10 years ago
Paul Rabahy
789b7c34b8
gitian-downloader: Add prab's key
10 years ago
Peter Todd
cab580d62e
gitian: Add petertodd to gitian download scripts
10 years ago
Wladimir J. van der Laan
55294a9fb6
Merge pull request #6241
...
c946ebe
fix util_tests.cpp clang warnings (Jonas Schnelli)
10 years ago
Wladimir J. van der Laan
606ba62d88
Merge pull request #6232
...
f053bd2
Add erkmos OpenPGP key to gitian downloader keyset (Erik Mossberg)
10 years ago
Jonas Schnelli
c946ebed5e
fix util_tests.cpp clang warnings
...
was introduced with #6121
10 years ago
Wladimir J. van der Laan
12cdbabc26
Merge pull request #6152
...
08d9373
Remove unused code from wallet and validation interface (Michael Ford)
10 years ago
Wladimir J. van der Laan
ab20ae8079
Merge pull request #6238
...
cfc600d
Bugfix: Correct links for Xcode download (Luke Dashjr)
10 years ago
Wladimir J. van der Laan
3fce72eaa3
Merge pull request #6206
...
a9ac95c
use const references where appropriate (Philip Kaufmann)
10 years ago
Wladimir J. van der Laan
d38cd47fe3
Merge pull request #6234
...
ef5fca8
fix rpcmining/getblocktemplate univalue transition logic error (Jonas Schnelli)
10 years ago
Luke Dashjr
cfc600d833
Bugfix: Correct links for Xcode download
10 years ago
Jonas Schnelli
ef5fca8b80
fix rpcmining/getblocktemplate univalue transition logic error
10 years ago
Philip Kaufmann
a9ac95c1bc
use const references where appropriate
10 years ago
Wladimir J. van der Laan
466f0ea0e6
Merge pull request #6121
...
44c7474
univalue: add type check unit tests (Jonas Schnelli)
c023092
univalue: add strict type checking (Wladimir J. van der Laan)
7e98a3c
util: Add ParseInt64 and ParseDouble functions (Wladimir J. van der Laan)
043df2b
Simplify RPCclient, adapt json_parse_error test (Wladimir J. van der Laan)
519eede
fix univalue json parse tests (Jonas Schnelli)
c7fbbc7
fix missing univalue types during constructing (Jonas Schnelli)
8f7e4ab
fix rpc batching univalue issue (Jonas Schnelli)
9a8897f
Remove JSON Spirit wrapper, remove JSON Spirit leftovers (Jonas Schnelli)
3df0411
remove JSON Spirit UniValue wrapper (Jonas Schnelli)
1f263c8
fix rpc unit test, plain numbers are not JSON compatible object (Jonas Schnelli)
e04d9c2
univalue: correct bool support (Jonas Schnelli)
0c5b2cf
univalue: add support for real, fix percision and make it json_spirit compatible (Jonas Schnelli)
21c10de
special threatment for null,true,false because they are non valid json (Jonas Schnelli)
6c7bee0
expicit set UniValue type to avoid empty values (Jonas Schnelli)
53b4671
extend conversion to UniValue (Jonas Schnelli)
15982a8
Convert tree to using univalue. Eliminate all json_spirit uses. (Jeff Garzik)
5e3060c
UniValue: export NullUniValue global constant (Jeff Garzik)
efc7883
UniValue: prefer .size() to .count(), to harmonize w/ existing tree (Jeff Garzik)
10 years ago
Jonas Schnelli
44c7474446
univalue: add type check unit tests
10 years ago
Wladimir J. van der Laan
c02309204b
univalue: add strict type checking
10 years ago
Wladimir J. van der Laan
7e98a3c642
util: Add ParseInt64 and ParseDouble functions
...
Strict parsing functions for other numeric types.
- ParseInt64 analogous to ParseInt32, but for 64-bit values.
- ParseDouble for doubles.
- Make all three Parse* functions more strict (e.g. reject whitespace on
the inside)
Also add tests.
10 years ago
Wladimir J. van der Laan
043df2b568
Simplify RPCclient, adapt json_parse_error test
...
# Conflicts:
# src/test/rpc_tests.cpp
10 years ago
Erik Mossberg
f053bd26a9
Add erkmos OpenPGP key to gitian downloader keyset
10 years ago
Jonas Schnelli
519eedeba7
fix univalue json parse tests
10 years ago
Jonas Schnelli
c7fbbc7e1d
fix missing univalue types during constructing
10 years ago
Jonas Schnelli
8f7e4abbe6
fix rpc batching univalue issue
10 years ago
Jonas Schnelli
9a8897f4ac
Remove JSON Spirit wrapper, remove JSON Spirit leftovers
...
- implement find_value() function for UniValue
- replace all Array/Value/Object types with UniValues, remove JSON Spirit to UniValue wrapper
- remove JSON Spirit sources
10 years ago
Jonas Schnelli
3df0411ad9
remove JSON Spirit UniValue wrapper
10 years ago
Jonas Schnelli
1f263c899e
fix rpc unit test, plain numbers are not JSON compatible object
...
UniValues read() does only read valid json.
10 years ago
Jonas Schnelli
e04d9c25cf
univalue: correct bool support
10 years ago
Jonas Schnelli
0c5b2cf69a
univalue: add support for real, fix percision and make it json_spirit compatible
...
- avoid breaking the API because of different number/percision handling
10 years ago
Jonas Schnelli
21c10de8c2
special threatment for null,true,false because they are non valid json
10 years ago
Jonas Schnelli
6c7bee0624
expicit set UniValue type to avoid empty values
10 years ago
Jonas Schnelli
53b4671a9d
extend conversion to UniValue
10 years ago
Jeff Garzik
15982a8b69
Convert tree to using univalue. Eliminate all json_spirit uses.
10 years ago
Jeff Garzik
5e3060c0d1
UniValue: export NullUniValue global constant
10 years ago
Jeff Garzik
efc7883772
UniValue: prefer .size() to .count(), to harmonize w/ existing tree
10 years ago
Wladimir J. van der Laan
dbd8550231
Merge pull request #6220
...
d648236
bump version in clientversion.h (Philip Kaufmann)
10 years ago
Wladimir J. van der Laan
9d60602444
Merge pull request #5875
...
aa8c827
P2P regression test for new AcceptBlock behavior (Suhas Daftuar)
9be0e68
Be stricter in processing unrequested blocks (Suhas Daftuar)
10 years ago
Wladimir J. van der Laan
9d67b10091
Merge pull request #6218
...
960e994
gitian: Bump cache dir for current master (Cory Fields)
be65628
gitian: bump faketime to something more recent (Cory Fields)
c3cdd7b
osx: set min version to 10.7 for 0.11+ (Cory Fields)
10 years ago
Wladimir J. van der Laan
c7272a50bd
Merge pull request #6226
...
4e157fc
json: fail read_string if string contains trailing garbage (Wladimir J. van der Laan)
10 years ago
Wladimir J. van der Laan
87406aa735
Merge pull request #6214
...
0a32a93
OSX: use "Bitcoin Core" as Bundle Display Name (Jonas Schnelli)
a2241ea
[OSX] revert renaming of Bitcoin-Qt.app (Jonas Schnelli)
10 years ago
Wladimir J. van der Laan
4e157fc60d
json: fail read_string if string contains trailing garbage
...
Change `read_string` to fail when not the entire input has been
consumed. This avoids unexpected, even dangerous behavior (fixes #6223 ).
The new JSON parser adapted in #6121 also solves this problem so in
master this is a temporary fix, but should be backported to older releases.
Also adds tests for the new behavior.
10 years ago
Jonas Schnelli
0a32a9347e
OSX: use "Bitcoin Core" as Bundle Display Name
10 years ago
Suhas Daftuar
aa8c827968
P2P regression test for new AcceptBlock behavior
10 years ago
Suhas Daftuar
9be0e6837b
Be stricter in processing unrequested blocks
...
AcceptBlock will no longer process an unrequested block, unless it has not
been previously processed and has more work than chainActive.Tip()
10 years ago
Philip Kaufmann
d648236d87
bump version in clientversion.h
10 years ago
Cory Fields
960e99404f
gitian: Bump cache dir for current master
...
Do not backport.
10 years ago
Cory Fields
be656283f9
gitian: bump faketime to something more recent
...
This helps in file views where binaries are sorted by time
10 years ago
Cory Fields
c3cdd7b312
osx: set min version to 10.7 for 0.11+
10 years ago
Wladimir J. van der Laan
f00b62391b
Merge pull request #6203
...
d449772
Remove P2SH coinbase flag, no longer interesting (Luke Dashjr)
10 years ago
Wladimir J. van der Laan
0e4f2a0a1f
Merge pull request #6210
...
7fd5b80
build: disable optional use of gmp in internal secp256k1 build (Wladimir J. van der Laan)
10 years ago