John Newbery
4e7e2e16e4
Update RPC argument names
8 years ago
Wladimir J. van der Laan
481f289765
rpc: Named argument support for bitcoin-cli
...
Usage e.g.:
$ src/bitcoin-cli -testnet -named echo arg0="dfdf"
[
"dfdf"
]
Argument conversion also works, for arguments thus flagged in the table in
`src/rpc/client.cpp`.
$ src/bitcoin-cli -testnet -named echojson arg0="[1,2,3]"
[
[
1,
2,
3
]
]
Unknown parameter (detected server-side):
$ src/bitcoin-cli -testnet -named getinfo arg0="dfdf"
error code: -8
error message:
Unknown named parameter arg0
8 years ago
Wladimir J. van der Laan
9adb4e1a59
rpc: Argument name consistency
...
The meaning is clear from the context, and we're inconsistent here.
Also save typing when using named arguments.
- `bitcoinaddress` -> `address`
- `bitcoinprivkey` -> `privkey`
- `bitcoinpubkey` -> `pubkey`
8 years ago
Wladimir J. van der Laan
8d713f761b
rpc: Named arguments for rawtransaction calls
8 years ago
Wladimir J. van der Laan
37a166f146
rpc: Named arguments for wallet calls
8 years ago
Wladimir J. van der Laan
78b684f2ac
rpc: Named arguments for mining calls
8 years ago
Wladimir J. van der Laan
b8ebc595bb
rpc: Named arguments for net calls
...
Also add a more descriptive message for `setnetworkactive`.
8 years ago
Wladimir J. van der Laan
2ca9dcd5b9
test: Add test for RPC named arguments
...
Add RPC testcase for RPC named arguments.
8 years ago
Wladimir J. van der Laan
fba1a6150c
rpc: Named arguments for misc calls
8 years ago
Wladimir J. van der Laan
286ec08cb0
rpc: Add 'echo' call for testing
...
This hidden call simply returns what is passed in.
8 years ago
Wladimir J. van der Laan
495eb44a4f
rpc: Named arguments for blockchain calls
8 years ago
Wladimir J. van der Laan
6f1c76ae14
rpc: Support named arguments
...
The [JSON-RPC specification](http://www.jsonrpc.org/specification ) allows passing parameters as an Array, for by-position
arguments, or an Object, for by-name arguments.
This implements by-name arguments, but preserves full backwards compatibility. API using by-name arguments are
easier to extend, and easier to use (no need to guess which argument goes where).
Named are mapped to positions by a per-call structure, provided through the RPC command table.
Missing arguments will be replaced by null, except if at the end, then the argument is left out completely.
Currently calls fail (though not crash) on intermediate nulls, but this should be improved on a per-call basis later.
8 years ago
Wladimir J. van der Laan
5865d41f88
authproxy: Add support for RPC named arguments
8 years ago
Wladimir J. van der Laan
406f35d99d
Merge #9373 : Linearize script update (hash byte reversal and Python 3 support)
...
3c8f63b
Make linearize scripts Python 3-compatible. (Doug)
d5aa198
Allow linearization scripts to support hash byte reversal (Doug)
8 years ago
Wladimir J. van der Laan
cfe41d7a60
Merge #9387 : [Refactor] RAII of libevent stuff using unique ptrs with deleters
...
05a55a6
Added EVENT_CFLAGS to test makefile to explicitly include libevent headers. (Karl-Johan Alm)
280a559
Added some simple tests for the RAII-style events. (Karl-Johan Alm)
7f7f102
Switched bitcoin-cli.cpp to use RAII unique pointers with deleters. (Karl-Johan Alm)
e5534d2
Added std::unique_ptr<> wrappers with deleters for libevent modules. (Karl-Johan Alm)
8 years ago
Wladimir J. van der Laan
c4b7d4f79c
Merge #9417 : Do not evaluate hidden LogPrint arguments
...
407cdd6
Do not evaluate hidden LogPrint arguments (Pieter Wuille)
8 years ago
Wladimir J. van der Laan
48d7e0d5e4
Merge #9474 : Mark the minconf parameter to move as ignored
...
ce370c1
Mark the minconf parameter to move as ignored (Pieter Wuille)
8 years ago
Wladimir J. van der Laan
7014506415
Merge #9475 : Let autoconf detect presence of EVP_MD_CTX_new
...
0388afe
Let autoconf detect presence of EVP_MD_CTX_new (Luke Dashjr)
8 years ago
Doug
3c8f63ba7c
Make linearize scripts Python 3-compatible.
8 years ago
Doug
d5aa19813c
Allow linearization scripts to support hash byte reversal
...
Currently, the linearization scripts require input hashes to be in one endian form. Add support for byte reversal.
8 years ago
Pieter Wuille
7dac1e5e9e
Merge #9107 : Safer modify new coins
...
b50cd7a
Fix dangerous condition in ModifyNewCoins. (Alex Morcos)
8 years ago
MarcoFalke
0fc1c31a87
Merge #9395 : Add test for -walletrejectlongchains
...
ffeb195
add test for -walletrejectlongchains (Alex Morcos)
8 years ago
Luke Dashjr
0388afe69d
Let autoconf detect presence of EVP_MD_CTX_new
...
Fixes LibreSSL compatibility
8 years ago
Alex Morcos
ffeb1956cb
add test for -walletrejectlongchains
8 years ago
Pieter Wuille
ce370c1811
Mark the minconf parameter to move as ignored
8 years ago
Alex Morcos
b50cd7a67e
Fix dangerous condition in ModifyNewCoins.
...
We were marking coins FRESH before being sure they were not overwriting dirty undo data. This condition was never reached in existing code because undo data was always flushed before UpdateCoins was called with new transactions, but could have been exposed in an otherwise safe refactor.
Clarify in the comments the assumptions made in ModifyNewCoins.
Add ability to undo transactions to UpdateCoins unit test.
Thanks to Russ Yanofsky for suggestion on how to make logic clearer and fixing up the ccoins_modify_new test cases.
8 years ago
Wladimir J. van der Laan
123ea73624
Merge #9457 : [qt] Select more files for translation
...
facf3e7
[qt] `make translate` (MarcoFalke)
fae26e8
[qt] Add more sources to translate (MarcoFalke)
8 years ago
MarcoFalke
df1ab5b4d6
Merge #9470 : qt: Set (count) placeholder in sendcoinsdialog to notranslate
...
388ea19
qt: Set (count) placeholder in sendcoinsdialog to notranslate (Wladimir J. van der Laan)
8 years ago
Wladimir J. van der Laan
388ea19bf2
qt: Set (count) placeholder in sendcoinsdialog to notranslate
8 years ago
MarcoFalke
5bc3b6cede
Merge #9467 : [Trivial] [Doc] Install Protobuf v3 on OS X
...
35ee63c
[Doc] Install Protobuf v3 on OS X (fanquake)
8 years ago
MarcoFalke
c2ea1e6561
Merge #9401 : Make rpcauth help message clearer, add example in example .conf
...
0513c70
Make rpcauth help message clearer, add example in example .conf (Gregory Sanders)
8 years ago
Wladimir J. van der Laan
d65a13b773
Merge #9396 : Updated listsinceblock rpc documentation
...
3f67972
updated listsinceblock rpc docs (accraze)
8 years ago
Wladimir J. van der Laan
1ce7ede2a9
Merge #9288 : Fix a bug if the min fee is 0 for FeeFilterRounder
...
f8d43b8
Avoid rollingMinimumFeeRate never being able to decay below half (Alex Morcos)
eab8e1b
fix a bug if the min fee is 0 for FeeFilterRounder (Alex Morcos)
8 years ago
Wladimir J. van der Laan
869781c51c
Merge #9283 : A few more CTransactionRef optimizations
...
91335ba
Remove unused MakeTransactionRef overloads (Pieter Wuille)
6713f0f
Make FillBlock consume txn_available to avoid shared_ptr copies (Pieter Wuille)
62607d7
Convert COrphanTx to keep a CTransactionRef (Pieter Wuille)
c44e4c4
Make AcceptToMemoryPool take CTransactionRef (Pieter Wuille)
8 years ago
Wladimir J. van der Laan
d9ae1cefa0
Merge #9289 : net: drop boost::thread_group
...
67ee4ec
net: misc header cleanups (Cory Fields)
8b3159e
net: make proxy receives interruptible (Cory Fields)
5cb0fce
net: remove thread_interrupted catch (Cory Fields)
d3d7056
net: make net processing interruptible (Cory Fields)
0985052
net: make net interruptible (Cory Fields)
799df91
net: add CThreadInterrupt and InterruptibleSleep (Cory Fields)
7325b15
net: a few small cleanups before replacing boost threads (Cory Fields)
8 years ago
MarcoFalke
facf3e7608
[qt] `make translate`
8 years ago
MarcoFalke
fae26e8dfc
[qt] Add more sources to translate
8 years ago
Wladimir J. van der Laan
c0ddd32bf6
Merge #9450 : Increment MIT licence copyright header year on files modified in 2016
...
27765b6
Increment MIT Licence copyright header year on files modified in 2016 (isle2983)
8 years ago
Karl-Johan Alm
05a55a639b
Added EVENT_CFLAGS to test makefile to explicitly include libevent headers.
8 years ago
fanquake
35ee63c565
[Doc] Install Protobuf v3 on OS X
8 years ago
Wladimir J. van der Laan
649cf5fe89
Merge #9462 : [qt] Do not translate tilde character
...
fab6c5f
[qt] Do not translate `~` (MarcoFalke)
8 years ago
Cory Fields
67ee4ec901
net: misc header cleanups
8 years ago
Cory Fields
8b3159ef0a
net: make proxy receives interruptible
8 years ago
Cory Fields
5cb0fcee81
net: remove thread_interrupted catch
...
This is now a std::thread, so there's no hope of catching a boost interruption
point.
8 years ago
Cory Fields
d3d7056d2a
net: make net processing interruptible
8 years ago
Cory Fields
0985052319
net: make net interruptible
...
Also now that net threads are interruptible, switch them to use std
threads/binds/mutexes/condvars.
8 years ago
Cory Fields
799df9115f
net: add CThreadInterrupt and InterruptibleSleep
8 years ago
Cory Fields
7325b15566
net: a few small cleanups before replacing boost threads
...
- Drop the interruption point directly after the pnode allocation. This would
be leaky if hit.
- Rearrange thread creation so that the socket handler comes first
8 years ago
Pieter Wuille
2a524b8e8f
Merge #8776 : Wallet refactoring leading up to multiwallet
...
5394b39
Wallet: Split main logic from InitLoadWallet into CreateWalletFromFile (Luke Dashjr)
fb0c934
Wallet: Let the interval-flushing thread figure out the filename (Luke Dashjr)
8 years ago
Pieter Wuille
ce5c1f4aca
Merge #9252 : Release cs_main before calling ProcessNewBlock, or processing headers (cmpctblock handling)
...
bd02bdd
Release cs_main before processing cmpctblock as header (Suhas Daftuar)
680b0c0
Release cs_main before calling ProcessNewBlock (cmpctblock handling) (Suhas Daftuar)
8 years ago