Wladimir J. van der Laan
239e8ce958
Merge #8740 : net: No longer send local address in addrMe
...
d9c99c3
net: No longer send local address in addrMe (Wladimir J. van der Laan)
8 years ago
MarcoFalke
1e5799c525
Merge #8713 : [qa] create_cache: Delete temp dir when done
...
fa27d99
[qa] create_cache: Delete temp dir when done (MarcoFalke)
8 years ago
Wladimir J. van der Laan
d9c99c3058
net: No longer send local address in addrMe
...
After #8594 the addrFrom sent by a node is not used anymore at all,
so don't bother sending it.
Also mitigates the privacy issue in (#8616 ). It doesn't completely solve
the issue as GetLocalAddress is also called in AdvertiseLocal, but at
least when advertising addresses it stands out less as *our* address.
8 years ago
MarcoFalke
a82e5d8220
Merge #8714 : [qa] gitignore: Remove unused lines
...
1111ddb
gitignore: Remove unused lines (MarcoFalke)
8 years ago
Wladimir J. van der Laan
881d7eaf29
Merge #8715 : net: only delete CConnman if it's been created
...
36fa01f
net: only delete CConnman if it's been created (Cory Fields)
8 years ago
Jonas Schnelli
57b34599b2
Merge #8712 : Remove maxuploadtargets recommended minimum
...
1b6bcdd
Remove maxuploadtargets recommended minimum (Jonas Schnelli)
8 years ago
Cory Fields
36fa01f217
net: only delete CConnman if it's been created
...
In the case of (for example) an already-running bitcoind, the shutdown sequence
begins before CConnman has been created, leading to a null-pointer dereference
when g_connman->Stop() is called.
Instead, Just let the CConnman dtor take care of stopping.
8 years ago
MarcoFalke
1111ddb9e5
gitignore: Remove unused lines
8 years ago
MarcoFalke
fa27d990ee
[qa] create_cache: Delete temp dir when done
8 years ago
Jonas Schnelli
1b6bcdd3aa
Remove maxuploadtargets recommended minimum
8 years ago
Wladimir J. van der Laan
fa7caf6d91
Merge #8693 : add witness address to address book
...
62ffbbd
add witness address to address book (instagibbs)
8 years ago
Wladimir J. van der Laan
c9914c2094
Merge #8699 : Remove createwitnessaddress RPC command
...
86c3f8d
Remove createwitnessaddress (Johnson Lau)
8 years ago
MarcoFalke
7fe6c5c993
Merge #8652 : [qa]: remove root test directory for RPC tests
...
c62cc4e
fix path for bak file (whythat)
438e94d
remove root test directory for RPC tests (whythat)
8 years ago
Wladimir J. van der Laan
37ac67816a
Merge #8601 : Add option to opt into full-RBF when sending funds (rebase, original by petertodd)
...
86726d8
Rename `-optintofullrbf` option to `-walletrbf` (Wladimir J. van der Laan)
05fa823
wallet: Add BIP125 comment for MAXINT-1/-2 behavior (Wladimir J. van der Laan)
152f45b
Add option to opt into full-RBF when sending funds (Peter Todd)
8 years ago
Wladimir J. van der Laan
86726d8680
Rename `-optintofullrbf` option to `-walletrbf`
...
This makes it clear that this is a wallet option.
8 years ago
Wladimir J. van der Laan
39ac1ec642
Merge #8697 : fix op order to append first alert
...
1d635ae
fix op order to append first alert (rodasmith)
8 years ago
Wladimir J. van der Laan
2562152441
Merge #8662 : Update btcdrak signing key
...
46606af
Update btcdrak signing key (BtcDrak)
8 years ago
Wladimir J. van der Laan
4ced5de71d
Merge #8528 : Update p2p-segwit.py to reflect correct behavior
...
5547aeb
p2psegwit.py transaction is rejected due to premature witness not size (instagibbs)
bc1d1f2
Update p2p-segwit.py to reflect correct AskFor behavior (instagibbs)
8 years ago
Wladimir J. van der Laan
7e9ab9555c
Merge #8608 : Install manpages via make install, also add some autogenerated manpages
...
d19583f
improved gen-manpages.sh, includes bitcoin-tx and strips commit tag, now also runs binaries from build dir by default, added variables for more control (nomnombtc)
09546ca
regenerated all manpages with commit tag stripped, also add bitcoin-tx (nomnombtc)
ae6e754
change help string --enable-man to --disable-man (nomnombtc)
a32c102
add conditional for --enable-man, default is yes (nomnombtc)
dc84b6f
add doc/man to subdir if configure flag --enable-man is set (nomnombtc)
00dba72
add doc/man/Makefile.am to include manpages (nomnombtc)
eb5643b
add autogenerated manpages by help2man (nomnombtc)
6edf2fd
add gen-manpages.sh description to README.md (nomnombtc)
d2cd9c0
add script to generate manpages with help2man (nomnombtc)
8 years ago
Johnson Lau
86c3f8db0b
Remove createwitnessaddress
...
This RPC command is unsafe as it will return an address even if the script is invalid.
8 years ago
rodasmith
1d635ae61b
fix op order to append first alert
8 years ago
MarcoFalke
2a0836f6d5
Merge #8667 : Fix SIGHASH_SINGLE bug in test_framework SignatureHash
...
2f2548d
Fix SIGHASH_SINGLE bug in test_framework SignatureHash (Johnson Lau)
8 years ago
instagibbs
62ffbbdec3
add witness address to address book
8 years ago
Jonas Schnelli
702e6e059b
Merge #8678 : [Qt][CoinControl] fix UI bug that could result in paying unexpected fee
...
0480293
[Qt][CoinControl] fix UI bug that could result in paying unexpected fee (Jonas Schnelli)
8 years ago
Pieter Wuille
6898213409
Merge #8681 : Performance Regression Fix: Pre-Allocate txChanged vector
...
ec81881
Performance Regression Fix: Pre-Allocate txChanged vector (Jeremy Rubin)
8 years ago
Wladimir J. van der Laan
2abfe5956e
Merge #8664 : Fix segwit-related wallet bug
...
c40b034
Clear witness with vin/vout in CWallet::CreateTransaction() (Suhas Daftuar)
8 years ago
Wladimir J. van der Laan
6423116741
Merge #8085 : p2p: Begin encapsulation
...
0103c5b
net: move MAX_FEELER_CONNECTIONS into connman (Cory Fields)
e700cd0
Convert ForEachNode* functions to take a templated function argument rather than a std::function to eliminate std::function overhead (Jeremy Rubin)
d1a2295
Made the ForEachNode* functions in src/net.cpp more pragmatic and self documenting (Jeremy Rubin)
98591c5
net: move vNodesDisconnected into CConnman (Cory Fields)
fa2f8bc
net: add nSendBufferMaxSize/nReceiveFloodSize to CConnection::Options (Cory Fields)
a19553b
net: Introduce CConnection::Options to avoid passing so many params (Cory Fields)
bafa5fc
net: Drop StartNode/StopNode and use CConnman directly (Cory Fields)
e81a602
net: pass CClientUIInterface into CConnman (Cory Fields)
f60b905
net: Pass best block known height into CConnman (Cory Fields)
fdf69ff
net: move max/max-outbound to CConnman (Cory Fields)
8a59369
net: move semOutbound to CConnman (Cory Fields)
bd72937
net: move nLocalServices/nRelevantServices to CConnman (Cory Fields)
be9c796
net: move SendBufferSize/ReceiveFloodSize to CConnman (Cory Fields)
63cafa6
net: move send/recv statistics to CConnman (Cory Fields)
adf5d4c
net: SocketSendData returns written size (Cory Fields)
ee44fa9
net: move messageHandlerCondition to CConnman (Cory Fields)
960cf2e
net: move nLocalHostNonce to CConnman (Cory Fields)
551e088
net: move nLastNodeId to CConnman (Cory Fields)
6c19d92
net: move whitelist functions into CConnman (Cory Fields)
53347f0
net: create generic functor accessors and move vNodes to CConnman (Cory Fields)
c0569c7
net: Add most functions needed for vNodes to CConnman (Cory Fields)
8ae2dac
net: move added node functions to CConnman (Cory Fields)
502dd3a
net: Add oneshot functions to CConnman (Cory Fields)
a0f3d3c
net: move ban and addrman functions into CConnman (Cory Fields)
aaf018e
net: handle nodesignals in CConnman (Cory Fields)
b1a5f43
net: move OpenNetworkConnection into CConnman (Cory Fields)
02137f1
net: Move socket binding into CConnman (Cory Fields)
5b446dd
net: Pass CConnection to wallet rather than using the global (Cory Fields)
8d58c4d
net: Pass CConnman around as needed (Cory Fields)
d7349ca
net: Add rpc error for missing/disabled p2p functionality (Cory Fields)
cd16f48
net: Create CConnman to encapsulate p2p connections (Cory Fields)
d93b14d
net: move CBanDB and CAddrDB out of net.h/cpp (Cory Fields)
531214f
gui: add NodeID to the peer table (Cory Fields)
8 years ago
Wladimir J. van der Laan
4daf02a03f
Merge #8677 : Do not shadow upper local variable 'send', prevent -Wshadow compiler warning.
...
125b946
Do not shadow upper local variable 'send', prevent -Wshadow compiler warning. (Pavel Janík)
8 years ago
Wladimir J. van der Laan
7f8b677aeb
Merge #8563 : Add configure check for -latomic
...
878faac
Add configure check for -latomic (Anthony Towns)
8 years ago
Wladimir J. van der Laan
666eaf03cf
Merge #8680 : Address Travis spurious failures
...
d6a5dc4
add waitfornewblock/waitforblock/waitforblockheight rpcs and use them for tests (Cory Fields)
8 years ago
Wladimir J. van der Laan
80a4f21d37
Merge #8525 : Do not store witness txn in rejection cache
...
ca10a03
Add basic test for IsStandard witness transaction blinding (instagibbs)
34521e4
Do not store witness txn in rejection cache (Pieter Wuille)
8 years ago
Wladimir J. van der Laan
17347d6a59
Merge #8683 : fix incorrect file name bitcoin.qrc
...
df2d2e7
update name of file bitcoin.qrc (Gaurav Rana)
8 years ago
Cory Fields
0103c5b90f
net: move MAX_FEELER_CONNECTIONS into connman
8 years ago
Jeremy Rubin
e700cd0bc8
Convert ForEachNode* functions to take a templated function argument rather than a std::function to eliminate std::function overhead
8 years ago
Jeremy Rubin
d1a2295f0d
Made the ForEachNode* functions in src/net.cpp more pragmatic and self documenting
8 years ago
Cory Fields
98591c5027
net: move vNodesDisconnected into CConnman
8 years ago
Cory Fields
fa2f8bc47f
net: add nSendBufferMaxSize/nReceiveFloodSize to CConnection::Options
8 years ago
Cory Fields
a19553b992
net: Introduce CConnection::Options to avoid passing so many params
8 years ago
Cory Fields
bafa5fc5a1
net: Drop StartNode/StopNode and use CConnman directly
8 years ago
Cory Fields
e81a602cf0
net: pass CClientUIInterface into CConnman
8 years ago
Cory Fields
f60b9059e4
net: Pass best block known height into CConnman
...
CConnman then passes the current best height into CNode at creation time.
This way CConnman/CNode have no dependency on main for height, and the signals
only move in one direction.
This also helps to prevent identity leakage a tiny bit. Before this change, an
attacker could theoretically make 2 connections on different interfaces. They
would connect fully on one, and only establish the initial connection on the
other. Once they receive a new block, they would relay it to your first
connection, and immediately commence the version handshake on the second. Since
the new block height is reflected immediately, they could attempt to learn
whether the two connections were correlated.
This is, of course, incredibly unlikely to work due to the small timings
involved and receipt from other senders. But it doesn't hurt to lock-in
nBestHeight at the time of connection, rather than letting the remote choose
the time.
8 years ago
Cory Fields
fdf69ff21a
net: move max/max-outbound to CConnman
8 years ago
Cory Fields
8a593694b1
net: move semOutbound to CConnman
8 years ago
Cory Fields
bd72937dc4
net: move nLocalServices/nRelevantServices to CConnman
...
These are in-turn passed to CNode at connection time. This allows us to offer
different services to different peers (or test the effects of doing so).
8 years ago
Cory Fields
be9c796dc5
net: move SendBufferSize/ReceiveFloodSize to CConnman
8 years ago
Cory Fields
63cafa6329
net: move send/recv statistics to CConnman
8 years ago
Cory Fields
adf5d4c2e4
net: SocketSendData returns written size
8 years ago
Cory Fields
ee44fa9576
net: move messageHandlerCondition to CConnman
8 years ago
Cory Fields
960cf2e405
net: move nLocalHostNonce to CConnman
...
This behavior seems to have been quite racy and broken.
Move nLocalHostNonce into CNode, and check received nonces against all
non-fully-connected nodes. If there's a match, assume we've connected
to ourself.
8 years ago
Cory Fields
551e0887db
net: move nLastNodeId to CConnman
8 years ago