1090502c3e
Fix superfluous cast and code style nits in RPC wallet-hd.py test
8 years ago
58e148333e
CKeyPool avoid "catch (...)" in SerializationOp
8 years ago
e138876f0a
Only show keypoolsize_hd_internal if HD split is enabled
8 years ago
add38d9b83
GetOldestKeyPoolTime: if HD & HD Chain Split is enabled, response max(oldest-internal-key, oldest-external-key)
8 years ago
dd526c2a2d
Don't switch to HD-chain-split during wallet encryption of non HD-chain-split wallets
8 years ago
79df9df348
Switch to 100% for the HD internal keypool size
8 years ago
bcafca1077
Make sure we always generate one keypool key at minimum
8 years ago
d0a627a53a
Fix issue where CDataStream->nVersion was taken a CKeyPool record version
8 years ago
9af8f00a75
Make sure we hand out keypool keys if HD_SPLIT is not enabled
8 years ago
469a47b760
Make sure ReserveKeyFromKeyPool only hands out internal keys if HD_SPLIT is supported
8 years ago
05a9b493eb
Fix wrong keypool internal size in RPC getwalletinfo help
8 years ago
01de822c8d
Removed redundant IsLocked() check in NewKeyPool()
8 years ago
d59531ddfc
Immediately return setKeyPool's size if HD or HD_SPLIT is disabled or not supported
8 years ago
02592f4c5e
[Wallet] split the keypool in an internal and external part
8 years ago
a230b05887
Merge #9701 : Make bumpfee tests less fragile
...
f85ac540b94e491dfd64fe6b296394b528b
8 years ago
dfef6b6af0
Merge #10047 : [tests] Remove unused variables and imports
...
389745972163d4
8 years ago
3568b30ca3
Merge #9500 : [Qt][RPC] Autocomplete commands for 'help' command in debug console
...
6d8fe35
8 years ago
7b585cf70e
Merge #9558 : Clarify assumptions made about when BlockCheck is called
...
c4a6929
8 years ago
86f7d5b69b
Merge #10029 : Fix parameter naming inconsistencies between .h and .cpp files
...
97b8213
8 years ago
389745901a
[tests] Remove unused variables
8 years ago
72163d4585
[tests] Remove unused and duplicate imports
8 years ago
02d64bd929
Merge #10017 : combine_logs.py - aggregates log files from multiple bitcoinds during functional tests.
...
8317a4561d75f5
8 years ago
90586b6897
Merge #10045 : [trivial] Fix typos in comments
...
dbf30ff
8 years ago
8317a45161
Python functional tests should log in UTC
...
bitcoind logs use UTC. Python functional tests should also log in UTC.
8 years ago
61d75f587d
Introduce combine_logs.py to combine log files from multiple bitcoinds.
...
This commit adds a tool for combining log files from multiple instances
of bitcoinds as well as the test_framework.log file. This gives a
combined view of what the test framework and all bitcoin instances were
doing during a qa test.
8 years ago
dbf30ff10f
[trivial] Fix typos in comments
8 years ago
f85ac54e24
[qa] Expand bumpfee test docstring
8 years ago
919aaf6508
Merge #10039 : Fix compile errors with Qt 5.3.2 and Boost 1.55.0
...
b5bec4ed5046e7
8 years ago
0b94e49831
[qa] Rename python input variable to tx_input
...
input() is actually the name of a python built in function
8 years ago
1dfd64fadc
[qa] Make bumpfee.py test function order consistent
...
Run bumpfee tests in top-down order, now that the test fragility is fixed, and
they can actually run in order.
8 years ago
e6b2963241
[qa] Get rid of nondeterminism in bumpfee.py
...
Change bumpfee tests to use the spend_one_input function instead of the
create_fund_sign_send function. The latter function would choose transaction
inputs and fees in unpredictable ways depending on the order that tests ran,
which meant that adding new tests could cause old tests to fail, and in general
made bumpfee.py fragile and unpleasant to work with.
8 years ago
94b528bb0c
[qa] Remove bumpfee.py get_change_address hack
8 years ago
3192e5278a
Merge #9956 : Reorganise qa directory
...
63d66ba5b0bff4a9bd622c28ee9100902c4
8 years ago
0c17afcbe7
Merge #9734 : Add updating of chainTxData to release process
...
41b8821
8 years ago
b5bec4e330
Avoid QTimer::singleShot compile error with Qt 5.3.2
...
Construct QTimer object directly, instead of relying on QTimer::singleShot
overloads accepting lambdas, which weren't introduced until Qt 5.4.
Avoids the following compile error in debian jessie:
```
qt/test/wallettests.cpp: In function ‘void {anonymous}::ConfirmSend()’:
qt/test/wallettests.cpp:34:6: error: no matching function for call to ‘QTimer::singleShot(int, Qt::TimerType, {anonymous}::ConfirmSend()::<lambda()>)’
});
^
qt/test/wallettests.cpp:34:6: note: candidates are:
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/QTimer:1:0,
from ./qt/sendcoinsdialog.h:13,
from qt/test/wallettests.cpp:7:
/usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:81:17: note: static void QTimer::singleShot(int, const QObject*, const char*)
static void singleShot(int msec, const QObject *receiver, const char *member);
^
/usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:81:17: note: no known conversion for argument 2 from ‘Qt::TimerType’ to ‘const QObject*’
/usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:82:17: note: static void QTimer::singleShot(int, Qt::TimerType, const QObject*, const char*)
static void singleShot(int msec, Qt::TimerType timerType, const QObject *receiver, const char *member);
^
/usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:82:17: note: candidate expects 4 arguments, 3 provided
```
Error reported by Pavel Janík <Pavel@Janik.cz> in
https://github.com/bitcoin/bitcoin/pull/9974#issuecomment-287574436
8 years ago
d5046e72f4
Avoid scoped_connection compile error with boost 1.55.0
...
Construct scoped_connection directly instead of relying on copy initialization
and move constructor. Avoids the following compile error in debian jessie:
```
In file included from /usr/include/boost/signals2/signal.hpp:21:0,
from ./util.h:29,
from ./dbwrapper.h:11,
from ./txdb.h:10,
from ./test/test_bitcoin.h:11,
from qt/test/wallettests.cpp:11:
/usr/include/boost/signals2/connection.hpp: In function ‘uint256 {anonymous}::SendCoins(CWallet&, SendCoinsDialog&, const CBitcoinAddress&, CAmount)’:
/usr/include/boost/signals2/connection.hpp:234:7: error: ‘boost::signals2::scoped_connection::scoped_connection(const boost::signals2::scoped_connection&)’ is private
scoped_connection(const scoped_connection &other);
^
qt/test/wallettests.cpp:47:6: error: within this context
});
^
```
Error reported by Pavel Janík <Pavel@Janik.cz> in
https://github.com/bitcoin/bitcoin/pull/9974#issuecomment-287550034
8 years ago
63d66ba20a
Move src/test/bitcoin-util-test.py to test/util/bitcoin-util-test.py
8 years ago
5b0bff4581
Rename --enable-extended-rpc-tests to --enable-extended-functional-tests
8 years ago
a9bd622a65
Rename test/pull-tester/rpc-tests.py to test/functional/test_runner.py
8 years ago
c28ee91db0
Rename rpc-tests directory to functional
8 years ago
00902c48cd
Rename qa directory to test
8 years ago
d34995a7ba
Merge #10038 : Add mallocinfo mode to `getmemoryinfo` RPC
...
e141aa4
8 years ago
7c7ddd9ead
Merge #10037 : Trivial: Fix typo in help getrawtransaction RPC
...
05a9f22
8 years ago
e141aa4ba6
Add mallocinfo mode to `getmemoryinfo` RPC
...
This adds a mode argument to `getmemoryinfo`. By default the output
will remain the same. However if a mode argument of `mallocinfo` is
provided the result of glibc `malloc_info` (if available) will
be returned as a string, as-is.
This is useful for tracking heap usage over time or troubleshooting
memory fragmentation issues.
8 years ago
05a9f22358
Trivial: Fix typo in help getrawtransaction RPC
8 years ago
5c1a958124
Merge #10027 : Set to nullptr after delete
...
d93b97f
8 years ago
97b8213674
Fix parameter naming inconsistencies between .h and .cpp files
...
Inconsistencies prior to this commit:
* serializeFlags vs serialFlags
src/core_io.h:std::string EncodeHexTx(const CTransaction& tx, const int serializeFlags = 0);
src/core_write.cpp:std::string EncodeHexTx(const CTransaction& tx, const int serialFlags)
* statusOut vs outStatus
src/rpc/server.h:bool RPCIsInWarmup(std::string *statusOut);
src/rpc/server.cpp:bool RPCIsInWarmup(std::string *outStatus)
* hashesToUpdate vs vHashesToUpdate
src/txmempool.h: void UpdateTransactionsFromBlock(const std::vector<uint256> &hashesToUpdate);
src/txmempool.cpp:void CTxMemPool::UpdateTransactionsFromBlock(const std::vector<uint256> &vHashesToUpdate)
* nPruneUpToHeight vs nManualPruneHeight
src/validation.h:void PruneBlockFilesManual(int nPruneUpToHeight);
src/validation.cpp:void PruneBlockFilesManual(int nManualPruneHeight);
8 years ago
10b930dde8
Merge #10033 : Trivial: Fix typo in key.h comment
...
f490dae
8 years ago
9225de2cf6
Merge #10024 : [trivial] Use log.info() instead of print() in remaining functional test cases.
...
e7227771f70653
8 years ago
f490dae56b
Trivial: Fix typo in key.h comment
8 years ago
Jonas Schnelli