Browse Source

Prevent TestNodeCLI.args mixups

Change TestNodeCLI.__call__() to return a new instance instead of modifying the
existing instance. This way, it's possible to create different cli objects that
have their own options (for example -rpcwallet options to connect to different
wallets), and options set for a single call (`node.cli(options).method(args)`)
will no longer leak into future calls.
0.16
Russell Yanofsky 7 years ago committed by John Newbery
parent
commit
ca9085afc5
  1. 7
      test/functional/test_framework/test_node.py

7
test/functional/test_framework/test_node.py

@ -203,9 +203,10 @@ class TestNodeCLI(): @@ -203,9 +203,10 @@ class TestNodeCLI():
def __call__(self, *args, input=None):
# TestNodeCLI is callable with bitcoin-cli command-line args
self.args = [str(arg) for arg in args]
self.input = input
return self
cli = TestNodeCLI(self.binary, self.datadir)
cli.args = [str(arg) for arg in args]
cli.input = input
return cli
def __getattr__(self, command):
def dispatcher(*args, **kwargs):

Loading…
Cancel
Save