Browse Source

Remove "conflicted" as transaction category.

We were losing information about sent/received by overriding the
category in case of a conflicted transaction.

Hence, remove the "conflicted" category.

Conflicted status of a transaction can still be determined by looking
for confirmations<0.
0.10
Wladimir J. van der Laan 11 years ago
parent
commit
b96f6a77f8
  1. 6
      src/rpcwallet.cpp

6
src/rpcwallet.cpp

@ -1114,9 +1114,6 @@ void ListTransactions(const CWalletTx& wtx, const string& strAccount, int nMinDe
Object entry; Object entry;
entry.push_back(Pair("account", strSentAccount)); entry.push_back(Pair("account", strSentAccount));
MaybePushAddress(entry, s.first); MaybePushAddress(entry, s.first);
if (wtx.GetDepthInMainChain() < 0)
entry.push_back(Pair("category", "conflicted"));
else
entry.push_back(Pair("category", "send")); entry.push_back(Pair("category", "send"));
entry.push_back(Pair("amount", ValueFromAmount(-s.second))); entry.push_back(Pair("amount", ValueFromAmount(-s.second)));
entry.push_back(Pair("fee", ValueFromAmount(-nFee))); entry.push_back(Pair("fee", ValueFromAmount(-nFee)));
@ -1150,9 +1147,6 @@ void ListTransactions(const CWalletTx& wtx, const string& strAccount, int nMinDe
} }
else else
{ {
if (wtx.GetDepthInMainChain() < 0)
entry.push_back(Pair("category", "conflicted"));
else
entry.push_back(Pair("category", "receive")); entry.push_back(Pair("category", "receive"));
} }
entry.push_back(Pair("amount", ValueFromAmount(r.second))); entry.push_back(Pair("amount", ValueFromAmount(r.second)));

Loading…
Cancel
Save