Browse Source

qa: Treat mininode p2p exceptions as fatal

0.16
Suhas Daftuar 7 years ago
parent
commit
a7820422e0
  1. 6
      test/functional/test_framework/mininode.py

6
test/functional/test_framework/mininode.py

@ -1502,6 +1502,7 @@ class NodeConnCB(object):
except: except:
print("ERROR delivering %s (%s)" % (repr(message), print("ERROR delivering %s (%s)" % (repr(message),
sys.exc_info()[0])) sys.exc_info()[0]))
raise
def get_deliver_sleep_time(self): def get_deliver_sleep_time(self):
with mininode_lock: with mininode_lock:
@ -1701,13 +1702,10 @@ class NodeConn(asyncore.dispatcher):
self.cb.on_close(self) self.cb.on_close(self)
def handle_read(self): def handle_read(self):
try:
t = self.recv(8192) t = self.recv(8192)
if len(t) > 0: if len(t) > 0:
self.recvbuf += t self.recvbuf += t
self.got_data() self.got_data()
except:
pass
def readable(self): def readable(self):
return True return True
@ -1773,8 +1771,10 @@ class NodeConn(asyncore.dispatcher):
self.got_message(t) self.got_message(t)
else: else:
logger.warning("Received unknown command from %s:%d: '%s' %s" % (self.dstaddr, self.dstport, command, repr(msg))) logger.warning("Received unknown command from %s:%d: '%s' %s" % (self.dstaddr, self.dstport, command, repr(msg)))
raise ValueError("Unknown command: '%s'" % (command))
except Exception as e: except Exception as e:
logger.exception('got_data:', repr(e)) logger.exception('got_data:', repr(e))
raise
def send_message(self, message, pushbuf=False): def send_message(self, message, pushbuf=False):
if self.state != "connected" and not pushbuf: if self.state != "connected" and not pushbuf:

Loading…
Cancel
Save