Browse Source

rpc: Input-from-stdin mode for bitcoin-cli

Implements #7442 by adding an option `-stdin` which reads
additional arguments from stdin, one per line.

For example

```bash
echo -e "mysecretcode\n120" | src/bitcoin-cli -stdin walletpassphrase
echo -e "walletpassphrase\nmysecretcode\n120" | src/bitcoin-cli -stdin
```
0.13
Wladimir J. van der Laan 9 years ago
parent
commit
92bcca37ab
  1. 21
      src/bitcoin-cli.cpp

21
src/bitcoin-cli.cpp

@ -43,6 +43,7 @@ std::string HelpMessageCli()
strUsage += HelpMessageOpt("-rpcuser=<user>", _("Username for JSON-RPC connections")); strUsage += HelpMessageOpt("-rpcuser=<user>", _("Username for JSON-RPC connections"));
strUsage += HelpMessageOpt("-rpcpassword=<pw>", _("Password for JSON-RPC connections")); strUsage += HelpMessageOpt("-rpcpassword=<pw>", _("Password for JSON-RPC connections"));
strUsage += HelpMessageOpt("-rpcclienttimeout=<n>", strprintf(_("Timeout during HTTP requests (default: %d)"), DEFAULT_HTTP_CLIENT_TIMEOUT)); strUsage += HelpMessageOpt("-rpcclienttimeout=<n>", strprintf(_("Timeout during HTTP requests (default: %d)"), DEFAULT_HTTP_CLIENT_TIMEOUT));
strUsage += HelpMessageOpt("-stdin", _("Read extra arguments from standard input, one per line until EOF/Ctrl-D (recommended for sensitive information such as passphrases)"));
return strUsage; return strUsage;
} }
@ -232,15 +233,17 @@ int CommandLineRPC(int argc, char *argv[])
argc--; argc--;
argv++; argv++;
} }
std::vector<std::string> args = std::vector<std::string>(&argv[1], &argv[argc]);
// Method if (GetBoolArg("-stdin", false)) {
if (argc < 2) // Read one arg per line from stdin and append
throw runtime_error("too few parameters"); std::string line;
string strMethod = argv[1]; while (std::getline(std::cin,line))
args.push_back(line);
// Parameters default to strings }
std::vector<std::string> strParams(&argv[2], &argv[argc]); if (args.size() < 1)
UniValue params = RPCConvertValues(strMethod, strParams); throw runtime_error("too few parameters (need at least command)");
std::string strMethod = args[0];
UniValue params = RPCConvertValues(strMethod, std::vector<std::string>(args.begin()+1, args.end()));
// Execute and handle connection failures with -rpcwait // Execute and handle connection failures with -rpcwait
const bool fWait = GetBoolArg("-rpcwait", false); const bool fWait = GetBoolArg("-rpcwait", false);

Loading…
Cancel
Save