Browse Source

Better error message for fundrawtransaction w/ empty vout

Previously this case failed deep in Cwallet::CreateTransaction() with
the error message "Transaction amounts must be positive"
0.13
Peter Todd 9 years ago
parent
commit
10953a7d32
No known key found for this signature in database
GPG Key ID: C085F21CE7F4B9DC
  1. 3
      src/wallet/rpcwallet.cpp

3
src/wallet/rpcwallet.cpp

@ -2418,6 +2418,9 @@ UniValue fundrawtransaction(const UniValue& params, bool fHelp)
if (!DecodeHexTx(origTx, params[0].get_str())) if (!DecodeHexTx(origTx, params[0].get_str()))
throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed"); throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed");
if (origTx.vout.size() == 0)
throw JSONRPCError(RPC_INVALID_PARAMETER, "TX must have at least one output");
bool includeWatching = false; bool includeWatching = false;
if (params.size() > 1) if (params.size() > 1)
includeWatching = params[1].get_bool(); includeWatching = params[1].get_bool();

Loading…
Cancel
Save