de7d62c128
Clean up code
5 years ago
103e2b9398
Use non-recursive mutex
...
The related classes doesn't really need recursive mutex so drop it. And
if it is really required it usually indicates bad design and we should
avoid it anyway.
5 years ago
58fa5e004f
Improve "stats updated" signal handling in MainWindow class
5 years ago
72faf89e26
Use the same internal data type for conversion function
5 years ago
418164bee4
Move "torrent status report" functionality out of Session class
5 years ago
9968eb53b2
Remove unused signal
5 years ago
8bbed461a6
Sort signal declarations in Session class
5 years ago
c7ac96c4f5
Add ability to trigger action via keypad Enter
5 years ago
4a71b78e2d
Group related code together
...
And also rename local variables.
5 years ago
2152a81d11
Add ability to open file via keypad Enter
...
Closes #11260 .
5 years ago
ed62854af7
Add TriStateBool constructor taking a boolean
...
And move the constructor taking an int to private.
5 years ago
ecc3ff3ca4
WebUI: fix escaping of HTML special characters
...
JS code for torrent general properties, files, peers, trackers inconsistently
escaped HTML special characters, then the dynamicTable inconsistently escaped
again and then the value was set to HTML element text or html properties.
To fix this mess, don't escape any property values in the prop-*.js files.
Instead, make dynamicTable set HTML element text instead of html property by
default. This behavior can be overridden by setting a custom updateTd
function on the respective column, if needed. This is where the HTML escaping
should be done.
Also reordered existing updateTd functions to match column order, changed
custom updateTd functions from setting html to text property wherever possible,
removed custom updateTd functions that turned out to be redundant.
5 years ago
82276b2a99
Rename variable
5 years ago
e3b9659fb8
Fix seeding failed after creating a new torrent
...
Closes #11252 .
5 years ago
4d00435209
Improve error messages for url_seed_alert
...
Closes #10119 .
5 years ago
fccbc5318a
Drop logging level to warning for web seed errors
5 years ago
bab953298b
Escape HTML in comment field
5 years ago
f1243871b0
Remove redundant HTML escaping
...
The text widget is already set to plaintext and doing HTML escaping will
not give us more security but only makes it harder to read.
5 years ago
9804a2e06a
Fix typo
5 years ago
1439bcc864
Move JavaScript code into explicit namespaces
...
This cleans up the global namespace by explicitly exporting shared values. All html and JavaScript files have been converted to use explicit exports except for client.js and mocha-init.js
5 years ago
cf6e721b00
Allow to retry fetching RSS feeds
5 years ago
73ef69526d
Allow to cancel download request
5 years ago
edcc74c1ae
Add option to align file to piece boundary when creating new torrent
...
Alignment is achieved by adding dummy pad files between files which is
handled by libtorrent.
Closes #10460 .
5 years ago
5e1e983928
Handle "alerts dropped" alert from libtorrent
5 years ago
0a959bcbe7
Clean up SettingsStorage::save()
...
Also it should return `true` when `m_dirty` is `false`.
5 years ago
e7e5ee1ea2
Add const to TransactionalSettings class functions
5 years ago
daf52a2610
Avoid double lookups
5 years ago
7113174593
Treat .magnet file extension as case insensitive
...
Closes #11200 .
5 years ago
17e4902519
Don't define variable when not building GUI
5 years ago
0d5b0b9542
Replace deprecated macro
...
Q_OS_MAC is deprecated and the replacement is Q_OS_MACOS.
5 years ago
9dc3b18178
Fix filename validation on non-Windows OS
...
Closes #11191 .
5 years ago
2396ef5bd6
Move error logging of adding peers to the proper place
5 years ago
3104291734
Add check for null pointer
...
Fix up d657c87243
5 years ago
60994df8d0
Conditionally disable port input field
...
Disable port input when "Use different port on each startup" option is selected.
This follows the behavior in GUI.
5 years ago
2a66bb3127
Construct QHostAddress more efficiently
5 years ago
f42b10f3b6
Remove max character limit of location path
...
I removed the maxlength attribute because we couldn't modify the location path when it has more than 100 characters.
5 years ago
4aab44e779
Always save info dict when saving fastresume
...
Otherwise torrents loaded from fastresume won't have it and needs
to redownload it from elsewhere and slowing down the startup process.
This is also required for the future where we will drop loading the
`info` dict from .torrent files.
5 years ago
d657c87243
Fix unable to remove web seeds
...
As suggested in post [1] we don't need to assign the `ti` field anymore when fastresme
already contains the `info` dict.
[1]: https://github.com/arvidn/libtorrent/issues/3946#issuecomment-523300003
5 years ago
7e0daf1663
Setup pixmap cache in a proper place
...
There is no need to reset the cache limit to previous value as
QPixmapCache is an application wide cache.
Also raise the cache size to 64MB.
5 years ago
47b9d8dbc6
Clean up Application class constructor
5 years ago
eb784b0d2e
Move "Check for program updates" checkbox out of Advanced settings
5 years ago
b921d96f4b
Use Q_ASSERT() to check invariants
5 years ago
72d1d5d2dd
Cut down number of signal emits
5 years ago
60df790b82
Initialize pointers
...
Fixup aeabd2d625
5 years ago
09503b58fa
Clean up loadTorrentResumeData()
5 years ago
f3ce76110b
Simplify code
...
Instead of using dict_find_list() now we use the simpler dict_find()
since we are going to check its validness anyway.
5 years ago
3a11c23efd
Fix wrong "added on" date
...
This only happens for magnet links when its metadata has yet to be retrieved.
Closes #11124 .
5 years ago
0891cd4878
Avoid unecessary copying the parameter
...
Using forwarding reference here so that we won't get unnecessary copies
of the parameter passed to `slot`, for example a lambda function.
5 years ago
aeabd2d625
Clean up PeerListWidget class
5 years ago
8d0d8e4dcb
Improve embedded tracker
...
Now it conforms to BEPs more closely.
5 years ago
Chocobo1