d4708/qBittorrent
1
0
Fork 0
mirror of https://github.com/d47081/qBittorrent.git synced 2025-03-09 20:01:08 +00:00
Code Issues Projects Releases Wiki Activity

Clean up SettingsStorage::save()

Browse Source 
Also it should return `true` when `m_dirty` is `false`.
This commit is contained in:
Chocobo1 2019-09-08 14:40:18 +08:00
parent e7e5ee1ea2
commit 0a959bcbe7
No known key found for this signature in database
GPG Key ID: 210D9C873253A68C
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/base/settingsstorage.cpp
View File

@ -186,18 +186,18 @@ SettingsStorage *SettingsStorage::instance()
bool SettingsStorage::save()
{
if (!m_dirty) return false; // Obtaining the lock is expensive, let's check early
const QWriteLocker locker(&m_lock);
if (!m_dirty) return false; // something might have changed while we were getting the lock
if (!m_dirty) return true; // Obtaining the lock is expensive, let's check early
const QWriteLocker locker(&m_lock); // to guard for `m_dirty`
if (!m_dirty) return true; // something might have changed while we were getting the lock
const TransactionalSettings settings(QLatin1String("qBittorrent"));
if (settings.write(m_data)) {
m_dirty = false;
return true;
if (!settings.write(m_data)) {
m_timer.start();
return false;
}
m_timer.start();
return false;
m_dirty = false;
return true;
}
QVariant SettingsStorage::loadValue(const QString &key, const QVariant &defaultValue) const