Browse Source

Merge pull request #13439 from FranciscoPombal/clazy_fixes_2

Clazy fixes
adaptive-webui-19844
Vladimir Golovnev 4 years ago committed by GitHub
parent
commit
cf93fe124d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 7
      src/app/cmdoptions.cpp
  2. 2
      src/base/bittorrent/tracker.cpp

7
src/app/cmdoptions.cpp

@ -160,7 +160,7 @@ namespace
return Utils::String::unquote(parts[1], QLatin1String("'\"")); return Utils::String::unquote(parts[1], QLatin1String("'\""));
throw CommandLineParameterError(QObject::tr("Parameter '%1' must follow syntax '%1=%2'", throw CommandLineParameterError(QObject::tr("Parameter '%1' must follow syntax '%1=%2'",
"e.g. Parameter '--webui-port' must follow syntax '--webui-port=value'") "e.g. Parameter '--webui-port' must follow syntax '--webui-port=value'")
.arg(fullParameter()).arg(QLatin1String("<value>"))); .arg(fullParameter(), QLatin1String("<value>")));
} }
QString value(const QProcessEnvironment &env, const QString &defaultValue = {}) const QString value(const QProcessEnvironment &env, const QString &defaultValue = {}) const
@ -206,7 +206,7 @@ namespace
if (!ok) if (!ok)
throw CommandLineParameterError(QObject::tr("Parameter '%1' must follow syntax '%1=%2'", throw CommandLineParameterError(QObject::tr("Parameter '%1' must follow syntax '%1=%2'",
"e.g. Parameter '--webui-port' must follow syntax '--webui-port=<value>'") "e.g. Parameter '--webui-port' must follow syntax '--webui-port=<value>'")
.arg(fullParameter()).arg(QLatin1String("<integer value>"))); .arg(fullParameter(), QLatin1String("<integer value>")));
return res; return res;
} }
@ -274,8 +274,7 @@ namespace
throw CommandLineParameterError(QObject::tr("Parameter '%1' must follow syntax '%1=%2'", throw CommandLineParameterError(QObject::tr("Parameter '%1' must follow syntax '%1=%2'",
"e.g. Parameter '--add-paused' must follow syntax " "e.g. Parameter '--add-paused' must follow syntax "
"'--add-paused=<true|false>'") "'--add-paused=<true|false>'")
.arg(fullParameter()) .arg(fullParameter(), QLatin1String("<true|false>")));
.arg(QLatin1String("<true|false>")));
} }
TriStateBool value(const QProcessEnvironment &env) const TriStateBool value(const QProcessEnvironment &env) const

2
src/base/bittorrent/tracker.cpp

@ -238,7 +238,7 @@ Http::Response Tracker::processRequest(const Http::Request &request, const Http:
if (request.method != Http::HEADER_REQUEST_METHOD_GET) if (request.method != Http::HEADER_REQUEST_METHOD_GET)
throw MethodNotAllowedHTTPError(); throw MethodNotAllowedHTTPError();
if (request.path.toLower().startsWith(ANNOUNCE_REQUEST_PATH)) if (request.path.startsWith(ANNOUNCE_REQUEST_PATH, Qt::CaseInsensitive))
processAnnounceRequest(); processAnnounceRequest();
else else
throw NotFoundHTTPError(); throw NotFoundHTTPError();

Loading…
Cancel
Save