- Fixed a bug when deleting a torrent from finished list (just introduced)

src/FinishedTorrents.cpp

@@ -178,7 +178,7 @@ void FinishedTorrents::updateFinishedList(){
     if(h.state() == torrent_status::downloading || (h.state() != torrent_status::checking_files && h.state() != torrent_status::queued_for_checking && h.progress() < 1.)) {
       // What are you doing here? go back to download tab!
       qDebug("Info: a torrent was moved from finished to download tab");
-      deleteFromFinishedList(hash);
+      deleteFromFinishedList(hash, true);
       BTSession->setFinishedTorrent(hash);
       emit torrentMovedFromFinishedList(h);
       continue;
@@ -200,13 +200,14 @@ int FinishedTorrents::getRowFromHash(QString hash) const{
 }
 
 // Will move it to download tab
-void FinishedTorrents::deleteFromFinishedList(QString hash){
+void FinishedTorrents::deleteFromFinishedList(QString hash, bool switchTab){
   int row = getRowFromHash(hash);
   Q_ASSERT(row != -1);
   finishedListModel->removeRow(row);
   QFile::remove(misc::qBittorrentPath()+"BT_backup"+QDir::separator()+hash+".finished");
   --nbFinished;
   ((GUI*)parent)->setTabText(1, tr("Finished") +" ("+QString::fromUtf8(misc::toString(nbFinished).c_str())+")");
+  if(switchTab)
     BTSession->setUnfinishedTorrent(hash);
 }
 

src/FinishedTorrents.h

@@ -53,7 +53,7 @@ class FinishedTorrents : public QWidget, public Ui::seeding{
   public slots:
     void addFinishedTorrent(QString hash);
     void updateFinishedList();
-    void deleteFromFinishedList(QString hash);
+    void deleteFromFinishedList(QString hash, bool switchTab=false);
     void showProperties(const QModelIndex &index);
     void propertiesSelection();
     void displayFinishedListMenu(const QPoint&);

src/GUI.cpp

@@ -554,6 +554,10 @@ void GUI::updateDlList(bool force) {
   QString hash;
   foreach(hash, unfinishedTorrents) {
     QTorrentHandle h = BTSession->getTorrentHandle(hash);
+    if(!h.is_valid()){
+      qDebug("We have an invalid handle for: %s", qPrintable(hash));
+      continue;
+    }
     try{
       QString hash = h.hash();
       int row = getRowFromHash(hash);
@@ -1027,7 +1031,7 @@ void GUI::on_actionDelete_Permanently_triggered() {
           --nbTorrents;
           tabs->setTabText(0, tr("Downloads") +QString::fromUtf8(" (")+misc::toQString(nbTorrents)+QString::fromUtf8(")"));
         } else {
-          finishedTorrentTab->deleteFromFinishedList(hash);
+          finishedTorrentTab->deleteFromFinishedList(hash, false);
         }
           // Update info bar
           setInfoBar(tr("'%1' was removed permanently.", "'xxx.avi' was removed permanently.").arg(fileName));
@@ -1102,7 +1106,7 @@ void GUI::on_actionDelete_triggered() {
           --nbTorrents;
           tabs->setTabText(0, tr("Downloads") +QString::fromUtf8(" (")+misc::toQString(nbTorrents)+QString::fromUtf8(")"));
         } else {
-          finishedTorrentTab->deleteFromFinishedList(hash);
+          finishedTorrentTab->deleteFromFinishedList(hash, false);
         }
         // Update info bar
         setInfoBar(tr("'%1' was removed.", "'xxx.avi' was removed.").arg(fileName));