Browse Source

Use the correct character encoding for exceptions coming from libtorrent.

adaptive-webui-19844
sledgehammer999 10 years ago
parent
commit
9b71e4ffc9
  1. 2
      src/addnewtorrentdialog.cpp
  2. 2
      src/properties/propertieswidget.cpp
  3. 6
      src/qtlibtorrent/qbtsession.cpp
  4. 3
      src/torrentcreator/torrentcreatorthread.cpp
  5. 6
      src/webui/btjson.cpp

2
src/addnewtorrentdialog.cpp

@ -193,7 +193,7 @@ bool AddNewTorrentDialog::loadTorrent(const QString& torrent_path, const QString
m_torrentInfo = new torrent_info(fsutils::toNativePath(m_filePath).toUtf8().data()); m_torrentInfo = new torrent_info(fsutils::toNativePath(m_filePath).toUtf8().data());
m_hash = misc::toQString(m_torrentInfo->info_hash()); m_hash = misc::toQString(m_torrentInfo->info_hash());
} catch(const std::exception& e) { } catch(const std::exception& e) {
MessageBoxRaised::critical(0, tr("Invalid torrent"), tr("Failed to load the torrent: %1").arg(e.what())); MessageBoxRaised::critical(0, tr("Invalid torrent"), tr("Failed to load the torrent: %1").arg(misc::toQStringU(e.what())));
return false; return false;
} }

2
src/properties/propertieswidget.cpp

@ -395,7 +395,7 @@ void PropertiesWidget::loadDynamicData() {
} }
} }
} catch(const invalid_handle& e) { } catch(const invalid_handle& e) {
qWarning() << "Caught exception in PropertiesWidget::loadDynamicData(): " << e.what(); qWarning() << "Caught exception in PropertiesWidget::loadDynamicData(): " << misc::toQStringU(e.what());
} }
} }

6
src/qtlibtorrent/qbtsession.cpp

@ -1074,7 +1074,7 @@ QTorrentHandle QBtSession::addTorrent(QString path, bool fromScanDir, QString fr
} catch(std::exception& e) { } catch(std::exception& e) {
if (!from_url.isNull()) { if (!from_url.isNull()) {
addConsoleMessage(tr("Unable to decode torrent file: '%1'", "e.g: Unable to decode torrent file: '/home/y/xxx.torrent'").arg(from_url), QString::fromUtf8("red")); addConsoleMessage(tr("Unable to decode torrent file: '%1'", "e.g: Unable to decode torrent file: '/home/y/xxx.torrent'").arg(from_url), QString::fromUtf8("red"));
addConsoleMessage(misc::toQString(e.what()), "red"); addConsoleMessage(misc::toQStringU(e.what()), "red");
//emit invalidTorrent(from_url); //emit invalidTorrent(from_url);
fsutils::forceRemove(path); fsutils::forceRemove(path);
}else{ }else{
@ -1565,7 +1565,7 @@ void QBtSession::enableDHT(bool b) {
} }
catch(std::exception &e) { catch(std::exception &e) {
qDebug("Could not enable DHT, reason: %s", e.what()); qDebug("Could not enable DHT, reason: %s", e.what());
addConsoleMessage(tr("DHT support [OFF]. Reason: %1").arg(misc::toQString(e.what())), QString::fromUtf8("red")); addConsoleMessage(tr("DHT support [OFF]. Reason: %1").arg(misc::toQStringU(e.what())), QString::fromUtf8("red"));
} }
} }
} }
@ -2201,7 +2201,7 @@ void QBtSession::handleAlert(libtorrent::alert* a) {
break; break;
} }
} catch (const std::exception& e) { } catch (const std::exception& e) {
qWarning() << "Caught exception in readAlerts(): " << e.what(); qWarning() << "Caught exception in readAlerts(): " << misc::toQStringU(e.what());
} }
} }

3
src/torrentcreator/torrentcreatorthread.cpp

@ -42,6 +42,7 @@
#include "torrentcreatorthread.h" #include "torrentcreatorthread.h"
#include "fs_utils.h" #include "fs_utils.h"
#include "misc.h"
#include <boost/bind.hpp> #include <boost/bind.hpp>
#include <iostream> #include <iostream>
@ -136,6 +137,6 @@ void TorrentCreatorThread::run() {
emit updateProgress(100); emit updateProgress(100);
emit creationSuccess(save_path, parent_path); emit creationSuccess(save_path, parent_path);
} catch (std::exception& e) { } catch (std::exception& e) {
emit creationFailure(QString::fromLocal8Bit(e.what())); emit creationFailure(misc::toQStringU(e.what()));
} }
} }

6
src/webui/btjson.cpp

@ -256,7 +256,7 @@ QByteArray btjson::getTrackersForTorrent(const QString& hash)
tracker_list.append(tracker_dict); tracker_list.append(tracker_dict);
} }
} catch(const std::exception& e) { } catch(const std::exception& e) {
qWarning() << Q_FUNC_INFO << "Invalid torrent: " << e.what(); qWarning() << Q_FUNC_INFO << "Invalid torrent: " << misc::toQStringU(e.what());
return QByteArray(); return QByteArray();
} }
@ -312,7 +312,7 @@ QByteArray btjson::getPropertiesForTorrent(const QString& hash)
const qreal ratio = QBtSession::instance()->getRealRatio(status); const qreal ratio = QBtSession::instance()->getRealRatio(status);
data[KEY_PROP_RATIO] = ratio > 100. ? QString::fromUtf8("") : misc::accurateDoubleToString(ratio, 1, false); data[KEY_PROP_RATIO] = ratio > 100. ? QString::fromUtf8("") : misc::accurateDoubleToString(ratio, 1, false);
} catch(const std::exception& e) { } catch(const std::exception& e) {
qWarning() << Q_FUNC_INFO << "Invalid torrent: " << e.what(); qWarning() << Q_FUNC_INFO << "Invalid torrent: " << misc::toQStringU(e.what());
return QByteArray(); return QByteArray();
} }
@ -357,7 +357,7 @@ QByteArray btjson::getFilesForTorrent(const QString& hash)
file_list.append(file_dict); file_list.append(file_dict);
} }
} catch (const std::exception& e) { } catch (const std::exception& e) {
qWarning() << Q_FUNC_INFO << "Invalid torrent: " << e.what(); qWarning() << Q_FUNC_INFO << "Invalid torrent: " << misc::toQStringU(e.what());
return QByteArray(); return QByteArray();
} }

Loading…
Cancel
Save