Use .each(). Refactor conditionals.

7 years ago · 69af205094
1 changed files with 5 additions and 10 deletions
--- a/src/webui/www/private/scripts/dynamicTable.js
+++ b/src/webui/www/private/scripts/dynamicTable.js
@ -489,19 +489,14 @@ var DynamicTable = new Class({
				@@ -489,19 +489,14 @@ var DynamicTable = new Class({
        },

        selectRow : function (rowId) {
-            this.selectedRows.empty();
+            this.deselectAll();
            this.selectedRows.push(rowId);
-            var trs = this.tableBody.getElements('tr');
-            for (var i = 0; i < trs.length; i++) {
-                var tr = trs[i];
-                if (tr.rowId == rowId) {
-                    if (!tr.hasClass('selected'))
+            this.tableBody.getElements('tr').each(function(tr) {
+                if (tr.rowId == rowId)
                    tr.addClass('selected');
-                }
                else
-                if (tr.hasClass('selected'))
                    tr.removeClass('selected');
-            }
+            });
            this.onSelectedRowChanged();
        },