Browse Source

Fix stuck in wrong torrent state

Before this patch, adding the torrent in
https://github.com/qbittorrent/qBittorrent/issues/11511 and the torrrent
state will stay in torrent_status::checking_resume_data forever.
This is not the correct state since the `torrent_status.errc` field is
non-zero and this commit fixes it.
adaptive-webui-19844
Chocobo1 5 years ago
parent
commit
2ca70cf6cc
No known key found for this signature in database
GPG Key ID: 210D9C873253A68C
  1. 4
      src/base/bittorrent/session.cpp
  2. 14
      src/base/bittorrent/torrenthandle.cpp

4
src/base/bittorrent/session.cpp

@ -4188,6 +4188,10 @@ void Session::createTorrentHandle(const lt::torrent_handle &nativeHandle) @@ -4188,6 +4188,10 @@ void Session::createTorrentHandle(const lt::torrent_handle &nativeHandle)
// Send new torrent signal
if (!params.restored)
emit torrentNew(torrent);
// Torrent could have error just after adding to libtorrent
if (torrent->hasError())
LogMsg(tr("Torrent errored. Torrent: \"%1\". Error: %2.").arg(torrent->name(), torrent->error()), Log::WARNING);
}
void Session::handleAddTorrentAlert(const lt::add_torrent_alert *p)

14
src/base/bittorrent/torrenthandle.cpp

@ -899,7 +899,10 @@ TorrentState TorrentHandle::state() const @@ -899,7 +899,10 @@ TorrentState TorrentHandle::state() const
void TorrentHandle::updateState()
{
if (m_nativeStatus.state == lt::torrent_status::checking_resume_data) {
if (hasError()) {
m_state = TorrentState::Error;
}
else if (m_nativeStatus.state == lt::torrent_status::checking_resume_data) {
m_state = TorrentState::CheckingResumeData;
}
else if (isMoveInProgress()) {
@ -908,8 +911,6 @@ void TorrentHandle::updateState() @@ -908,8 +911,6 @@ void TorrentHandle::updateState()
else if (isPaused()) {
if (hasMissingFiles())
m_state = TorrentState::MissingFiles;
else if (hasError())
m_state = TorrentState::Error;
else
m_state = isSeed() ? TorrentState::PausedUploading : TorrentState::PausedDownloading;
}
@ -961,12 +962,7 @@ bool TorrentHandle::hasMissingFiles() const @@ -961,12 +962,7 @@ bool TorrentHandle::hasMissingFiles() const
bool TorrentHandle::hasError() const
{
#if (LIBTORRENT_VERSION_NUM < 10200)
return (m_nativeStatus.paused && m_nativeStatus.errc);
#else
return ((m_nativeStatus.flags & lt::torrent_flags::paused)
&& m_nativeStatus.errc);
#endif
return static_cast<bool>(m_nativeStatus.errc);
}
bool TorrentHandle::hasFilteredPieces() const

Loading…
Cancel
Save