Browse Source

SMTP: Fix edge case where nothing was sent when no authentication was needed. Relates to #1845.

adaptive-webui-19844
sledgehammer999 10 years ago
parent
commit
2a5393cf53
  1. 8
      src/smtp.cpp

8
src/smtp.cpp

@ -397,6 +397,10 @@ void Smtp::authenticate()
// Skip authentication // Skip authentication
qDebug() << "Skipping authentication..."; qDebug() << "Skipping authentication...";
state = Authenticated; state = Authenticated;
// At this point the server will not send any response
// So fill the buffer with a fake one to pass the tests
// in readyRead()
buffer.push_front("250 QBT FAKE RESPONSE\r\n");
return; return;
} }
// AUTH extension is supported, check which // AUTH extension is supported, check which
@ -420,6 +424,10 @@ void Smtp::authenticate()
"we support [CRAM-MD5|PLAIN|LOGIN], skipping authentication, " "we support [CRAM-MD5|PLAIN|LOGIN], skipping authentication, "
"knowing it is likely to fail... Server Auth Modes: "+auth.join("|")); "knowing it is likely to fail... Server Auth Modes: "+auth.join("|"));
state = Authenticated; state = Authenticated;
// At this point the server will not send any response
// So fill the buffer with a fake one to pass the tests
// in readyRead()
buffer.push_front("250 QBT FAKE RESPONSE\r\n");
} }
} }

Loading…
Cancel
Save