Clean up code

src/gui/transferlistfilterswidget.cpp

@@ -66,11 +66,8 @@ namespace
 
     QString getScheme(const QString &tracker)
     {
-        const QUrl url {tracker};
+        const QString scheme = QUrl(tracker).scheme();
-        QString scheme = url.scheme();
+        return !scheme.isEmpty() ? scheme : u"http"_qs;
-        if (scheme.isEmpty())
-            scheme = u"http"_qs;
-        return scheme;
     }
 
     QString getHost(const QString &tracker)
@@ -360,7 +357,6 @@ void StatusFilterWidget::torrentAboutToBeDeleted(BitTorrent::Torrent *const torr
 
 TrackerFiltersList::TrackerFiltersList(QWidget *parent, TransferListWidget *transferList, const bool downloadFavicon)
     : BaseFilterWidget(parent, transferList)
-    , m_totalTorrents(0)
     , m_downloadTrackerFavicon(downloadFavicon)
 {
     auto *allTrackers = new QListWidgetItem(this);

src/gui/transferlistfilterswidget.h

@@ -157,12 +157,12 @@ private:
         QListWidgetItem *item = nullptr;
     };
 
-    QHash<QString, TrackerData> m_trackers;
+    QHash<QString, TrackerData> m_trackers;   // <tracker host, tracker data>
     QHash<BitTorrent::TorrentID, QSet<QString>> m_errors;  // <torrent ID, tracker hosts>
     QHash<BitTorrent::TorrentID, QSet<QString>> m_warnings;  // <torrent ID, tracker hosts>
     PathList m_iconPaths;
-    int m_totalTorrents;
+    int m_totalTorrents = 0;
-    bool m_downloadTrackerFavicon;
+    bool m_downloadTrackerFavicon = false;
 };
 
 class TransferListFiltersWidget final : public QFrame