engine: get rid of MSG_BigShort, use htons instead, since network headers are always included

engine/client/cl_game.c

@@ -3377,7 +3377,7 @@ void GAME_EXPORT NetAPI_SendRequest( int context, int request, int flags, double
 
 		// make sure that port is specified
 		if( !nr->resp.remote_address.port )
-			nr->resp.remote_address.port = MSG_BigShort( PORT_MASTER );
+			nr->resp.remote_address.port = htons( PORT_MASTER );
 
 		// grab the list from the master server
 		Q_strcpy( &fullquery[22], GI->gamefolder );

engine/client/cl_main.c

@@ -1006,7 +1006,7 @@ void CL_SendConnectPacket( void )
 		return;
 	}
 
-	if( adr.port == 0 ) adr.port = MSG_BigShort( PORT_SERVER );
+	if( adr.port == 0 ) adr.port = htons( PORT_SERVER );
 	qport = Cvar_VariableString( "net_qport" );
 	key = ID_GetMD5();
 
@@ -1134,7 +1134,7 @@ void CL_CheckForResend( void )
 		return;
 	}
 
-	if( adr.port == 0 ) adr.port = MSG_BigShort( PORT_SERVER );
+	if( adr.port == 0 ) adr.port = htons( PORT_SERVER );
 
 	if( cls.connect_retry == CL_TEST_RETRIES_NORESPONCE )
 	{
@@ -1321,7 +1321,7 @@ void CL_Rcon_f( void )
 		}
 
 		NET_StringToAdr( rcon_address->string, &to );
-		if( to.port == 0 ) to.port = MSG_BigShort( PORT_SERVER );
+		if( to.port == 0 ) to.port = htons( PORT_SERVER );
 	}
 
 	NET_SendPacket( NS_CLIENT, Q_strlen( message ) + 1, message, to );
@@ -1563,7 +1563,7 @@ void CL_LocalServers_f( void )
 
 	// send a broadcast packet
 	adr.type = NA_BROADCAST;
-	adr.port = MSG_BigShort( PORT_SERVER );
+	adr.port = htons( PORT_SERVER );
 	Netchan_OutOfBandPrint( NS_CLIENT, adr, "info %i", PROTOCOL_VERSION );
 
 	adr.type = NA_MULTICAST_IP6;

engine/common/net_buffer.c

@@ -89,11 +89,6 @@ const char *svc_strings[svc_lastmsg+1] =
 	"svc_exec",
 };
 
-unsigned short MSG_BigShort( unsigned short swap )
-{
-	return (swap >> 8)|(swap << 8);
-}
-
 void MSG_InitMasks( void )
 {
 	uint	startbit, endbit;

engine/common/net_buffer.h

@@ -63,7 +63,6 @@ void MSG_ExciseBits( sizebuf_t *sb, int startbit, int bitstoremove );
 _inline int MSG_TellBit( sizebuf_t *sb ) { return sb->iCurBit; }
 _inline const char *MSG_GetName( sizebuf_t *sb ) { return sb->pDebugName; }
 qboolean MSG_CheckOverflow( sizebuf_t *sb );
-unsigned short MSG_BigShort( unsigned short swap );
 
 // init writing
 void MSG_StartWriting( sizebuf_t *sb, void *pData, int nBytes, int iStartBit, int nBits );