Browse Source

update actions

CPP-GTK4
yggverse 3 months ago
parent
commit
d63ba8f1ad
  1. 67
      src/app/browser.cpp
  2. 2
      src/app/browser/header/menu.cpp
  3. 26
      src/app/browser/main.cpp
  4. 2
      src/app/browser/main.hpp
  5. 15
      src/app/browser/main/tab.cpp
  6. 14
      src/app/browser/main/tab.hpp
  7. 17
      src/app/browser/main/tab/page.cpp
  8. 1
      src/app/browser/main/tab/page.hpp
  9. 2
      src/app/browser/main/tab/page/navigation/request.cpp
  10. 2
      src/app/browser/main/tab/page/navigation/update.cpp
  11. 16
      src/main.cpp

67
src/app/browser.cpp

@ -32,24 +32,43 @@ Browser::Browser( @@ -32,24 +32,43 @@ Browser::Browser(
* browserMain
);
// Init actions
// Init browser window actions
add_action(
"main_tab_append",
"refresh",
[this]
{
browserMain->tab_append();
browserMain->refresh();
browserHeader->set_title(
browserMain->get_current_tab_page_title()
);
browserHeader->set_subtitle(
browserMain->get_current_tab_page_subtitle()
);
}
);
add_action(
"main_tab_page_update",
"debug",
[this]
{
browserMain->tab_update();
// @TODO https://gitlab.gnome.org/GNOME/gtkmm/-/commit/5f3b82537d3daad7bda59dd01e719788070f4b6c
gtk_window_set_interactive_debugging(
true
);
}
);
// Tab actions
add_action(
"main_tab_append",
[this]
{
browserMain->tab_append();
}
);
// Close
add_action(
"main_tab_close",
[this]
@ -58,7 +77,6 @@ Browser::Browser( @@ -58,7 +77,6 @@ Browser::Browser(
}
);
// Close submenu
add_action(
"main_tab_close_left",
[this]
@ -83,49 +101,28 @@ Browser::Browser( @@ -83,49 +101,28 @@ Browser::Browser(
}
);
// History
add_action(
"main_tab_page_navigation_history_try_back",
[this]
{
browserMain->tab_page_navigation_history_try_back();
}
);
// Tab page navigation actions
add_action(
"main_tab_page_navigation_history_try_forward",
"main_tab_page_navigation_update",
[this]
{
browserMain->tab_page_navigation_history_try_forward();
browserMain->tab_page_update();
}
);
// Tool
add_action(
"debug",
"main_tab_page_navigation_history_try_back",
[this]
{
// @TODO https://gitlab.gnome.org/GNOME/gtkmm/-/commit/5f3b82537d3daad7bda59dd01e719788070f4b6c
gtk_window_set_interactive_debugging(
true
);
browserMain->tab_page_navigation_history_try_back();
}
);
// Hidden
add_action(
"refresh",
"main_tab_page_navigation_history_try_forward",
[this]
{
browserMain->refresh();
browserHeader->set_title(
browserMain->get_current_tab_page_title()
);
browserHeader->set_subtitle(
browserMain->get_current_tab_page_subtitle()
);
browserMain->tab_page_navigation_history_try_forward();
}
);
}

2
src/app/browser/header/menu.cpp

@ -96,7 +96,7 @@ Glib::RefPtr<Gio::Menu> Menu::main_tab_page_navigation( @@ -96,7 +96,7 @@ Glib::RefPtr<Gio::Menu> Menu::main_tab_page_navigation(
menu->append(
_("Update"),
"win.main_tab_page_update"
"win.main_tab_page_navigation_update"
);
return menu;

26
src/app/browser/main.cpp

@ -38,17 +38,17 @@ Glib::ustring Main::get_current_tab_page_subtitle() @@ -38,17 +38,17 @@ Glib::ustring Main::get_current_tab_page_subtitle()
};
// Actions
void Main::tab_append()
void Main::refresh()
{
mainTab->append(
_("New page")
mainTab->refresh(
mainTab->get_current_page()
);
};
void Main::tab_update()
void Main::tab_append()
{
mainTab->update(
mainTab->get_current_page()
mainTab->append(
_("New page")
);
};
@ -74,6 +74,13 @@ void Main::tab_close_all() @@ -74,6 +74,13 @@ void Main::tab_close_all()
mainTab->close_all();
};
void Main::tab_page_update()
{
mainTab->page_update(
mainTab->get_current_page()
);
};
bool Main::tab_page_navigation_history_try_back()
{
const int & PAGE_NUMBER = mainTab->get_current_page();
@ -103,10 +110,3 @@ bool Main::tab_page_navigation_history_try_forward() @@ -103,10 +110,3 @@ bool Main::tab_page_navigation_history_try_forward()
return false;
};
void Main::refresh()
{
mainTab->refresh(
mainTab->get_current_page()
);
};

2
src/app/browser/main.hpp

@ -36,7 +36,7 @@ namespace app::browser @@ -36,7 +36,7 @@ namespace app::browser
void tab_close_right();
void tab_close();
void tab_update();
void tab_page_update();
bool tab_page_navigation_history_try_back();
bool tab_page_navigation_history_try_forward();

15
src/app/browser/main/tab.cpp

@ -124,21 +124,12 @@ void Tab::refresh( @@ -124,21 +124,12 @@ void Tab::refresh(
);
}
void Tab::update(
void Tab::page_update(
const int & PAGE_NUMBER
) {
auto pageWidget = get_nth_page(
get_tabPage(
PAGE_NUMBER
);
if (pageWidget == nullptr)
{
throw _("Tab page not found!");
}
pageWidget->activate_action(
"page.update"
);
)->update();
}
// Private helpers

14
src/app/browser/main/tab.hpp

@ -40,6 +40,10 @@ namespace app::browser::main @@ -40,6 +40,10 @@ namespace app::browser::main
);
// Actions
void refresh(
const int & PAGE_NUMBER // @TODO
);
void append(
const Glib::ustring & TITLE,
const Glib::ustring & REQUEST = "",
@ -54,19 +58,15 @@ namespace app::browser::main @@ -54,19 +58,15 @@ namespace app::browser::main
void close_right();
void close_all();
bool page_navigation_history_try_back(
void page_update(
const int & PAGE_NUMBER
);
bool page_navigation_history_try_forward(
const int & PAGE_NUMBER
);
void refresh(
bool page_navigation_history_try_back(
const int & PAGE_NUMBER
);
void update(
bool page_navigation_history_try_forward(
const int & PAGE_NUMBER
);
};

17
src/app/browser/main/tab/page.cpp

@ -15,23 +15,6 @@ Page::Page( @@ -15,23 +15,6 @@ Page::Page(
Gtk::Orientation::VERTICAL
);
// Init actions group
auto GioSimpleActionGroup = Gio::SimpleActionGroup::create();
// Define group actions
GioSimpleActionGroup->add_action(
"update",
[this]
{
Page::update();
}
);
insert_action_group(
"page",
GioSimpleActionGroup
);
// Init components
pageNavigation = Gtk::make_managed<page::Navigation>(
REQUEST

1
src/app/browser/main/tab/page.hpp

@ -4,7 +4,6 @@ @@ -4,7 +4,6 @@
#include <giomm/asyncresult.h>
#include <giomm/inputstream.h>
#include <giomm/outputstream.h>
#include <giomm/simpleactiongroup.h>
#include <giomm/socketclient.h>
#include <giomm/socketconnection.h>
#include <glibmm/i18n.h>

2
src/app/browser/main/tab/page/navigation/request.cpp

@ -42,7 +42,7 @@ Request::Request( @@ -42,7 +42,7 @@ Request::Request(
parse();
activate_action(
"page.update"
"win.main_tab_page_navigation_update"
);
}
);

2
src/app/browser/main/tab/page/navigation/update.cpp

@ -5,7 +5,7 @@ using namespace app::browser::main::tab::page::navigation; @@ -5,7 +5,7 @@ using namespace app::browser::main::tab::page::navigation;
Update::Update()
{
set_action_name(
"page.update"
"win.main_tab_page_navigation_update"
);
set_icon_name(

16
src/main.cpp

@ -28,23 +28,23 @@ int main( @@ -28,23 +28,23 @@ int main(
// Init accels @TODO db settings
app->set_accel_for_action(
"win.main_tab_append",
"<Primary>t"
"win.debug",
"<Primary>i"
);
app->set_accel_for_action(
"win.main_tab_page_update",
"<Primary>r"
"app.quit",
"<Primary>q"
);
app->set_accel_for_action(
"win.debug",
"<Primary>i"
"win.main_tab_append",
"<Primary>t"
);
app->set_accel_for_action(
"app.quit",
"<Primary>q"
"win.main_tab_page_navigation_update",
"<Primary>r"
);
// Launch browser component

Loading…
Cancel
Save