removed non longer used mutex

libi2pd/NetDbRequests.cpp

@@ -35,7 +35,6 @@ namespace data
 	std::shared_ptr<I2NPMessage> RequestedDestination::CreateRequestMessage (std::shared_ptr<const RouterInfo> router,
 		std::shared_ptr<const i2p::tunnel::InboundTunnel> replyTunnel)
 	{
-		std::lock_guard<std::mutex> l (m_ExcludedPeersMutex);
 		std::shared_ptr<I2NPMessage> msg;
 		if(replyTunnel)
 			msg = i2p::CreateRouterInfoDatabaseLookupMsg (m_Destination,
@@ -52,7 +51,6 @@ namespace data
 
 	std::shared_ptr<I2NPMessage> RequestedDestination::CreateRequestMessage (const IdentHash& floodfill)
 	{
-		std::lock_guard<std::mutex> l (m_ExcludedPeersMutex);
 		auto msg = i2p::CreateRouterInfoDatabaseLookupMsg (m_Destination,
 			i2p::context.GetRouterInfo ().GetIdentHash () , 0, false, &m_ExcludedPeers);
 		m_ExcludedPeers.insert (floodfill);
@@ -63,22 +61,14 @@ namespace data
 
 	bool RequestedDestination::IsExcluded (const IdentHash& ident) const 
 	{ 
-		std::lock_guard<std::mutex> l (m_ExcludedPeersMutex);
 		return m_ExcludedPeers.count (ident); 
 	}
 		
 	void RequestedDestination::ClearExcludedPeers ()
 	{
-		std::lock_guard<std::mutex> l (m_ExcludedPeersMutex);
 		m_ExcludedPeers.clear ();
 	}
 		
-	std::unordered_set<IdentHash> RequestedDestination::GetExcludedPeers () const 
-	{ 
-		std::lock_guard<std::mutex> l (m_ExcludedPeersMutex);
-		return m_ExcludedPeers; 
-	}
-		
 	void RequestedDestination::Success (std::shared_ptr<RouterInfo> r)
 	{
 		if (m_IsActive)

libi2pd/NetDbRequests.h

@@ -41,7 +41,7 @@ namespace data
 			~RequestedDestination ();
 
 			const IdentHash& GetDestination () const { return m_Destination; };
-			std::unordered_set<IdentHash> GetExcludedPeers () const;
+			const std::unordered_set<IdentHash>& GetExcludedPeers () const { return m_ExcludedPeers; };
 			int GetNumAttempts () const { return m_NumAttempts; };
 			void ClearExcludedPeers ();
 			bool IsExploratory () const { return m_IsExploratory; };
@@ -63,7 +63,6 @@ namespace data
 
 			IdentHash m_Destination;
 			bool m_IsExploratory, m_IsDirect, m_IsActive;
-			mutable std::mutex m_ExcludedPeersMutex;
 			std::unordered_set<IdentHash> m_ExcludedPeers;
 			uint64_t m_CreationTime, m_LastRequestTime; // in seconds
 			RequestComplete m_RequestComplete;
@@ -84,14 +83,14 @@ namespace data
 			std::shared_ptr<RequestedDestination> CreateRequest (const IdentHash& destination, bool isExploratory, 
 				bool direct = false, RequestedDestination::RequestComplete requestComplete = nullptr);
 			void RequestComplete (const IdentHash& ident, std::shared_ptr<RouterInfo> r);
-			std::shared_ptr<RequestedDestination> FindRequest (const IdentHash& ident) const;
-			bool SendNextRequest (std::shared_ptr<RequestedDestination> dest);
-
 			void PostDatabaseSearchReplyMsg (std::shared_ptr<const I2NPMessage> msg);
 			void PostRequestDestination (const IdentHash& destination, const RequestedDestination::RequestComplete& requestComplete, bool direct);
 			
 		private:	
 
+			std::shared_ptr<RequestedDestination> FindRequest (const IdentHash& ident) const;
+			bool SendNextRequest (std::shared_ptr<RequestedDestination> dest);
+			
 			void HandleDatabaseSearchReplyMsg (std::shared_ptr<const I2NPMessage> msg);
 			void RequestDestination (const IdentHash& destination, const RequestedDestination::RequestComplete& requestComplete, bool direct);
 			void Explore (int numDestinations);