Browse Source

fixed memory leak

pull/73/merge
orignal 10 years ago
parent
commit
b19e6bb5ba
  1. 17
      TunnelEndpoint.cpp

17
TunnelEndpoint.cpp

@ -125,13 +125,8 @@ namespace tunnel @@ -125,13 +125,8 @@ namespace tunnel
if (fragmentNum == it->second.nextFragmentNum)
{
I2NPMessage * incompleteMessage = it->second.data;
if (incompleteMessage->len + size >= I2NP_MAX_MESSAGE_SIZE)
if (incompleteMessage->len + size < I2NP_MAX_MESSAGE_SIZE) // check if messega is not too long
{
LogPrint ("Fragment ", fragmentNum, " of message ", msgID, "exceeds max I2NP message size. Message dropped");
i2p::DeleteI2NPMessage (it->second.data);
m_IncompleteMessages.erase (it);
continue;
}
memcpy (incompleteMessage->buf + incompleteMessage->len, fragment, size); // concatenate fragment
incompleteMessage->len += size;
if (isLastFragment)
@ -144,6 +139,13 @@ namespace tunnel @@ -144,6 +139,13 @@ namespace tunnel
it->second.nextFragmentNum++;
}
else
{
LogPrint ("Fragment ", fragmentNum, " of message ", msgID, "exceeds max I2NP message size. Message dropped");
i2p::DeleteI2NPMessage (it->second.data);
m_IncompleteMessages.erase (it);
}
}
else
{
LogPrint ("Unexpected fragment ", fragmentNum, " instead ", it->second.nextFragmentNum, " of message ", msgID, ". Discarded");
i2p::DeleteI2NPMessage (it->second.data);
@ -157,6 +159,9 @@ namespace tunnel @@ -157,6 +159,9 @@ namespace tunnel
// last message is follow-on fragment
// not passed to anywhere because first fragment
i2p::DeleteI2NPMessage (msg);
else
// delete temporarty copy used for first fragment only
i2p::DeleteI2NPMessage (m.data);
}
}
else

Loading…
Cancel
Save