From 3d68b90ef9bc87f58e2559e22bd347c6eee11dd3 Mon Sep 17 00:00:00 2001 From: Simon Grim Date: Tue, 23 Feb 2016 01:08:01 +0500 Subject: [PATCH] fix wrong bindings for hyperlinks in fillElemWithTxt() --- js/interface_common.js | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/js/interface_common.js b/js/interface_common.js index e9f9989..aed0539 100644 --- a/js/interface_common.js +++ b/js/interface_common.js @@ -805,19 +805,16 @@ function fillElemWithTxt(elem, txt, htmlFormatMsgOpt) { var formatted = htmlFormatMsg(txt, htmlFormatMsgOpt); elem.html(formatted.html); - elem.find('a') - .on('mouseup', - function (event) { - var href = event.target.getAttribute('href'); - if (href[0] === '#') { - event.data = {route: href}; - routeOnClick(event); - } else - muteEvent(event); - } - ) - .on('click', {preventDefault: true}, muteEvent) - ; + elem.find('a').each(function (i, elem) { + var href = elem.getAttribute('href'); + if (href && href[0] === '#') + $(elem) + .on('click', {preventDefault: true}, muteEvent) + .on('mouseup', {route: href}, routeOnClick) + ; + else + $(elem).on('click mouseup', muteEvent); + }); return formatted; }