a3d12f445a
fix a memory leak in key.cpp
...
- add EC_KEY_free() in CKey::Reset() when pkey != NULL
- init pkey with NULL in CKey constructor
13 years ago
70f6049f71
Remove CTxDB::ReadOwnerTxes.
...
It seems it wasn't ever used since 0.1.5.
13 years ago
229c34f818
GUI: ensure a changed bitcoin unit immediately updates the tx list amounts
13 years ago
c283b3c569
print large orphan warning BEFORE deleting pvMsg
13 years ago
16d5671943
If (for example) the new max_size must be 5 then at the end the queue.size() must be <= 5, so the exit condition must be <=, so the continuing condition must be > (and not >= as it was).
13 years ago
4c6b210af0
Fix netbase tests
...
* Do not rely on "a.b.c" being interpreted as "a.0.b.c"
* Parse numeric addresses for address families for which no device is configured
13 years ago
0f5a2a82d9
CBigNum: Convert negative int64 values in a more well-defined way
...
Since the minimum signed integer cannot be represented as positive so long as its type is signed, and it's not well-defined what happens if you make it unsigned before negating it, we instead increment the negative integer by 1, convert it, then increment the (now positive) unsigned integer by 1 to compensate
13 years ago
896899e0d6
*Always* send a shutdown signal to enable custom shutdown actions
...
NOTE: This is required to be sure that we can properly shut down the RPC
thread.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
13 years ago
3bbb49de55
Fix inverted logic for !Discover/!UPNP when !Listen.
13 years ago
e0873dafc5
add the slot updateDisplayUnit() to overviewpage, sendcoinsdialog, sendcoinsentry and connect it to displayUnitChanged() - this ensures all fields in the GUI, who use a display unit are imediately updated, when the user changes this setting in the optionsdialog / ensure used fields init with the current set display unit
13 years ago
ad5f29b743
Revert "Disable bitcoin: URI handling on Windows for the 0.6 release"
...
This reverts commit 7b90edb5a6
13 years ago
1d42878adb
Fix #956 the Boost 1.49 way.
13 years ago
39471861d5
Upgrade to Boost 1.49 on Win32
13 years ago
c971112dfa
Use a 64-bit nonce in ping
...
Former code sent '0' as nonce, which was serialized as 32-bit.
13 years ago
c4971e24f9
Add netbase tests
13 years ago
1e8aeae15a
Improve parsing of IPv6 addresses
...
Implement the following rules:
* Interpret [X]:Y as host=X port=Y, if Y is an integer
* Interpret X:Y as host=X port=Y, if Y is an integer and X contains no colon
* Interpret X:Y as host=X:Y port=default otherwise
13 years ago
7d72a8c36a
Show command line options as dialog when opened from debug window
...
On Linux/Mac the command-line options were printed to stderr when the button
was pressed in the debug window, resulting in confusion. This is fixed
in this commit by adding a separate method.
13 years ago
641cfb1456
Fix build of testcases after commit 0f10b21719
13 years ago
f5f2d7410d
Reorganize tray icon menu into more logical order
...
The current order of menu options in the tray menu doesn't really match expected usage patterns, this commit changes it to more logical order.
- Toggle show/hide first (unchanged)
- Then, send/receive coins actions, which are the critical functionality of bitcoin
- Then, sign/verify message
- Then finally the options, and closing with the debug window
13 years ago
93b7af3099
URI-handling code update: added safety checks and tray-notifications
13 years ago
b5782531ad
set cursor for balance field to IBeamCursor (to show the user it IS selectable) and set autoDefault to false for the buttons that do not need this
13 years ago
15094f7654
Update bitcoinstrings from core and English source translation file
...
This is necessary as any strings have changed since last time.
Also the python script used to extract bitcoinstrings.cpp, extract_strings_qt.py
now sorts the strings before generating the output file. This results in more
deterministic output and thus smaller diffs.
13 years ago
66654ab02e
update translation files (fetched from Transifex) and remove translation for fr_FR, which was removed / renamed on TX
13 years ago
c4443c2be1
re-work optionsdialog to a tabbed UI based on an ui-file
...
- extend network options with a SOCKS version selection
- changing "Unit to show amounts in:" now also updates the unit used in the transaction fee box
- string updates
- link Apply button and OK button when enabling or disabling them
- use LookupNumeric() from netbase to verify proxy address (via an EventFilter)
- change proxy address field to QValidatedLineEdit and add visual feedback
- add a status label used for displaying a message for invalid proxy addresses
- allow usage of IPv6 address as proxy address
- added warning message when enabling / disabling SOCKS proxy
13 years ago
d2e6dd6c99
merge toggleHidden() code into showNormalIfMinimized() to extend the functionality, but keep a simpler toggleHidden() for use in SLOT() macro
13 years ago
d4b2f3c45b
make buttons in debug window non autoDefault
13 years ago
9b1732baae
Cross-platform "Open debug logfile"
...
The option to open the debug logfile from the debug window was implemented only for
windows. By using `QDesktopServices::openUrl` it now works on any platform.
13 years ago
2842fe4aa3
Do not select first address automatically in the address book
...
This contributed to an accidental send (#1384 ), and has no clear advantage, better to disable it.
13 years ago
9247134eab
introduce a new StartShutdown() function, which starts a thread with Shutdown() if no GUI is used and calls uiInterface.QueueShutdown() if a GUI is used / all direct uiInterface.QueueShutdown() calls are replaced with Shutdown() - this ensures a clean GUI shutdown, even when catching a SIGTERM and allows the BitcoinGUI destructor to get called (which fixes a tray-icon issue and keeps the tray-icon until Bitcoin-Qt exits)
13 years ago
59e0f445ce
change initial Balance on overviewpage from "123.456 BTC" to "0 BTC" to not confuse users, which could see it before we init with the real wallet balance
13 years ago
b065976007
Fix Mingw64 build (missing headers according to M$ documentation)
13 years ago
40d23dafb7
update info string in GUI for generated blocks and change "must wait" into "must mature" to take the new immature label into consideration
13 years ago
0ed0806bb4
Update comment about secure_allocator<>
13 years ago
31ac53fbdc
Move NOINLINE definition to test where it's used.
13 years ago
43346904e1
Don't overflow integer on 32-bit machines.
...
This was causing test_bitcoin to abort on a 32-bit system likely due to -ftrapv.
13 years ago
4d009243cb
Fix DEBUG_LOCKCONTENTION
13 years ago
618b250e34
add used datadir to debug.log
13 years ago
b69dd08ae7
fix two signed/unsigned comparison warnings in netbase.cpp
13 years ago
4e16306ae3
fix default Proxy address in Qt options (no hostname allowed currently)
13 years ago
831f59ce8b
Fix coin selection to only include change when it's necessary.
13 years ago
d650f96d5f
Preserve the shuffled order of coins with equal value to give more randomized coin selection.
13 years ago
4ce190a015
Test that the coin selection code is suitably random, and add tests re. sub-cent change.
13 years ago
e333ab56d5
Move the random_shuffle call back into SelectCoinsMinConf() so we can unit test it.
13 years ago
9b0369c773
Refactor SelectCoinsMinConf() and add unit tests.
...
AvailableCoins() makes a vector of available outputs which is then passed to SelectCoinsMinConf(). This allows unit tests to test the coin selection algorithm without having the whole blockchain available.
13 years ago
5d6b30271f
move class HelpMessageBox to guiutil.cpp/.h / add button to show Bitcoin command-line options (in RPC Console -> Information) / resize Debug window a little to allow for a non-breaking display of the welcome message with non-english translation
13 years ago
8103b0bb62
change verifymessagepage behaviour to match RPC-call "verifymessage" (input address, signature and message) / display messages in status label (remove message boxes) / resize window to make signature fully readable / change signature font to BC-address font (like in messagepage) / remove checkAddress() and place code directly in on_verifyMessage_clicked() / add visual feedback to LineEdits / remove AddressTableModel references, as they are now unused / add addr.GetKeyID(keyID) check
13 years ago
98474d3d6f
Use ConvertTo to simplify sendmany/addmultisigaddress argument handling
13 years ago
ea7582bb41
Make sendrawtx return txid to be consistent with other send methods.
13 years ago
10b45b4c2e
Use C++-style numeric limits instead of C-style.
13 years ago
78e851f94f
Fix noinline definition so that it works for more compilers.
13 years ago
Philip Kaufmann