0a83c0fcef
Fix tests after recent refactors
13 years ago
6b6aaa1698
Further reduce header dependencies
...
This commit removes the dependency of serialize.h on PROTOCOL_VERSION,
and makes this parameter required instead of implicit. This is much saner,
as it makes the places where changing a version number can have an
influence obvious.
13 years ago
ccd65d4261
Move proto version to version.h. Reduce header deps a bit more.
13 years ago
9eace6b113
Move CWalletDB code to new walletdb module.
...
In addition to standard code separation, this change opens the door
to fixing several include inter-dependencies.
13 years ago
ed6d0b5f85
Remove headers.h
13 years ago
c581cc16bb
Fix potential deadlock
...
Conflict:
* cs_main in ProcessMessages() (before calling ProcessMessages)
* cs_vSend in CNode::BeginMessage
versus:
* cs_vSend in ThreadMessageHandler2 (before calling SendMessages)
* cs_main in SendMessages
Even though cs_vSend is a try_lock, if it succeeds simultaneously with
the locking of cs_main in ProcessMessages(), it could cause a deadlock.
13 years ago
ce8c93498a
main.cpp: replace tabs with spaces
...
Sometimes they sneak in through the 'vi' door
13 years ago
8bff8ac079
AlreadyHave(): only hold lock during mapTransactions access
13 years ago
7fa3ad83a9
Remove unused and unreachable code
13 years ago
4941aad657
Add forgotten initializer
13 years ago
8f2b50f178
Reduce sync frequency for blkindex.dat
...
Since auto-remove-db-logs was enabled, each time a CTxDB was closed
outside of the initial download window, it causes a checkpoint + log
cleanup. This is overkill, so reduce the sync frequency to once per
minute at most.
13 years ago
ea9627979e
Bump PROTOCOL_VERSION to 60001, thereby enabling BIP31
13 years ago
9fb89c26f3
Fix misc. minor sign-comparison warnings
13 years ago
0dd710acb6
CNode's nHeaderStart may be negative, so change its type
13 years ago
c3fad8350b
serialize.h: CAutoFile's read and write may take size_t nSize
13 years ago
3a78f82a78
Fix sign-compare warnings: netbase's Lookup* max-solutions may be unsigned
13 years ago
c376ac359e
Fix loop index var types, fixing many minor sign comparison warnings
...
foo.size() typically returns an unsigned integral type; make loop variables
match those types' signedness.
13 years ago
ab9dc75a18
The string class returns string::npos, when find() fails.
...
Noticed when sign-comparison warnings were enabled.
13 years ago
ca4c4c53a8
CTxMemPool: add helper methods, to reduce global mempool.mapTx accesses
13 years ago
d01903e751
CTxMemPool: encapsulate AcceptToMemoryPool
13 years ago
8e45ed66dd
CTxMemPool: encapsulate AddToMemoryPoolUnchecked(), RemoveFromMemoryPool(),
...
and nPooledTx
13 years ago
235507ae48
New class CTxMemPool, encapsulating TX memory pool data members
13 years ago
da7bbd9dfd
fix warnings: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
13 years ago
6642ffb761
fix warnings: '&&' within '||' [-Wlogical-op-parentheses]
13 years ago
2e120f28e0
fix warnings: delete called on 'XX' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
13 years ago
11cd416525
fix warnings: unused variable 'XX' [-Wunused-variable]
13 years ago
76d8170ce8
fix warnings: enumeration values 'XX' not handled in switch [-Wswitch-enum]
13 years ago
87207a2e08
fix warnings: 'XX' defined as a struct here but previously declared as a class [-Wmismatched-tags]
13 years ago
8add7822ce
fix warnings: array subscript is of type 'char' [-Wchar-subscripts]
13 years ago
1f29d399f4
work around issue in boost::program_options that prevents from compiling in clang
13 years ago
f9f625fb32
enable all warnings except invalid-offsetof, sign-compare, unused-parameter
13 years ago
2eb665c634
Bugfix: Check that QRcode_encodeString didn't return NULL (error)
...
Without this, any error will segfault Bitcoin-Qt
13 years ago
a7a0c7a1bf
Show a message box when runaway exception happens
...
This is more clear to users than when the program simply disappears (usually during initialization). It still logs the message to the console and debug log as well.
13 years ago
3fddc8effc
Update translations for bitcoin core
...
- Move scripts/qt to share/qt, to clean up toplevel directories
- Update english ts file which is used to source messages for Transifex
- In extract_strings_qt.py use a glob *.h *.cpp, this is safe now that the Wx UI files are removed
13 years ago
b970067298
Do not show green tick unless all known blocks are downloaded ( fixes #921 )
13 years ago
8deb9822e4
Locking fix for AlreadyHave()
...
Access to mapTransactions[] must be guarded by cs_mapTransactions lock.
Also, reformat long lines to make the switch statement more readable.
13 years ago
9925d34a49
Database micro-optimization for "tx" network message
...
Open database once per "tx" message, rather than multiple times,
in the case of orphan transaction presence.
As a side effect, a now-unused CTransaction::AcceptToMemoryPool()
variant is removed.
13 years ago
2d67195ed2
Set label when selecting an address that already has a label. Fixes #1080 .
13 years ago
e72c6a1830
revert to default OS theme for progressbar / fix small glitches in bitcoingui.cpp
13 years ago
6b8e7eefcc
Add missing tooltip and key shortcut in settings dialog ( #1088 without line break part)
13 years ago
7a743148c9
Fix #1086 : add /testnet to passed datadir
13 years ago
8b09cd3a4d
Replace several network protocol version numbers with named constants
...
stored in version.h.
Also, a minor CAddress code reformat while we're in there, fixing
some incorrect indentation.
13 years ago
b3a6e613fc
CBitcoinSecret::SetString() now calls IsValid() to make sure it was passed something with the correct version.
13 years ago
181400c3d5
make text in about box selectable ( fixes #1055 )
13 years ago
7261945eb5
enable wordWrap on lblQRCode / small code comment change
13 years ago
b1a99c3a1f
limit length of generated URI to 255 chars to prevent a DoS against the QR-Code dialog
13 years ago
1e8c62b29c
updated to reflect pull-request suggestions / renamed some GUI elements
13 years ago
9e0dba8c17
fixed amount part of URI in QR-Codes / removed (no label) string if we have NO label / coding style updates / removed an unused variable
13 years ago
460b66b14b
Remove obsolete Win32 AffinityBugWorkaround()
...
Reference miner exists for testnet-in-a-box type situations, and as a
reference. We don't care enough about highly optimized internal
mining to keep workarounds like this.
13 years ago
b87c0fc440
version.h: separate client, net sections. Move more constants to this file.
...
* move PROTOCOL_VERSION to version.h
* move CLIENT_VERSION* to version.h, make available past cpp stage
* clearly separate client, network version portions of version.h
13 years ago
Pieter Wuille