Gavin Andresen
c648b589be
Merge pull request #459 from jgarzik/char-msgstart
...
Use 'unsigned char' rather than 'char' for pchMessageStart.
14 years ago
Gavin Andresen
72173ffaca
Merge pull request #460 from jgarzik/make-tuple
...
Qualify make_tuple with boost:: namespace.
14 years ago
Venkatesh Srinivas
25133bd74b
Use 'unsigned char' rather than 'char' for pchMessageStart.
...
Regarding https://bitcointalk.org/index.php?topic=28022.0
main.cpp has: "char pchMessageStart[4] = { 0xf9, 0xbe, 0xb4, 0xd9 };"
Per discussion on the thread linked, leaving the signedness of
pchMessageStart is unsafe for values > 0x80. This patch specifies
'unsigned char' in main.cpp and net.h.
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
14 years ago
Venkatesh Srinivas
7c3002bf27
Qualify make_tuple with boost:: namespace.
...
db.cpp has a number of uses of make_tuple and has 'using namespace
std' and 'using namespace boost'. Without qualifying make_tuple,
std::make_tuple is preferred, which is incorrect. This patch qualifies
make_tuple.
Signed-off-by: Jeff Garzik <jgarzik@exmulti.com>
14 years ago
Venkatesh Srinivas
ec93a0e219
Test for SO_NOSIGPIPE rather than assuming all BSDs support it.
...
Signed-off-by: Jeff Garzik <jgarzik@exmulti.com>
14 years ago
Gavin Andresen
9f0ac16942
Do-nothing MapPort() ifndef USE_UPNP. fixes #450
14 years ago
Matt Corallo
b2120e223a
Unify copyright notices.
...
To a variation on:
// Copyright (c) 2009-2010 Satoshi Nakamoto
// Copyright (c) 2011 The Bitcoin developers
14 years ago
Matt Corallo
2c3691d53d
Cleanup test suite output to be more useful.
14 years ago
Matt Corallo
3c8cecda1f
Add file for transaction tests.
14 years ago
Vegard Nossum
a8330e0049
Add a file for script tests
14 years ago
Vegard Nossum
5f6a654d3e
Add prototype for EvalScript() to script.h
...
This is needed for the script unit tests.
14 years ago
Vegard Nossum
e707d29dd6
Fix testing setup
...
There were some problems with the existing testing setup:
- Makefile rules for test-file compilation used CFLAGS instead of
CXXFLAGS in makefile.unix
14 years ago
Matt Corallo
02962ba848
Add missing include to serialize.h
14 years ago
Vegard Nossum
8a62fec3ee
Add missing includes to net.h
14 years ago
Vegard Nossum
437173f430
Add missing include to script.h
14 years ago
Vegard Nossum
fcedd45c3c
Add missing includes to key.h
14 years ago
Gavin Andresen
4e5d88ce26
Merge pull request #443 from TheBlueMatt/dupin
...
Check for duplicate txins in CheckTransaction.
14 years ago
Jeff Garzik
bd1e54bc0b
Merge branch 'tmp2'
14 years ago
Jeff Garzik
eb20f3c8f5
Merge pull request #448 from sipa/cbitcoinaddress
...
avoid strAddress + validity checks
14 years ago
Jeff Garzik
95699e1730
Merge pull request #446 from WakiMiko/upnp-desc
...
Identify as "Bitcoin + version number" when mapping UPnP port
14 years ago
Jeff Garzik
32de8cd062
Merge pull request #451 from TheBlueMatt/tornolisten
...
Don't listen if on TOR (resolves #441 ).
14 years ago
Matt Corallo
01a509fa26
Don't listen if on TOR ( resolves #441 ).
14 years ago
Matt Corallo
918150048a
Make it clear that setting proxy requires restart to fully apply.
14 years ago
Pieter Wuille
4d2ef6e5b6
avoid strAddress + validity checks
...
Avoid references to addresses using strings, and use CBitcoinAddress
as much as possible. Also added some validity checks on addresses
entered using RPC.
14 years ago
Pieter Wuille
ce364b2d7a
Merge pull request #444 from Jeroenz0r/patch-2
...
Translation from "Open Bitcoin" to "Verstuur Bitcoins"
14 years ago
Johannes Henninger
1565698169
Identify as "Bitcoin + version number" when mapping UPnP port
...
Makes Bitcoin identify itself as "Bitcoin + version number" instead of
the nondescript "libminiupnpc" when forwarding a port via UPnP.
14 years ago
Gavin Andresen
9326234109
Merge pull request #437 from codler/patch-2
...
Comment "deprecated"
14 years ago
Jeroenz0r
364685e195
Translation from "Open Bitcoin" to "Verstuur Bitcoins"
14 years ago
Matt Corallo
33208fb557
Check for duplicate txins in CheckTransaction.
14 years ago
Han Lin Yap
8c2143d4d8
Comment "deprecated"
14 years ago
Pieter Wuille
e1f13129e8
Merge pull request #436 from TheBlueMatt/master
...
Fix EncryptKeys crash introduced by a9ba471
, identified by TD.
14 years ago
Matt Corallo
687c82558c
Fix EncryptKeys crash introduced by a9ba4710
, identified by TD.
14 years ago
Jeff Garzik
a139ed74f2
CAddrDB::LoadAddresses: properly initialize CAddress
...
Fixes issue #424
14 years ago
Pieter Wuille
aa7c5e7ceb
Merge pull request #435 from sipa/fixextract
...
Bugfix: don't overuse limited ExtractAddress
14 years ago
Pieter Wuille
b63241d451
Bugfix: don't overuse limited ExtractAddress
...
ExtractAddress was called with the keystore as argument in RPC and
UI, limiting results to own keys. This caused empty "address"
fields.
14 years ago
Pieter Wuille
a0eb1d151f
Merge pull request #434 from laanwj/addkey_retval
...
make SetHash160 return a value (as specified in the function signature)
14 years ago
Wladimir J. van der Laan
690c723e5f
make SetHash160 return a value (as specified in the function signature)
14 years ago
JoelKatz
67ed7d9d49
Fix UNIX-specific thread handle leak.
14 years ago
Jeff Garzik
a9ba47101a
Merge pull request #403 from sipa/cbitcoinaddress
...
keys indexed by address + introduced CBitcoinaddress
14 years ago
Pieter Wuille
b6d19aefa0
Merge pull request #428 from sipa/mintxfeefix
...
Fix for small change outputs
14 years ago
Pieter Wuille
a7dd11c6da
Fix for small change outputs
...
With the separation of CENT and MIN_TX_FEE, it is now reasonable
to create change outputs between 0.01 and 0.0005, as these are
spendable according to the policy, even though they require a fee
to be paid.
Also, when enough fee was already present, everything can go into
a change output, without further increasing the fee.
14 years ago
Jeff Garzik
c2da35319d
Merge pull request #423 from TheBlueMatt/mapalreadyaskedforfix
...
Actually use mapAlreadyAskedFor.
14 years ago
Matt Corallo
643160f6e7
Actually use mapAlreadyAskedFor.
...
Previously, mapAlreadyAskedFor was read from, but never added to.
The original intent was to use mapAlreadyAskedFor to keep track
of the time an item was requested and "Each retry is 2 minutes
after the last".
This implements that intent.
14 years ago
Pieter Wuille
ca40e581eb
Merge pull request #1 from AbrahamJewowich/cbitcoinaddress
...
Cbitcoinaddress
14 years ago
Abraham Jewowich
03f8b54565
Fix bug with accessing vchData[0] when vchData is empty.
...
Fix typo in CBase58Data::CompareTo
14 years ago
Gavin Andresen
9e3e21efeb
Merge pull request #419 from mibe/translation-de
...
Updated German translation
14 years ago
Gavin Andresen
993d37b90b
Merge pull request #395 from mibe/issue-395
...
Error in Russian Translation
14 years ago
Pieter Wuille
cb61b8dc4c
split off CBase58Data from CBitcoinAddress
...
Split off features unrelated to addresses from CBitcoinAddress to
CBase58Data, so they can be reused.
14 years ago
Pieter Wuille
2ffba736e9
Use CBitcoinAddress instead of string/uint160
...
Instead of conversion functions between pubkey/uint160/address in
base58.h, have a fully fledged class CBitcoinAddress (CAddress was
already taken) to represent addresses.
14 years ago
Pieter Wuille
03fbd79049
get rid of mapPubKeys
...
Make CKeyStore's interface work on uint160's instead of pubkeys, so
no separate global mapPubKeys is necessary anymore.
14 years ago