Allow -upnp to override setting in wallet (and simplify logic a bit)

src/init.cpp

@@ -487,16 +487,11 @@ bool AppInit2(int argc, char* argv[])
     fAllowDNS = GetBoolArg("-dns");
     fNoListen = GetBoolArg("-nolisten");
 
-    if (fHaveUPnP)
+    // Command-line args override in-wallet settings:
-    {
+    if (mapArgs.count("-upnp"))
-#if USE_UPNP
+        fUseUPnP = GetBoolArg("-upnp");
-    if (GetBoolArg("-noupnp"))
+    else if (mapArgs.count("-noupnp"))
-        fUseUPnP = false;
+        fUseUPnP = !GetBoolArg("-noupnp");
-#else
-    if (GetBoolArg("-upnp"))
-        fUseUPnP = true;
-#endif
-    }
 
     if (!fNoListen)
     {