twisterarmy/twister-core
1
0
Fork 0
mirror of https://github.com/twisterarmy/twister-core.git synced 2025-01-09 06:18:02 +00:00
Code Issues Projects Releases Wiki Activity

implement group_members splitting to fit max post size (conservative estimate)

Browse Source
This commit is contained in:
Miguel Freitas 2015-04-23 22:01:55 -03:00
parent 8379dde980
commit 7dc7065d07
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/twister.cpp
View File

@ -1109,7 +1109,7 @@ void storeNewDM(const string &localuser, const string &dmUser, const StoredDirec
stoDM.m_text == (*it).m_text ) { stoDM.m_text == (*it).m_text ) {
break; break;
} }
if( stoDM.m_utcTime < (*it).m_utcTime ) { if( stoDM.m_utcTime <= (*it).m_utcTime ) {
dmsFromToUser.insert(it, stoDM); dmsFromToUser.insert(it, stoDM);
break; break;
} }
@ -3508,15 +3508,19 @@ Value newgroupinvite(const Array& params, bool fHelp)
} }
/* create group_members DM and send it to group */ /* create group_members DM and send it to group */
{ while( !membersList.empty() ) {
/* FIXME: if we have too many members, this code will break!
* we must check byteCounter and split in multiple DMs as needed to not exceed max size.
*/
entry groupMembers; entry groupMembers;
int byteCounter = 0; int byteCounter = 0;
BOOST_FOREACH( string const &member, membersList) { while( !membersList.empty() ) {
std::set<std::string>::iterator it = membersList.begin();
std::string member=*it;
groupMembers.list().push_back(member); groupMembers.list().push_back(member);
byteCounter += member.length() + 3; membersList.erase(it);
// estimate bencoded size. split in multiple DMs.
byteCounter += member.length() + 2 + member.length()/10;
if( byteCounter > 150 )
break;
} }
entry payloadMsg; entry payloadMsg;
payloadMsg["group_members"] = groupMembers; payloadMsg["group_members"] = groupMembers;